From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>,
Linux kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through
Date: Wed, 31 Jul 2019 00:41:53 +1000 [thread overview]
Message-ID: <20190731004153.6c6198fa@canb.auug.org.au> (raw)
In-Reply-To: <878ssfzjdk.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi Michael,
On Wed, 31 Jul 2019 00:28:55 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Why do we think it's an expected fall through? I can't really convince
> myself from the surrounding code that it's definitely intentional.
Its been that way since this code was introduced by commit
0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")
in 2005 ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: PowerPC <linuxppc-dev@lists.ozlabs.org>,
Kees Cook <keescook@chromium.org>,
Linux kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through
Date: Wed, 31 Jul 2019 00:41:53 +1000 [thread overview]
Message-ID: <20190731004153.6c6198fa@canb.auug.org.au> (raw)
In-Reply-To: <878ssfzjdk.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi Michael,
On Wed, 31 Jul 2019 00:28:55 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Why do we think it's an expected fall through? I can't really convince
> myself from the surrounding code that it's definitely intentional.
Its been that way since this code was introduced by commit
0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")
in 2005 ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-30 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 4:37 [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through Stephen Rothwell
2019-07-30 4:37 ` Stephen Rothwell
2019-07-30 4:45 ` Stephen Rothwell
2019-07-30 4:45 ` Stephen Rothwell
2019-07-30 14:28 ` Michael Ellerman
2019-07-30 14:28 ` Michael Ellerman
2019-07-30 14:41 ` Stephen Rothwell [this message]
2019-07-30 14:41 ` Stephen Rothwell
2019-07-30 17:07 ` Kees Cook
2019-07-30 17:07 ` Kees Cook
2019-07-30 20:37 ` Benjamin Herrenschmidt
2019-07-30 20:37 ` Benjamin Herrenschmidt
2019-07-31 11:46 ` Michael Ellerman
2019-07-31 11:46 ` Michael Ellerman
2019-08-02 2:28 ` Michael Ellerman
2019-08-02 2:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731004153.6c6198fa@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=benh@kernel.crashing.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.