* [Buildroot] [PATCH 1/1] package/host-mtd: fixes build
@ 2019-07-29 12:11 julien.boibessot at free.fr
2019-07-30 20:44 ` Markus Mayer
2019-07-31 7:25 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: julien.boibessot at free.fr @ 2019-07-29 12:11 UTC (permalink / raw)
To: buildroot
From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
Fixes following build error when Host doesn't have zstd devt files:
configure: WARNING: cannot find ZSTD library required for mkfs program
configure: mtd-utils can optionally be built without mkfs.ubifs
configure: mtd-utils can optionally be built without ZSTD support
configure: WARNING: cannot find headers for OpenSSL library
configure: WARNING: disabling OpenSSL support
configure: error: missing one or more dependencies
package/pkg-generic.mk:228: recipe for target '/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured' failed
make: *** [/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured] Error 1
Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
---
package/mtd/mtd.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
index 0de14db..65e7622 100644
--- a/package/mtd/mtd.mk
+++ b/package/mtd/mtd.mk
@@ -46,7 +46,7 @@ else
MTD_CONF_OPTS += --without-xattr
endif
-HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux
+HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd
HOST_MTD_CONF_OPTS = \
--with-jffs \
--with-ubifs \
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/host-mtd: fixes build
2019-07-29 12:11 [Buildroot] [PATCH 1/1] package/host-mtd: fixes build julien.boibessot at free.fr
@ 2019-07-30 20:44 ` Markus Mayer
2019-07-31 7:25 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Markus Mayer @ 2019-07-30 20:44 UTC (permalink / raw)
To: buildroot
On Mon, 29 Jul 2019 at 05:11, <julien.boibessot@free.fr> wrote:
>
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>
> Fixes following build error when Host doesn't have zstd devt files:
> configure: WARNING: cannot find ZSTD library required for mkfs program
> configure: mtd-utils can optionally be built without mkfs.ubifs
> configure: mtd-utils can optionally be built without ZSTD support
> configure: WARNING: cannot find headers for OpenSSL library
> configure: WARNING: disabling OpenSSL support
> configure: error: missing one or more dependencies
> package/pkg-generic.mk:228: recipe for target '/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured' failed
> make: *** [/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured] Error 1
I ran into the same issue following the bump of mtd-utils to 2.1.1,
and this patch took care of it for me. Therefore
Tested-by: Markus Mayer <mmayer@broadcom.com>
Regards,
-Markus
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> ---
> package/mtd/mtd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index 0de14db..65e7622 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -46,7 +46,7 @@ else
> MTD_CONF_OPTS += --without-xattr
> endif
>
> -HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux
> +HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd
> HOST_MTD_CONF_OPTS = \
> --with-jffs \
> --with-ubifs \
> --
> 2.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/host-mtd: fixes build
2019-07-29 12:11 [Buildroot] [PATCH 1/1] package/host-mtd: fixes build julien.boibessot at free.fr
2019-07-30 20:44 ` Markus Mayer
@ 2019-07-31 7:25 ` Thomas Petazzoni
2019-07-31 10:48 ` Julien Boibessot
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-07-31 7:25 UTC (permalink / raw)
To: buildroot
Hello Julien,
The commit title should rather be:
package/mtd: add host-zstd dependency to host variant to fix build
On Mon, 29 Jul 2019 14:11:40 +0200
julien.boibessot at free.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>
> Fixes following build error when Host doesn't have zstd devt files:
This should also mention that the issue was introduced in the commit
bumping to 2.1.1, and add references to the autobuilder failures.
However, why does this problem only occurs for the host variant, and
not the target variant.
Why is this warning causing a build failure ? Normally warnings are
just warnings, not errors.
Is this zstd dependency optional somehow ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/host-mtd: fixes build
2019-07-31 7:25 ` Thomas Petazzoni
@ 2019-07-31 10:48 ` Julien Boibessot
0 siblings, 0 replies; 4+ messages in thread
From: Julien Boibessot @ 2019-07-31 10:48 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On 31/07/2019 09:25, Thomas Petazzoni wrote:
> Hello Julien,
>
> The commit title should rather be:
>
> package/mtd: add host-zstd dependency to host variant to fix build
OK
>
> On Mon, 29 Jul 2019 14:11:40 +0200
> julien.boibessot at free.fr wrote:
>
>> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>>
>> Fixes following build error when Host doesn't have zstd devt files:
> This should also mention that the issue was introduced in the commit
> bumping to 2.1.1, and add references to the autobuilder failures.
OK. autobuilder failures came *after* my patch ;-)
>
> However, why does this problem only occurs for the host variant, and
> not the target variant.
>
> Why is this warning causing a build failure ? Normally warnings are
> just warnings, not errors.
>
> Is this zstd dependency optional somehow ?
It seems like zstd is now needed if ubifs is selected, like stated in
mtd configure.ac:
AM_COND_IF([BUILD_UBIFS], [
need_uuid="yes"
need_xattr="yes"
need_zlib="yes"
need_lzo="yes"
need_zstd="yes" <<<<<<<<
need_openssl="yes"
])
So you were right, target mtd build is also impacted....
I will resend a patch to correct both target and host build.
Regards,
Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190731/584bf9f9/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-31 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 12:11 [Buildroot] [PATCH 1/1] package/host-mtd: fixes build julien.boibessot at free.fr
2019-07-30 20:44 ` Markus Mayer
2019-07-31 7:25 ` Thomas Petazzoni
2019-07-31 10:48 ` Julien Boibessot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.