* [PATCH] ASoC: ti: Mark expected switch fall-throughs
@ 2019-07-29 22:15 Gustavo A. R. Silva
2019-07-30 10:55 ` Jarkko Nikula
2019-07-31 11:29 ` Applied "ASoC: ti: Mark expected switch fall-throughs" to the asoc tree Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 22:15 UTC (permalink / raw)
To: Peter Ujfalusi, Jarkko Nikula, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-omap, linux-kernel, Gustavo A. R. Silva, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
sound/soc/ti/n810.c: In function ‘n810_ext_control’:
sound/soc/ti/n810.c:48:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
line1l = 1;
~~~~~~~^~~
sound/soc/ti/n810.c:49:2: note: here
case N810_JACK_HP:
^~~~
sound/soc/ti/rx51.c: In function ‘rx51_ext_control’:
sound/soc/ti/rx51.c:57:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
hs = 1;
~~~^~~
sound/soc/ti/rx51.c:58:2: note: here
case RX51_JACK_HP:
^~~~
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/ti/n810.c | 1 +
sound/soc/ti/rx51.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/sound/soc/ti/n810.c b/sound/soc/ti/n810.c
index 2c3f2a4c1700..3ad2b6daf31e 100644
--- a/sound/soc/ti/n810.c
+++ b/sound/soc/ti/n810.c
@@ -46,6 +46,7 @@ static void n810_ext_control(struct snd_soc_dapm_context *dapm)
switch (n810_jack_func) {
case N810_JACK_HS:
line1l = 1;
+ /* fall through */
case N810_JACK_HP:
hp = 1;
break;
diff --git a/sound/soc/ti/rx51.c b/sound/soc/ti/rx51.c
index bc6046534fa5..ccd0e8a07dd1 100644
--- a/sound/soc/ti/rx51.c
+++ b/sound/soc/ti/rx51.c
@@ -55,6 +55,7 @@ static void rx51_ext_control(struct snd_soc_dapm_context *dapm)
break;
case RX51_JACK_HS:
hs = 1;
+ /* fall through */
case RX51_JACK_HP:
hp = 1;
break;
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: ti: Mark expected switch fall-throughs
2019-07-29 22:15 [PATCH] ASoC: ti: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-30 10:55 ` Jarkko Nikula
2019-07-31 11:29 ` Applied "ASoC: ti: Mark expected switch fall-throughs" to the asoc tree Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2019-07-30 10:55 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Peter Ujfalusi, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-omap, linux-kernel, Kees Cook
On Mon, Jul 29, 2019 at 05:15:34PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: arm):
>
> sound/soc/ti/n810.c: In function ‘n810_ext_control’:
> sound/soc/ti/n810.c:48:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
> line1l = 1;
> ~~~~~~~^~~
> sound/soc/ti/n810.c:49:2: note: here
> case N810_JACK_HP:
> ^~~~
>
> sound/soc/ti/rx51.c: In function ‘rx51_ext_control’:
> sound/soc/ti/rx51.c:57:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> hs = 1;
> ~~~^~~
> sound/soc/ti/rx51.c:58:2: note: here
> case RX51_JACK_HP:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> sound/soc/ti/n810.c | 1 +
> sound/soc/ti/rx51.c | 1 +
> 2 files changed, 2 insertions(+)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: ti: Mark expected switch fall-throughs
@ 2019-07-30 10:55 ` Jarkko Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2019-07-30 10:55 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: alsa-devel, linux-omap, Kees Cook, linux-kernel, Takashi Iwai,
Liam Girdwood, Peter Ujfalusi, Mark Brown
On Mon, Jul 29, 2019 at 05:15:34PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: arm):
>
> sound/soc/ti/n810.c: In function ‘n810_ext_control’:
> sound/soc/ti/n810.c:48:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
> line1l = 1;
> ~~~~~~~^~~
> sound/soc/ti/n810.c:49:2: note: here
> case N810_JACK_HP:
> ^~~~
>
> sound/soc/ti/rx51.c: In function ‘rx51_ext_control’:
> sound/soc/ti/rx51.c:57:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> hs = 1;
> ~~~^~~
> sound/soc/ti/rx51.c:58:2: note: here
> case RX51_JACK_HP:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> sound/soc/ti/n810.c | 1 +
> sound/soc/ti/rx51.c | 1 +
> 2 files changed, 2 insertions(+)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Applied "ASoC: ti: Mark expected switch fall-throughs" to the asoc tree
2019-07-29 22:15 [PATCH] ASoC: ti: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-30 10:55 ` Jarkko Nikula
@ 2019-07-31 11:29 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-07-31 11:29 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: alsa-devel, linux-omap, Kees Cook, Takashi Iwai, Liam Girdwood,
linux-kernel, Peter Ujfalusi, Mark Brown, Jarkko Nikula
[-- Attachment #1: Type: text/plain, Size: 2878 bytes --]
The patch
ASoC: ti: Mark expected switch fall-throughs
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 22581e7c51f50fbbadba70499bb5e2d09f830cbb Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 29 Jul 2019 17:15:34 -0500
Subject: [PATCH] ASoC: ti: Mark expected switch fall-throughs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
sound/soc/ti/n810.c: In function ‘n810_ext_control’:
sound/soc/ti/n810.c:48:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
line1l = 1;
~~~~~~~^~~
sound/soc/ti/n810.c:49:2: note: here
case N810_JACK_HP:
^~~~
sound/soc/ti/rx51.c: In function ‘rx51_ext_control’:
sound/soc/ti/rx51.c:57:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
hs = 1;
~~~^~~
sound/soc/ti/rx51.c:58:2: note: here
case RX51_JACK_HP:
^~~~
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Link: https://lore.kernel.org/r/20190729221534.GA18696@embeddedor
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/ti/n810.c | 1 +
sound/soc/ti/rx51.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/sound/soc/ti/n810.c b/sound/soc/ti/n810.c
index 2c3f2a4c1700..3ad2b6daf31e 100644
--- a/sound/soc/ti/n810.c
+++ b/sound/soc/ti/n810.c
@@ -46,6 +46,7 @@ static void n810_ext_control(struct snd_soc_dapm_context *dapm)
switch (n810_jack_func) {
case N810_JACK_HS:
line1l = 1;
+ /* fall through */
case N810_JACK_HP:
hp = 1;
break;
diff --git a/sound/soc/ti/rx51.c b/sound/soc/ti/rx51.c
index bc6046534fa5..ccd0e8a07dd1 100644
--- a/sound/soc/ti/rx51.c
+++ b/sound/soc/ti/rx51.c
@@ -55,6 +55,7 @@ static void rx51_ext_control(struct snd_soc_dapm_context *dapm)
break;
case RX51_JACK_HS:
hs = 1;
+ /* fall through */
case RX51_JACK_HP:
hp = 1;
break;
--
2.20.1
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-31 11:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 22:15 [PATCH] ASoC: ti: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-30 10:55 ` Jarkko Nikula
2019-07-30 10:55 ` Jarkko Nikula
2019-07-31 11:29 ` Applied "ASoC: ti: Mark expected switch fall-throughs" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.