* [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
@ 2019-07-22 5:16 Petr Vorel
2019-07-22 5:16 ` [Buildroot] [PATCH 2/2] system: Add XATTR abbreviation Petr Vorel
2019-07-31 16:08 ` [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2019-07-22 5:16 UTC (permalink / raw)
To: buildroot
Enable BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES if none
of non-supported rootfs is selected.
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,
not sure about cloop, cpio, tar, ubi.
Kind regards,
Petr
system/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/system/Config.in b/system/Config.in
index af7d8566d3..842e745cd3 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE
config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
bool "support extended attributes in device tables"
+ default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2
help
Support extended attributes handling in device tables
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] system: Add XATTR abbreviation
2019-07-22 5:16 [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Petr Vorel
@ 2019-07-22 5:16 ` Petr Vorel
2019-07-31 16:08 ` [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2019-07-22 5:16 UTC (permalink / raw)
To: buildroot
to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
+ capitalize
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,
you can squash this commit into previous one.
Kind regards,
Petr
system/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system/Config.in b/system/Config.in
index 842e745cd3..39f8603639 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -195,7 +195,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE
syntax of these files.
config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
- bool "support extended attributes in device tables"
+ bool "Support extended attributes (XATTR) in device tables"
default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2
help
Support extended attributes handling in device tables
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
2019-07-22 5:16 [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Petr Vorel
2019-07-22 5:16 ` [Buildroot] [PATCH 2/2] system: Add XATTR abbreviation Petr Vorel
@ 2019-07-31 16:08 ` Yann E. MORIN
2019-07-31 19:43 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2019-07-31 16:08 UTC (permalink / raw)
To: buildroot
Petr, All,
On 2019-07-22 07:16 +0200, Petr Vorel spake thusly:
> Enable BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES if none
> of non-supported rootfs is selected.
No, sorry.
As I explained in another thread, there are valid cases where one does
not need capabilities (and thus xattrs) on their systems.
In that case, your change would mean that the defconfig files of those
people now default to using xattrs, when they previously would not.
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Hi,
>
> not sure about cloop, cpio, tar, ubi.
>
> Kind regards,
> Petr
>
> system/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/system/Config.in b/system/Config.in
> index af7d8566d3..842e745cd3 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE
>
> config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
> bool "support extended attributes in device tables"
> + default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2
In any case, iff we were to add this, this should be done differently,
because we do not want to hard-code the list of filesystems here. For
one, becaise the list is long; and for two, because of filesystems from
the br2-external trees.
Instead, we would have to do:
config BR2_ROOTFS_SUPPORTS_XATTRS
bool
config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
bool "support extended attributes in device tables"
default y if BR2_ROOTFS_SUPPORTS_XATTRS
and then filesystems would be responsible for setting:
config BR2_TARGET_ROOTFS_EXT2
bool "ext2/3/4 root filesystem"
select BR2_ROOTFS_SUPPORTS_XATTRS
But again, I think it does not gain much. People who want xattrs will
know enough to enable it.
Regards,
Yann E. MORIN.
> help
> Support extended attributes handling in device tables
>
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
2019-07-31 16:08 ` [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Yann E. MORIN
@ 2019-07-31 19:43 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2019-07-31 19:43 UTC (permalink / raw)
To: buildroot
Hi Yann,
> Petr, All,
> On 2019-07-22 07:16 +0200, Petr Vorel spake thusly:
> > Enable BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES if none
> > of non-supported rootfs is selected.
> No, sorry.
> As I explained in another thread, there are valid cases where one does
> not need capabilities (and thus xattrs) on their systems.
> In that case, your change would mean that the defconfig files of those
> people now default to using xattrs, when they previously would not.
OK, agree, thanks for an explanation.
I've set it in patchwork as rejected (+ delegate to you).
I'd still add the second patch (adding "(XATTR)" I find it just by chance, as I
didn't search for "extended attributes", but for XATTR.
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > Hi,
> > not sure about cloop, cpio, tar, ubi.
> > Kind regards,
> > Petr
> > system/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> > diff --git a/system/Config.in b/system/Config.in
> > index af7d8566d3..842e745cd3 100644
> > --- a/system/Config.in
> > +++ b/system/Config.in
> > @@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE
> > config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
> > bool "support extended attributes in device tables"
> > + default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2
> In any case, iff we were to add this, this should be done differently,
> because we do not want to hard-code the list of filesystems here. For
> one, becaise the list is long; and for two, because of filesystems from
> the br2-external trees.
> Instead, we would have to do:
> config BR2_ROOTFS_SUPPORTS_XATTRS
> bool
> config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
> bool "support extended attributes in device tables"
> default y if BR2_ROOTFS_SUPPORTS_XATTRS
> and then filesystems would be responsible for setting:
> config BR2_TARGET_ROOTFS_EXT2
> bool "ext2/3/4 root filesystem"
> select BR2_ROOTFS_SUPPORTS_XATTRS
On first (unposted) version I implemented it this way :).
> But again, I think it does not gain much. People who want xattrs will
> know enough to enable it.
> Regards,
> Yann E. MORIN.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-31 19:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 5:16 [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Petr Vorel
2019-07-22 5:16 ` [Buildroot] [PATCH 2/2] system: Add XATTR abbreviation Petr Vorel
2019-07-31 16:08 ` [Buildroot] [PATCH 1/2] system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES Yann E. MORIN
2019-07-31 19:43 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.