* [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
@ 2019-07-31 22:32 Uwe Kleine-König
2019-08-01 15:30 ` Martin Michlmayr
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2019-07-31 22:32 UTC (permalink / raw)
To: Jason Cooper, Gregory Clement, Sebastian Hesselbarth
Cc: Andrew Lunn, Alexandre Belloni, tbm, linux-arm-kernel, Oliver Hartkopp
[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]
The internal RTC doesn't work, loading the driver only yields
rtc-mv f1010300.rtc: internal RTC not ticking
. So disable it.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
Hello,
This patch is (one) result of a discussion on the rtc list. v1 was sent
there only. This v2 is just a resend to the mvebu maintainers.
Alexandre Belloni said to v1: Seems good to me then.
This sounds a bit like an ack, but I didn't add it as it was not
explicit.
Best regards
Uwe
arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
index a88eb22070a1..994cabcf4b51 100644
--- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
+++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
@@ -104,3 +104,11 @@
&pcie0 {
status = "okay";
};
+
+&rtc {
+ /*
+ * There is a s35390a available on the i2c bus, the internal rtc isn't
+ * working (probably no crystal assembled).
+ */
+ status = "disabled";
+};
--
2.20.1
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-31 22:32 [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
@ 2019-08-01 15:30 ` Martin Michlmayr
2019-08-01 20:23 ` Alexandre Belloni
2019-08-27 13:47 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Martin Michlmayr @ 2019-08-01 15:30 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Andrew Lunn, Alexandre Belloni, Jason Cooper, Oliver Hartkopp,
Gregory Clement, linux-arm-kernel, Sebastian Hesselbarth
* Uwe Kleine-König <uwe@kleine-koenig.org> [2019-08-01 00:32]:
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Martin Michlmayr <tbm@cyrius.com>
This solves an issue I reported back in 2009, as Oliver Hartkopp
pointed out to my privately:
https://linux-arm-kernel.infradead.narkive.com/jySn4Wsw/patch-kirkwood-don-t-initialize-marvell-rtc-for-all-boards
(I contributed to the QNAP board support file in past but that was
replaced by the DT files.)
--
Martin Michlmayr
https://www.cyrius.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-31 22:32 [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-08-01 15:30 ` Martin Michlmayr
@ 2019-08-01 20:23 ` Alexandre Belloni
2019-08-27 13:47 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2019-08-01 20:23 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Andrew Lunn, Jason Cooper, Oliver Hartkopp, Gregory Clement, tbm,
linux-arm-kernel, Sebastian Hesselbarth
On 01/08/2019 00:32:33+0200, Uwe Kleine-König wrote:
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Hello,
>
> This patch is (one) result of a discussion on the rtc list. v1 was sent
> there only. This v2 is just a resend to the mvebu maintainers.
>
> Alexandre Belloni said to v1: Seems good to me then.
>
> This sounds a bit like an ack, but I didn't add it as it was not
> explicit.
>
> Best regards
> Uwe
>
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index a88eb22070a1..994cabcf4b51 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -104,3 +104,11 @@
> &pcie0 {
> status = "okay";
> };
> +
> +&rtc {
> + /*
> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> + * working (probably no crystal assembled).
> + */
> + status = "disabled";
> +};
> --
> 2.20.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-31 22:32 [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-08-01 15:30 ` Martin Michlmayr
2019-08-01 20:23 ` Alexandre Belloni
@ 2019-08-27 13:47 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2019-08-27 13:47 UTC (permalink / raw)
To: Uwe Kleine-König, Jason Cooper, Sebastian Hesselbarth
Cc: Andrew Lunn, Alexandre Belloni, tbm, linux-arm-kernel, Oliver Hartkopp
Hi Uwe Kleine-König,
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Applied on mvebu/dt with both acked-by
Thanks,
Gregory
> ---
> Hello,
>
> This patch is (one) result of a discussion on the rtc list. v1 was sent
> there only. This v2 is just a resend to the mvebu maintainers.
>
> Alexandre Belloni said to v1: Seems good to me then.
>
> This sounds a bit like an ack, but I didn't add it as it was not
> explicit.
>
> Best regards
> Uwe
>
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index a88eb22070a1..994cabcf4b51 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -104,3 +104,11 @@
> &pcie0 {
> status = "okay";
> };
> +
> +&rtc {
> + /*
> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> + * working (probably no crystal assembled).
> + */
> + status = "disabled";
> +};
> --
> 2.20.1
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-27 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 22:32 [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-08-01 15:30 ` Martin Michlmayr
2019-08-01 20:23 ` Alexandre Belloni
2019-08-27 13:47 ` Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.