* [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate"
@ 2019-08-05 0:28 Wei Yang
2019-08-05 11:12 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yang @ 2019-08-05 0:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Wei Yang, dgilbert, armbru
With the growth of migration capabilities, it is not proper to display
them in "info migrate". Users are recommended to use "info
migrate_capabiltiies" to list them.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
v2:
* remove capabilities from "info migrate"
---
monitor/hmp-cmds.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 99ceb0846b..05a09987da 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -220,24 +220,13 @@ static char *SocketAddress_to_str(SocketAddress *addr)
void hmp_info_migrate(Monitor *mon, const QDict *qdict)
{
MigrationInfo *info;
- MigrationCapabilityStatusList *caps, *cap;
+ MigrationCapabilityStatusList *caps;
info = qmp_query_migrate(NULL);
caps = qmp_query_migrate_capabilities(NULL);
migration_global_dump(mon);
- /* do not display parameters during setup */
- if (info->has_status && caps) {
- monitor_printf(mon, "capabilities: ");
- for (cap = caps; cap; cap = cap->next) {
- monitor_printf(mon, "%s: %s ",
- MigrationCapability_str(cap->value->capability),
- cap->value->state ? "on" : "off");
- }
- monitor_printf(mon, "\n");
- }
-
if (info->has_status) {
monitor_printf(mon, "Migration status: %s",
MigrationStatus_str(info->status));
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate"
2019-08-05 0:28 [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate" Wei Yang
@ 2019-08-05 11:12 ` Dr. David Alan Gilbert
2019-08-06 0:35 ` Wei Yang
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-08-05 11:12 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, armbru
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> With the growth of migration capabilities, it is not proper to display
> them in "info migrate". Users are recommended to use "info
> migrate_capabiltiies" to list them.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> ---
> v2:
> * remove capabilities from "info migrate"
> ---
> monitor/hmp-cmds.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 99ceb0846b..05a09987da 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -220,24 +220,13 @@ static char *SocketAddress_to_str(SocketAddress *addr)
> void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> {
> MigrationInfo *info;
> - MigrationCapabilityStatusList *caps, *cap;
> + MigrationCapabilityStatusList *caps;
>
> info = qmp_query_migrate(NULL);
> caps = qmp_query_migrate_capabilities(NULL);
Why keep 'caps' and query them? Can't this go as well?
Dave
> migration_global_dump(mon);
>
> - /* do not display parameters during setup */
> - if (info->has_status && caps) {
> - monitor_printf(mon, "capabilities: ");
> - for (cap = caps; cap; cap = cap->next) {
> - monitor_printf(mon, "%s: %s ",
> - MigrationCapability_str(cap->value->capability),
> - cap->value->state ? "on" : "off");
> - }
> - monitor_printf(mon, "\n");
> - }
> -
> if (info->has_status) {
> monitor_printf(mon, "Migration status: %s",
> MigrationStatus_str(info->status));
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate"
2019-08-05 11:12 ` Dr. David Alan Gilbert
@ 2019-08-06 0:35 ` Wei Yang
0 siblings, 0 replies; 3+ messages in thread
From: Wei Yang @ 2019-08-06 0:35 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: armbru, Wei Yang, qemu-devel
On Mon, Aug 05, 2019 at 12:12:25PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> With the growth of migration capabilities, it is not proper to display
>> them in "info migrate". Users are recommended to use "info
>> migrate_capabiltiies" to list them.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>
>> ---
>> v2:
>> * remove capabilities from "info migrate"
>> ---
>> monitor/hmp-cmds.c | 13 +------------
>> 1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
>> index 99ceb0846b..05a09987da 100644
>> --- a/monitor/hmp-cmds.c
>> +++ b/monitor/hmp-cmds.c
>> @@ -220,24 +220,13 @@ static char *SocketAddress_to_str(SocketAddress *addr)
>> void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>> {
>> MigrationInfo *info;
>> - MigrationCapabilityStatusList *caps, *cap;
>> + MigrationCapabilityStatusList *caps;
>>
>> info = qmp_query_migrate(NULL);
>> caps = qmp_query_migrate_capabilities(NULL);
>
>Why keep 'caps' and query them? Can't this go as well?
You are right. Let me remove it.
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-06 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 0:28 [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate" Wei Yang
2019-08-05 11:12 ` Dr. David Alan Gilbert
2019-08-06 0:35 ` Wei Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.