From: Hanna Hawa <hhhawa@amazon.com> To: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <bp@alien8.de>, <mchehab@kernel.org>, <james.morse@arm.com>, <davem@davemloft.net>, <gregkh@linuxfoundation.org>, <linus.walleij@linaro.org>, <Jonathan.Cameron@huawei.com>, <nicolas.ferre@microchip.com>, <paulmck@linux.ibm.com> Cc: <dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>, <hhhawa@amazon.com> Subject: [PATCH v5 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Date: Mon, 5 Aug 2019 15:39:07 +0100 [thread overview] Message-ID: <20190805143911.12185-1-hhhawa@amazon.com> (raw) This series adds L1 and L2 caches support for error detection and correction for Amazon's Annapurna Labs SoCs. Alpine SoCs supports L1 and L2 single bit correction and two bits detection capability based on ARM implementation. Changes since v4: ----------------- - Added include for cpumask.h in al_l2_edac.c - Fix RAMID error print according to ARM TRM - Use for_each_possible_cpu() to parse information for DT. - Add missing of_node_put() call. Changes since v3: ----------------- - Added include for smp.h sysreg.h - Use scnprintf instead of snprintf - Move write_sysreg_s after valid check to minimize the window between read/write. - Use IS_ERR_OR_NULL instead of IS_ERR, because edac_device_alloc_ctl_info may return NULL. Changes since v2: ----------------- - Use BIT for single bit instead of GENMASK - Use BIT_ULL and GENMASK_ULL for 64bit vector - Fix the mod_name/ctrl_name. Changes since v1: ----------------- - Split into two drivers - Get cpu-mask according to l2-cache handler from devicetree - Remove parameter casting - Use GENMASK() in bit mask - Use FIELD_GET() - Update define description PLRU_RAM -> PF_RAM - Use sys_reg() and read_sysreg_s() - Remove all write/read wrappers - Check fatal field to set if the error correctable or not - Remove un-relevant information from error prints. - Update smp_call_function_single() call function to wait - remove usage of get_online_cpus/put_online_cpus - Use on_each_cpu() and smp_call_function_any() instead of loop with for_each_cpu. - use buffer for error prints and pass to edac API - Remove edac_op_state set - Add for loop to report on repeated errors of the same type - Fix error name of the TLB to be L2_TLB as written in ARM TRM - Minor change in Kconfig - Minor changes in commit message Hanna Hawa (4): dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC edac: Add support for Amazon's Annapurna Labs L1 EDAC dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC edac: Add support for Amazon's Annapurna Labs L2 EDAC .../bindings/edac/amazon,al-l1-edac.txt | 14 ++ .../bindings/edac/amazon,al-l2-edac.txt | 20 ++ MAINTAINERS | 12 ++ drivers/edac/Kconfig | 16 ++ drivers/edac/Makefile | 2 + drivers/edac/al_l1_edac.c | 158 ++++++++++++++ drivers/edac/al_l2_edac.c | 192 ++++++++++++++++++ 7 files changed, 414 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-l1-edac.txt create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-l2-edac.txt create mode 100644 drivers/edac/al_l1_edac.c create mode 100644 drivers/edac/al_l2_edac.c -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Hanna Hawa <hhhawa@amazon.com> To: robh+dt@kernel.org, mark.rutland@arm.com, bp@alien8.de, mchehab@kernel.org, james.morse@arm.com, davem@davemloft.net, gregkh@linuxfoundation.org, linus.walleij@linaro.org, Jonathan.Cameron@huawei.com, nicolas.ferre@microchip.com, paulmck@linux.ibm.com Cc: dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, hhhawa@amazon.com Subject: [PATCH v5 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Date: Mon, 5 Aug 2019 15:39:07 +0100 [thread overview] Message-ID: <20190805143911.12185-1-hhhawa@amazon.com> (raw) This series adds L1 and L2 caches support for error detection and correction for Amazon's Annapurna Labs SoCs. Alpine SoCs supports L1 and L2 single bit correction and two bits detection capability based on ARM implementation. Changes since v4: ----------------- - Added include for cpumask.h in al_l2_edac.c - Fix RAMID error print according to ARM TRM - Use for_each_possible_cpu() to parse information for DT. - Add missing of_node_put() call. Changes since v3: ----------------- - Added include for smp.h sysreg.h - Use scnprintf instead of snprintf - Move write_sysreg_s after valid check to minimize the window between read/write. - Use IS_ERR_OR_NULL instead of IS_ERR, because edac_device_alloc_ctl_info may return NULL. Changes since v2: ----------------- - Use BIT for single bit instead of GENMASK - Use BIT_ULL and GENMASK_ULL for 64bit vector - Fix the mod_name/ctrl_name. Changes since v1: ----------------- - Split into two drivers - Get cpu-mask according to l2-cache handler from devicetree - Remove parameter casting - Use GENMASK() in bit mask - Use FIELD_GET() - Update define description PLRU_RAM -> PF_RAM - Use sys_reg() and read_sysreg_s() - Remove all write/read wrappers - Check fatal field to set if the error correctable or not - Remove un-relevant information from error prints. - Update smp_call_function_single() call function to wait - remove usage of get_online_cpus/put_online_cpus - Use on_each_cpu() and smp_call_function_any() instead of loop with for_each_cpu. - use buffer for error prints and pass to edac API - Remove edac_op_state set - Add for loop to report on repeated errors of the same type - Fix error name of the TLB to be L2_TLB as written in ARM TRM - Minor change in Kconfig - Minor changes in commit message Hanna Hawa (4): dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC edac: Add support for Amazon's Annapurna Labs L1 EDAC dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC edac: Add support for Amazon's Annapurna Labs L2 EDAC .../bindings/edac/amazon,al-l1-edac.txt | 14 ++ .../bindings/edac/amazon,al-l2-edac.txt | 20 ++ MAINTAINERS | 12 ++ drivers/edac/Kconfig | 16 ++ drivers/edac/Makefile | 2 + drivers/edac/al_l1_edac.c | 158 ++++++++++++++ drivers/edac/al_l2_edac.c | 192 ++++++++++++++++++ 7 files changed, 414 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-l1-edac.txt create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-l2-edac.txt create mode 100644 drivers/edac/al_l1_edac.c create mode 100644 drivers/edac/al_l2_edac.c -- 2.17.1
next reply other threads:[~2019-08-05 14:39 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-05 14:39 Hanna Hawa [this message] 2019-08-05 14:39 ` [PATCH v5 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa 2019-08-05 14:39 ` [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC Hanna Hawa 2019-08-05 14:39 ` Hanna Hawa 2019-08-21 19:17 ` Rob Herring 2019-08-26 14:49 ` Hawa, Hanna 2019-08-26 14:49 ` Hawa, Hanna 2019-08-27 13:49 ` Rob Herring 2019-08-30 12:45 ` James Morse 2019-08-30 21:50 ` Rob Herring 2019-09-06 16:28 ` James Morse 2019-09-09 15:55 ` Rob Herring 2019-08-05 14:39 ` [PATCH v5 2/4] edac: Add support for " Hanna Hawa 2019-08-05 14:39 ` Hanna Hawa 2019-08-05 14:39 ` [PATCH v5 3/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC Hanna Hawa 2019-08-05 14:39 ` Hanna Hawa 2019-08-05 14:39 ` [PATCH v5 4/4] edac: Add support for " Hanna Hawa 2019-08-05 14:39 ` Hanna Hawa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190805143911.12185-1-hhhawa@amazon.com \ --to=hhhawa@amazon.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=benh@amazon.com \ --cc=bp@alien8.de \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dwmw@amazon.co.uk \ --cc=gregkh@linuxfoundation.org \ --cc=hanochu@amazon.com \ --cc=james.morse@arm.com \ --cc=jonnyc@amazon.com \ --cc=linus.walleij@linaro.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=paulmck@linux.ibm.com \ --cc=robh+dt@kernel.org \ --cc=ronenk@amazon.com \ --cc=talel@amazon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.