All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	jejb@linux.ibm.com, jgg@ziepe.ca,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-kernel@vger.kernel.org, crazyt2019+lml@gmail.com,
	nayna@linux.vnet.ibm.com, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated
Date: Mon, 05 Aug 2019 16:04:52 +0000	[thread overview]
Message-ID: <20190805160451.GB3449@elm> (raw)
In-Reply-To: <1565020459.11223.179.camel@linux.ibm.com>

On 2019-08-05 11:54:19, Mimi Zohar wrote:
> On Mon, 2019-08-05 at 16:50 +0200, Roberto Sassu wrote:
> > Regarding Mimi's proposal to avoid the issue by extending the PCR with
> > zeros, I think it also achieve the goal. 
> 
> Roberto, removing the following code from init_digests() would be the
> equivalent to the prior code, without needing to make any other
> changes.  Let's keep it simple.  Do you want to post the patch with
> the change, or should I?
> 
>         ret = tpm_get_random(chip, digest, TPM_MAX_DIGEST_SIZE);
>         if (ret < 0)
>                 return ret;
>         if (ret < TPM_MAX_DIGEST_SIZE)
>                 return -EFAULT;
> 
> As I can't duplicate the problem, it would need to be tested by others
> experiencing the problem.

The bug reporter tested Roberto's last patch:

 https://bugzilla.kernel.org/show_bug.cgi?id 3953#c8

We should Cc the reporter on future patches or at least leave another
testing request in the bugzilla.

Tyler

> 
> thanks,
> 
> Mimi
> 

WARNING: multiple messages have this Message-ID (diff)
From: Tyler Hicks <tyhicks@canonical.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	jejb@linux.ibm.com, jgg@ziepe.ca,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-kernel@vger.kernel.org, crazyt2019+lml@gmail.com,
	nayna@linux.vnet.ibm.com, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated
Date: Mon, 5 Aug 2019 11:04:52 -0500	[thread overview]
Message-ID: <20190805160451.GB3449@elm> (raw)
In-Reply-To: <1565020459.11223.179.camel@linux.ibm.com>

On 2019-08-05 11:54:19, Mimi Zohar wrote:
> On Mon, 2019-08-05 at 16:50 +0200, Roberto Sassu wrote:
> > Regarding Mimi's proposal to avoid the issue by extending the PCR with
> > zeros, I think it also achieve the goal. 
> 
> Roberto, removing the following code from init_digests() would be the
> equivalent to the prior code, without needing to make any other
> changes.  Let's keep it simple.  Do you want to post the patch with
> the change, or should I?
> 
>         ret = tpm_get_random(chip, digest, TPM_MAX_DIGEST_SIZE);
>         if (ret < 0)
>                 return ret;
>         if (ret < TPM_MAX_DIGEST_SIZE)
>                 return -EFAULT;
> 
> As I can't duplicate the problem, it would need to be tested by others
> experiencing the problem.

The bug reporter tested Roberto's last patch:

 https://bugzilla.kernel.org/show_bug.cgi?id=203953#c8

We should Cc the reporter on future patches or at least leave another
testing request in the bugzilla.

Tyler

> 
> thanks,
> 
> Mimi
> 

  parent reply	other threads:[~2019-08-05 16:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 16:37 [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated Roberto Sassu
2019-07-05 16:37 ` Roberto Sassu
2019-07-08 19:55 ` Tyler Hicks
2019-07-08 19:55   ` Tyler Hicks
2019-07-08 20:34 ` James Bottomley
2019-07-08 20:34   ` James Bottomley
2019-07-09 16:24   ` Jarkko Sakkinen
2019-07-09 16:24     ` Jarkko Sakkinen
2019-07-09 16:31     ` Mimi Zohar
2019-07-09 16:31       ` Mimi Zohar
2019-08-02 21:18       ` Tyler Hicks
2019-08-02 21:18         ` Tyler Hicks
2019-07-11 19:48 ` Jarkko Sakkinen
2019-07-11 19:48   ` Jarkko Sakkinen
2019-07-15 16:44   ` Roberto Sassu
2019-07-15 16:44     ` Roberto Sassu
2019-08-01 16:32     ` Jarkko Sakkinen
2019-08-01 16:32       ` Jarkko Sakkinen
2019-08-02  8:21       ` Roberto Sassu
2019-08-02  8:21         ` Roberto Sassu
2019-08-02 14:27         ` Tyler Hicks
2019-08-02 14:27           ` Tyler Hicks
2019-08-02 19:42           ` Jarkko Sakkinen
2019-08-02 19:42             ` Jarkko Sakkinen
2019-08-02 20:23             ` Tyler Hicks
2019-08-02 20:23               ` Tyler Hicks
2019-08-02 20:35               ` Tyler Hicks
2019-08-02 20:35                 ` Tyler Hicks
2019-08-03 14:44               ` Jarkko Sakkinen
2019-08-03 14:44                 ` Jarkko Sakkinen
2019-08-04  1:46                 ` Mimi Zohar
2019-08-04  1:46                   ` Mimi Zohar
2019-08-05 14:50               ` Roberto Sassu
2019-08-05 14:50                 ` Roberto Sassu
2019-08-05 15:54                 ` Mimi Zohar
2019-08-05 15:54                   ` Mimi Zohar
2019-08-05 16:04                   ` Roberto Sassu
2019-08-05 16:04                     ` Roberto Sassu
2019-08-05 16:04                   ` Tyler Hicks [this message]
2019-08-05 16:04                     ` Tyler Hicks
2019-08-05 16:51                     ` Roberto Sassu
2019-08-05 16:51                       ` Roberto Sassu
2019-08-05 16:53                       ` Tyler Hicks
2019-08-05 16:53                         ` Tyler Hicks
2019-08-05 22:11                 ` Jarkko Sakkinen
2019-08-05 22:11                   ` Jarkko Sakkinen
2019-08-02 19:40         ` Jarkko Sakkinen
2019-08-02 19:40           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805160451.GB3449@elm \
    --to=tyhicks@canonical.com \
    --cc=crazyt2019+lml@gmail.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=jgg@ziepe.ca \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=roberto.sassu@huawei.com \
    --cc=silviu.vlasceanu@huawei.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.