From: Nathan Chancellor <natechancellor@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: andrew@lunn.ch, broonie@kernel.org, devel@driverdev.osuosl.org,
f.fainelli@gmail.com, gregkh@linuxfoundation.org,
hkallweit1@gmail.com, kernel-build-reports@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org,
lkp@intel.com, netdev@vger.kernel.org, rdunlap@infradead.org,
willy@infradead.org
Subject: Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors
Date: Tue, 6 Aug 2019 22:10:40 -0700 [thread overview]
Message-ID: <20190807051040.GA117554@archlinux-threadripper> (raw)
In-Reply-To: <20190806.141133.1365654857955536268.davem@davemloft.net>
On Tue, Aug 06, 2019 at 02:11:33PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Fri, 2 Aug 2019 23:01:56 -0700
>
> > After commit 171a9bae68c7 ("staging/octeon: Allow test build on
> > !MIPS"), the following combination of configs cause a few Kconfig
> > warnings and build errors (distilled from arm allyesconfig and Randy's
> > randconfig builds):
> >
> > CONFIG_NETDEVICES=y
> > CONFIG_STAGING=y
> > CONFIG_COMPILE_TEST=y
> >
> > and CONFIG_OCTEON_ETHERNET as either a module or built-in.
> >
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n]
> > Selected by [y]:
> > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC ||
> > COMPILE_TEST [=y]) && NETDEVICES [=y]
> >
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function ‘writeq’; did you mean ‘writel’?
> > [-Werror=implicit-function-declaration]
> > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
> > | ^~~~~~
> >
> > CONFIG_64BIT is not strictly necessary if the proper readq/writeq
> > definitions are included from io-64-nonatomic-lo-hi.h.
> >
> > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because
> > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h.").
> >
> > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Applied to net-next.
>
> Please make it clear what tree your changes are targetting in the future,
> thank you.
Sorry for the confusion, I'll do my best to add a patch suffix in the
future.
Thank you for picking this up!
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: natechancellor@gmail.com (Nathan Chancellor)
Subject: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors
Date: Tue, 6 Aug 2019 22:10:40 -0700 [thread overview]
Message-ID: <20190807051040.GA117554@archlinux-threadripper> (raw)
In-Reply-To: <20190806.141133.1365654857955536268.davem@davemloft.net>
On Tue, Aug 06, 2019@02:11:33PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor at gmail.com>
> Date: Fri, 2 Aug 2019 23:01:56 -0700
>
> > After commit 171a9bae68c7 ("staging/octeon: Allow test build on
> > !MIPS"), the following combination of configs cause a few Kconfig
> > warnings and build errors (distilled from arm allyesconfig and Randy's
> > randconfig builds):
> >
> > CONFIG_NETDEVICES=y
> > CONFIG_STAGING=y
> > CONFIG_COMPILE_TEST=y
> >
> > and CONFIG_OCTEON_ETHERNET as either a module or built-in.
> >
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n]
> > Selected by [y]:
> > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC ||
> > COMPILE_TEST [=y]) && NETDEVICES [=y]
> >
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function ?writeq?; did you mean ?writel??
> > [-Werror=implicit-function-declaration]
> > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
> > | ^~~~~~
> >
> > CONFIG_64BIT is not strictly necessary if the proper readq/writeq
> > definitions are included from io-64-nonatomic-lo-hi.h.
> >
> > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because
> > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h.").
> >
> > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
> > Reported-by: kbuild test robot <lkp at intel.com>
> > Reported-by: Mark Brown <broonie at kernel.org>
> > Reported-by: Randy Dunlap <rdunlap at infradead.org>
> > Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>
>
> Applied to net-next.
>
> Please make it clear what tree your changes are targetting in the future,
> thank you.
Sorry for the confusion, I'll do my best to add a patch suffix in the
future.
Thank you for picking this up!
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, f.fainelli@gmail.com,
lkp@intel.com, kernel-build-reports@lists.linaro.org,
gregkh@linuxfoundation.org, rdunlap@infradead.org,
willy@infradead.org, broonie@kernel.org,
linux-next@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors
Date: Tue, 6 Aug 2019 22:10:40 -0700 [thread overview]
Message-ID: <20190807051040.GA117554@archlinux-threadripper> (raw)
In-Reply-To: <20190806.141133.1365654857955536268.davem@davemloft.net>
On Tue, Aug 06, 2019 at 02:11:33PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Fri, 2 Aug 2019 23:01:56 -0700
>
> > After commit 171a9bae68c7 ("staging/octeon: Allow test build on
> > !MIPS"), the following combination of configs cause a few Kconfig
> > warnings and build errors (distilled from arm allyesconfig and Randy's
> > randconfig builds):
> >
> > CONFIG_NETDEVICES=y
> > CONFIG_STAGING=y
> > CONFIG_COMPILE_TEST=y
> >
> > and CONFIG_OCTEON_ETHERNET as either a module or built-in.
> >
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n]
> > Selected by [y]:
> > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC ||
> > COMPILE_TEST [=y]) && NETDEVICES [=y]
> >
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function ‘writeq’; did you mean ‘writel’?
> > [-Werror=implicit-function-declaration]
> > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
> > | ^~~~~~
> >
> > CONFIG_64BIT is not strictly necessary if the proper readq/writeq
> > definitions are included from io-64-nonatomic-lo-hi.h.
> >
> > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because
> > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h.").
> >
> > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Applied to net-next.
>
> Please make it clear what tree your changes are targetting in the future,
> thank you.
Sorry for the confusion, I'll do my best to add a patch suffix in the
future.
Thank you for picking this up!
Nathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-07 5:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5d41767d.1c69fb81.d6304.4c8c@mx.google.com>
2019-07-31 11:24 ` next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) Mark Brown
2019-07-31 11:24 ` Mark Brown
2019-07-31 11:24 ` Mark Brown
2019-07-31 11:35 ` Greg Kroah-Hartman
2019-07-31 11:35 ` Greg Kroah-Hartman
2019-07-31 15:48 ` David Miller
2019-07-31 15:48 ` David Miller
2019-07-31 16:00 ` Greg KH
2019-07-31 16:00 ` Greg KH
2019-07-31 16:35 ` Nathan Chancellor
2019-07-31 16:35 ` Nathan Chancellor
2019-07-31 16:41 ` David Miller
2019-07-31 16:41 ` David Miller
2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor
2019-07-31 18:50 ` Nathan Chancellor
2019-07-31 21:55 ` Randy Dunlap
2019-07-31 23:52 ` Randy Dunlap
2019-07-31 23:52 ` Randy Dunlap
2019-09-19 9:06 ` Geert Uytterhoeven
2019-09-19 9:06 ` Geert Uytterhoeven
2019-09-19 9:06 ` Geert Uytterhoeven
2019-08-03 1:11 ` David Miller
2019-08-03 1:11 ` David Miller
2019-08-03 1:11 ` David Miller
2019-08-03 1:30 ` Nathan Chancellor
2019-08-03 1:30 ` Nathan Chancellor
2019-08-03 1:30 ` Nathan Chancellor
2019-08-03 1:39 ` Matthew Wilcox
2019-08-03 1:39 ` Matthew Wilcox
2019-08-03 1:39 ` Matthew Wilcox
2019-08-03 6:05 ` Nathan Chancellor
2019-08-03 6:05 ` Nathan Chancellor
2019-08-03 6:05 ` Nathan Chancellor
2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor
2019-08-03 6:01 ` Nathan Chancellor
2019-08-03 6:01 ` Nathan Chancellor
2019-08-03 18:34 ` Randy Dunlap
2019-08-03 18:34 ` Randy Dunlap
2019-08-03 18:34 ` Randy Dunlap
2019-08-06 21:11 ` David Miller
2019-08-06 21:11 ` David Miller
2019-08-06 21:11 ` David Miller
2019-08-07 5:10 ` Nathan Chancellor [this message]
2019-08-07 5:10 ` Nathan Chancellor
2019-08-07 5:10 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807051040.GA117554@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.