From: Miquel Raynal <miquel.raynal@bootlin.com> To: shiva.linuxworks@gmail.com Cc: Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Vignesh Raghavendra <vigneshr@ti.com>, Boris Brezillon <bbrezillon@kernel.org>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, Frieder Schrempf <frieder.schrempf@kontron.de>, Shivamurthy Shastri <sshivamurthy@micron.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Kletsky <git-commits@allycomm.com>, Chuanhong Guo <gch981213@gmail.com>, liaoweixiong <liaoweixiong@allwinnertech.com> Subject: Re: [PATCH 1/8] mtd: nand: move ONFI related functions to onfi.h Date: Wed, 7 Aug 2019 10:34:37 +0200 [thread overview] Message-ID: <20190807103437.36abb59b@xps13> (raw) In-Reply-To: <20190722055621.23526-2-sshivamurthy@micron.com> Hi Shiva, shiva.linuxworks@gmail.com wrote on Mon, 22 Jul 2019 07:56:14 +0200: > From: Shivamurthy Shastri <sshivamurthy@micron.com> > > These functions will be used by both raw NAND and SPI NAND, which > supports ONFI like standards. This is not exactly what you do. Why not: mtd: nand: export ONFI related functions to onfi.h These functions can be used by all flavors of NAND chips (raw, SPI) which may all follow ONFI standards. Export the related functions in the onfi.h generic file. > > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com> > --- > drivers/mtd/nand/raw/internals.h | 1 - > include/linux/mtd/onfi.h | 9 +++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h > index cba6fe7dd8c4..ed323087d884 100644 > --- a/drivers/mtd/nand/raw/internals.h > +++ b/drivers/mtd/nand/raw/internals.h > @@ -140,7 +140,6 @@ void nand_legacy_adjust_cmdfunc(struct nand_chip *chip); > int nand_legacy_check_hooks(struct nand_chip *chip); > > /* ONFI functions */ > -u16 onfi_crc16(u16 crc, u8 const *p, size_t len); > int nand_onfi_detect(struct nand_chip *chip); > > /* JEDEC functions */ > diff --git a/include/linux/mtd/onfi.h b/include/linux/mtd/onfi.h > index 339ac798568e..2c8a05a02bb0 100644 > --- a/include/linux/mtd/onfi.h > +++ b/include/linux/mtd/onfi.h > @@ -10,6 +10,7 @@ > #ifndef __LINUX_MTD_ONFI_H > #define __LINUX_MTD_ONFI_H > > +#include <linux/mtd/nand.h> This should be removed, or at least not added at this moment. > #include <linux/types.h> > > /* ONFI version bits */ > @@ -175,4 +176,12 @@ struct onfi_params { > u8 vendor[88]; > }; > > +/* ONFI functions */ > +u16 onfi_crc16(u16 crc, u8 const *p, size_t len); > +void nand_bit_wise_majority(const void **srcbufs, > + unsigned int nsrcbufs, > + void *dstbuf, > + unsigned int bufsize); Don't export this function while you don't use it from elsewhere. > +void sanitize_string(u8 *s, size_t len); This one is used by jedec code and has no onfi-related logic, so you may want to export it (only when you will use it) in another header like linux/mtd/nand.h > + > #endif /* __LINUX_MTD_ONFI_H */ Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: shiva.linuxworks@gmail.com Cc: Chuanhong Guo <gch981213@gmail.com>, Vignesh Raghavendra <vigneshr@ti.com>, Boris Brezillon <bbrezillon@kernel.org>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org, Frieder Schrempf <frieder.schrempf@kontron.de>, liaoweixiong <liaoweixiong@allwinnertech.com>, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, Jeff Kletsky <git-commits@allycomm.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Shivamurthy Shastri <sshivamurthy@micron.com> Subject: Re: [PATCH 1/8] mtd: nand: move ONFI related functions to onfi.h Date: Wed, 7 Aug 2019 10:34:37 +0200 [thread overview] Message-ID: <20190807103437.36abb59b@xps13> (raw) In-Reply-To: <20190722055621.23526-2-sshivamurthy@micron.com> Hi Shiva, shiva.linuxworks@gmail.com wrote on Mon, 22 Jul 2019 07:56:14 +0200: > From: Shivamurthy Shastri <sshivamurthy@micron.com> > > These functions will be used by both raw NAND and SPI NAND, which > supports ONFI like standards. This is not exactly what you do. Why not: mtd: nand: export ONFI related functions to onfi.h These functions can be used by all flavors of NAND chips (raw, SPI) which may all follow ONFI standards. Export the related functions in the onfi.h generic file. > > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com> > --- > drivers/mtd/nand/raw/internals.h | 1 - > include/linux/mtd/onfi.h | 9 +++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h > index cba6fe7dd8c4..ed323087d884 100644 > --- a/drivers/mtd/nand/raw/internals.h > +++ b/drivers/mtd/nand/raw/internals.h > @@ -140,7 +140,6 @@ void nand_legacy_adjust_cmdfunc(struct nand_chip *chip); > int nand_legacy_check_hooks(struct nand_chip *chip); > > /* ONFI functions */ > -u16 onfi_crc16(u16 crc, u8 const *p, size_t len); > int nand_onfi_detect(struct nand_chip *chip); > > /* JEDEC functions */ > diff --git a/include/linux/mtd/onfi.h b/include/linux/mtd/onfi.h > index 339ac798568e..2c8a05a02bb0 100644 > --- a/include/linux/mtd/onfi.h > +++ b/include/linux/mtd/onfi.h > @@ -10,6 +10,7 @@ > #ifndef __LINUX_MTD_ONFI_H > #define __LINUX_MTD_ONFI_H > > +#include <linux/mtd/nand.h> This should be removed, or at least not added at this moment. > #include <linux/types.h> > > /* ONFI version bits */ > @@ -175,4 +176,12 @@ struct onfi_params { > u8 vendor[88]; > }; > > +/* ONFI functions */ > +u16 onfi_crc16(u16 crc, u8 const *p, size_t len); > +void nand_bit_wise_majority(const void **srcbufs, > + unsigned int nsrcbufs, > + void *dstbuf, > + unsigned int bufsize); Don't export this function while you don't use it from elsewhere. > +void sanitize_string(u8 *s, size_t len); This one is used by jedec code and has no onfi-related logic, so you may want to export it (only when you will use it) in another header like linux/mtd/nand.h > + > #endif /* __LINUX_MTD_ONFI_H */ Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-07 8:34 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 5:56 [PATCH 0/8] Introduce generic ONFI support shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-07-22 5:56 ` [PATCH 1/8] mtd: nand: move ONFI related functions to onfi.h shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 8:34 ` Miquel Raynal [this message] 2019-08-07 8:34 ` Miquel Raynal 2019-08-19 8:35 ` [EXT] " Shivamurthy Shastri (sshivamurthy) 2019-08-19 8:35 ` Shivamurthy Shastri (sshivamurthy) 2019-07-22 5:56 ` [PATCH 2/8] mtd: nand: move support functions for ONFI to nand/onfi.c shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 9:03 ` Miquel Raynal 2019-08-07 9:03 ` Miquel Raynal 2019-08-19 8:36 ` [EXT] " Shivamurthy Shastri (sshivamurthy) 2019-08-19 8:36 ` Shivamurthy Shastri (sshivamurthy) 2019-07-22 5:56 ` [PATCH 3/8] mtd: nand: create ONFI table parsing instance shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 9:09 ` Miquel Raynal 2019-08-07 9:09 ` Miquel Raynal 2019-07-22 5:56 ` [PATCH 4/8] mtd: spinand: enabled parameter page support shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 9:48 ` Miquel Raynal 2019-08-07 9:48 ` Miquel Raynal 2019-08-19 8:51 ` [EXT] " Shivamurthy Shastri (sshivamurthy) 2019-08-19 8:51 ` Shivamurthy Shastri (sshivamurthy) 2019-08-19 9:21 ` Miquel Raynal 2019-08-19 9:21 ` Miquel Raynal 2019-09-30 13:23 ` Shivamurthy Shastri (sshivamurthy) 2019-09-30 13:23 ` Shivamurthy Shastri (sshivamurthy) 2019-10-07 7:52 ` Boris Brezillon 2019-10-07 7:52 ` Boris Brezillon 2019-07-22 5:56 ` [PATCH 5/8] mtd: spinand: micron: prepare for generalizing driver shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 9:51 ` Miquel Raynal 2019-08-07 9:51 ` Miquel Raynal 2019-07-22 5:56 ` [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 10:04 ` Miquel Raynal 2019-08-07 10:04 ` Miquel Raynal 2019-08-19 9:03 ` [EXT] " Shivamurthy Shastri (sshivamurthy) 2019-08-19 9:03 ` Shivamurthy Shastri (sshivamurthy) 2019-08-19 9:19 ` Miquel Raynal 2019-08-19 9:19 ` Miquel Raynal 2019-09-16 10:41 ` Shivamurthy Shastri (sshivamurthy) 2019-09-16 10:41 ` Shivamurthy Shastri (sshivamurthy) 2019-10-07 8:13 ` Boris Brezillon 2019-10-07 8:13 ` Boris Brezillon 2019-10-14 12:49 ` Shivamurthy Shastri (sshivamurthy) 2019-10-14 12:49 ` Shivamurthy Shastri (sshivamurthy) 2019-07-22 5:56 ` [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 10:05 ` Miquel Raynal 2019-08-07 10:05 ` Miquel Raynal 2019-07-22 5:56 ` [PATCH 8/8] mtd: spinand: micron: Enable micron flashes with multi-die shiva.linuxworks 2019-07-22 5:56 ` shiva.linuxworks 2019-08-07 10:08 ` Miquel Raynal 2019-08-07 10:08 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190807103437.36abb59b@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=bbrezillon@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=frieder.schrempf@kontron.de \ --cc=gch981213@gmail.com \ --cc=git-commits@allycomm.com \ --cc=liaoweixiong@allwinnertech.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marcel.ziswiler@toradex.com \ --cc=marek.vasut@gmail.com \ --cc=richard@nod.at \ --cc=shiva.linuxworks@gmail.com \ --cc=sshivamurthy@micron.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.