* [PATCH] arm64/ptrace: Fix typoes in sve_set() comment
@ 2019-08-07 10:34 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2019-08-07 10:34 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: will, catalin.marinas, oleg, Dave.Martin, Julien Grall
The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
comment accordingly.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
arch/arm64/kernel/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 17525da8d5c8..0de3eae09d36 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
goto out;
/*
- * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
+ * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
* sve_set_vector_length(), which will also validate them for us:
*/
ret = sve_set_vector_length(target, header.vl,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64/ptrace: Fix typoes in sve_set() comment
@ 2019-08-07 10:34 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2019-08-07 10:34 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: catalin.marinas, Julien Grall, will, oleg, Dave.Martin
The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
comment accordingly.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
arch/arm64/kernel/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 17525da8d5c8..0de3eae09d36 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
goto out;
/*
- * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
+ * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
* sve_set_vector_length(), which will also validate them for us:
*/
ret = sve_set_vector_length(target, header.vl,
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64/ptrace: Fix typoes in sve_set() comment
2019-08-07 10:34 ` Julien Grall
@ 2019-08-07 10:38 ` Dave Martin
-1 siblings, 0 replies; 4+ messages in thread
From: Dave Martin @ 2019-08-07 10:38 UTC (permalink / raw)
To: Julien Grall; +Cc: linux-arm-kernel, linux-kernel, catalin.marinas, will, oleg
On Wed, Aug 07, 2019 at 11:34:45AM +0100, Julien Grall wrote:
> The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
> comment accordingly.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> ---
> arch/arm64/kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
> index 17525da8d5c8..0de3eae09d36 100644
> --- a/arch/arm64/kernel/ptrace.c
> +++ b/arch/arm64/kernel/ptrace.c
> @@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
> goto out;
>
> /*
> - * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
> + * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
> * sve_set_vector_length(), which will also validate them for us:
> */
Thanks for spotting that.
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
Cheers
---Dave
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64/ptrace: Fix typoes in sve_set() comment
@ 2019-08-07 10:38 ` Dave Martin
0 siblings, 0 replies; 4+ messages in thread
From: Dave Martin @ 2019-08-07 10:38 UTC (permalink / raw)
To: Julien Grall; +Cc: catalin.marinas, will, linux-kernel, linux-arm-kernel, oleg
On Wed, Aug 07, 2019 at 11:34:45AM +0100, Julien Grall wrote:
> The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
> comment accordingly.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> ---
> arch/arm64/kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
> index 17525da8d5c8..0de3eae09d36 100644
> --- a/arch/arm64/kernel/ptrace.c
> +++ b/arch/arm64/kernel/ptrace.c
> @@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
> goto out;
>
> /*
> - * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
> + * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
> * sve_set_vector_length(), which will also validate them for us:
> */
Thanks for spotting that.
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
Cheers
---Dave
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-07 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 10:34 [PATCH] arm64/ptrace: Fix typoes in sve_set() comment Julien Grall
2019-08-07 10:34 ` Julien Grall
2019-08-07 10:38 ` Dave Martin
2019-08-07 10:38 ` Dave Martin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.