[PATCH] clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()

[PATCH] clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()

[Nishka Dasgupta]

In function st_of_flexgen_setup, variable pnode takes the return value
of of_get_parent, which gets a node but does not put it. If pnode is not
put before the function returns, it may cause a memory leak. Hence put
pnode after its last occurrence.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/clk/st/clk-flexgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
index d18e49b4976f..4413b6e04a8e 100644
--- a/drivers/clk/st/clk-flexgen.c
+++ b/drivers/clk/st/clk-flexgen.c
@@ -326,6 +326,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)
 		return;
 
 	reg = of_iomap(pnode, 0);
+	of_node_put(pnode);
 	if (!reg)
 		return;
 
-- 
2.19.1

Re: [PATCH] clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()

[Stephen Boyd]

Quoting Nishka Dasgupta (2019-08-04 09:31:51)
> In function st_of_flexgen_setup, variable pnode takes the return value
> of of_get_parent, which gets a node but does not put it. If pnode is not
> put before the function returns, it may cause a memory leak. Hence put
> pnode after its last occurrence.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---

Applied to clk-next