* [rcu:dev.2019.07.31a 110/123] kernel/rcu/rcu_segcblist.c:61:6: sparse: sparse: symbol 'rcu_segcblist_set_len' was not declared. Should it be static?
@ 2019-08-08 2:32 kbuild test robot
2019-08-08 2:32 ` [RFC PATCH rcu] rcu/nocb: rcu_segcblist_set_len() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-08-08 2:32 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2019.07.31a
head: 71cf692f482ff45802352cf85a8880035fca9e52
commit: ab2ef5c7b4d1933ee53a66d981cb67974de46815 [110/123] rcu/nocb: Atomic ->len field in rcu_segcblist structure
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
git checkout ab2ef5c7b4d1933ee53a66d981cb67974de46815
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/rcu/rcu_segcblist.c:32:6: sparse: sparse: symbol 'rcu_cblist_enqueue' was not declared. Should it be static?
>> kernel/rcu/rcu_segcblist.c:61:6: sparse: sparse: symbol 'rcu_segcblist_set_len' was not declared. Should it be static?
>> kernel/rcu/rcu_segcblist.c:77:6: sparse: sparse: symbol 'rcu_segcblist_add_len' was not declared. Should it be static?
kernel/rcu/rcu_segcblist.c:96:6: sparse: sparse: symbol 'rcu_segcblist_inc_len' was not declared. Should it be static?
>> kernel/rcu/rcu_segcblist.c:107:6: sparse: sparse: symbol 'rcu_segcblist_xchg_len' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH rcu] rcu/nocb: rcu_segcblist_set_len() can be static
2019-08-08 2:32 [rcu:dev.2019.07.31a 110/123] kernel/rcu/rcu_segcblist.c:61:6: sparse: sparse: symbol 'rcu_segcblist_set_len' was not declared. Should it be static? kbuild test robot
@ 2019-08-08 2:32 ` kbuild test robot
2019-08-08 16:18 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-08-08 2:32 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel
Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
rcu_segcblist.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
index ff431cc830378..84bbffaaede83 100644
--- a/kernel/rcu/rcu_segcblist.c
+++ b/kernel/rcu/rcu_segcblist.c
@@ -58,7 +58,7 @@ struct rcu_head *rcu_cblist_dequeue(struct rcu_cblist *rclp)
}
/* Set the length of an rcu_segcblist structure. */
-void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
+static void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
{
#ifdef CONFIG_RCU_NOCB_CPU
atomic_long_set(&rsclp->len, v);
@@ -74,7 +74,7 @@ void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
* This increase is fully ordered with respect to the callers accesses
* both before and after.
*/
-void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v)
+static void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v)
{
#ifdef CONFIG_RCU_NOCB_CPU
smp_mb__before_atomic(); /* Up to the caller! */
@@ -104,7 +104,7 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp)
* with the actual number of callbacks on the structure. This exchange is
* fully ordered with respect to the callers accesses both before and after.
*/
-long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v)
+static long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v)
{
#ifdef CONFIG_RCU_NOCB_CPU
return atomic_long_xchg(&rsclp->len, v);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH rcu] rcu/nocb: rcu_segcblist_set_len() can be static
2019-08-08 2:32 ` [RFC PATCH rcu] rcu/nocb: rcu_segcblist_set_len() can be static kbuild test robot
@ 2019-08-08 16:18 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2019-08-08 16:18 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, linux-kernel
On Thu, Aug 08, 2019 at 10:32:58AM +0800, kbuild test robot wrote:
>
> Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
> Signed-off-by: kbuild test robot <lkp@intel.com>
Good catch! Queued with updated commit log, thank you!
Thanx, Paul
> ---
> rcu_segcblist.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> index ff431cc830378..84bbffaaede83 100644
> --- a/kernel/rcu/rcu_segcblist.c
> +++ b/kernel/rcu/rcu_segcblist.c
> @@ -58,7 +58,7 @@ struct rcu_head *rcu_cblist_dequeue(struct rcu_cblist *rclp)
> }
>
> /* Set the length of an rcu_segcblist structure. */
> -void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
> +static void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
> {
> #ifdef CONFIG_RCU_NOCB_CPU
> atomic_long_set(&rsclp->len, v);
> @@ -74,7 +74,7 @@ void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)
> * This increase is fully ordered with respect to the callers accesses
> * both before and after.
> */
> -void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v)
> +static void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v)
> {
> #ifdef CONFIG_RCU_NOCB_CPU
> smp_mb__before_atomic(); /* Up to the caller! */
> @@ -104,7 +104,7 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp)
> * with the actual number of callbacks on the structure. This exchange is
> * fully ordered with respect to the callers accesses both before and after.
> */
> -long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v)
> +static long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v)
> {
> #ifdef CONFIG_RCU_NOCB_CPU
> return atomic_long_xchg(&rsclp->len, v);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-08 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 2:32 [rcu:dev.2019.07.31a 110/123] kernel/rcu/rcu_segcblist.c:61:6: sparse: sparse: symbol 'rcu_segcblist_set_len' was not declared. Should it be static? kbuild test robot
2019-08-08 2:32 ` [RFC PATCH rcu] rcu/nocb: rcu_segcblist_set_len() can be static kbuild test robot
2019-08-08 16:18 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.