[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Sam Protsenko]

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 test/py/tests/{ => test_android}/test_avb.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename test/py/tests/{ => test_android}/test_avb.py (100%)

diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
similarity index 100%
rename from test/py/tests/test_avb.py
rename to test/py/tests/test_android/test_avb.py
-- 
2.20.1

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Simon Glass]

Hi,

On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  test/py/tests/{ => test_android}/test_avb.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename test/py/tests/{ => test_android}/test_avb.py (100%)
>
> diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> similarity index 100%
> rename from test/py/tests/test_avb.py
> rename to test/py/tests/test_android/test_avb.py
> --

I'd prefer to keep tsts in one place. What is the goal of this patch?

Regards,
Simon


> 2.20.1
>

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Sam Protsenko]

Hi Simon,

On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
>
> Hi,
>
> On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
> >  test/py/tests/{ => test_android}/test_avb.py | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> >
> > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > similarity index 100%
> > rename from test/py/tests/test_avb.py
> > rename to test/py/tests/test_android/test_avb.py
> > --
>
> I'd prefer to keep tsts in one place. What is the goal of this patch?
>

It was me who asked Igor to make that change. I thought it would be
convenient to keep all Android related tests in one place (for now
it's AVB and A/B tests), so that:
  1. We can tell which ones are Android related
  2. We can run all Android tests with one command

As I understand, it doesn't break anything. I got the idea from
test_fs/ I guess. If you oppose this change, we can just drop it.

Thanks!

> Regards,
> Simon
>
>
> > 2.20.1
> >

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Sam Protsenko]

On Sat, Jul 6, 2019 at 11:32 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> Hi Simon,
>
> On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> > >
> > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > > ---
> > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > >
> > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > similarity index 100%
> > > rename from test/py/tests/test_avb.py
> > > rename to test/py/tests/test_android/test_avb.py
> > > --
> >
> > I'd prefer to keep tsts in one place. What is the goal of this patch?
> >
>
> It was me who asked Igor to make that change. I thought it would be
> convenient to keep all Android related tests in one place (for now
> it's AVB and A/B tests), so that:
>   1. We can tell which ones are Android related
>   2. We can run all Android tests with one command
>
> As I understand, it doesn't break anything. I got the idea from
> test_fs/ I guess. If you oppose this change, we can just drop it.
>

Sorry, I confused this one with Igor Opaniuk patch from A/B patch
series, where he adds the test for A/B, in test_android/ directory. I
thought it was good idea to keep everything Android-related in
separate namespace. If you want to keep all patches in one place, we
can do that, but Igor will need to re-send his A/B patch series once
again.

> Thanks!
>
> > Regards,
> > Simon
> >
> >
> > > 2.20.1
> > >

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Sam Protsenko]

Hi Simon,

On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
>
> Hi,
>
> On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
> >  test/py/tests/{ => test_android}/test_avb.py | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> >
> > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > similarity index 100%
> > rename from test/py/tests/test_avb.py
> > rename to test/py/tests/test_android/test_avb.py
> > --
>
> I'd prefer to keep tsts in one place. What is the goal of this patch?
>

Similar patch was merged recently (adding test_android/ dir):

    https://patchwork.ozlabs.org/patch/1128013/

So we need either:
  1. move that test out of test_android/ dir, and drop this one
  2. or apply this patch

What would you prefer? (I've explained my perspective on that matter
earlier in this thread). We should do either (1) or (2) to keep the
consistency.

Thanks.

> Regards,
> Simon
>
>
> > 2.20.1
> >

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Tom Rini]

On Thu, Jul 25, 2019 at 04:33:21PM +0300, Sam Protsenko wrote:
> Hi Simon,
> 
> On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> > >
> > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > > ---
> > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > >
> > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > similarity index 100%
> > > rename from test/py/tests/test_avb.py
> > > rename to test/py/tests/test_android/test_avb.py
> > > --
> >
> > I'd prefer to keep tsts in one place. What is the goal of this patch?
> >
> 
> Similar patch was merged recently (adding test_android/ dir):
> 
>     https://patchwork.ozlabs.org/patch/1128013/
> 
> So we need either:
>   1. move that test out of test_android/ dir, and drop this one
>   2. or apply this patch
> 
> What would you prefer? (I've explained my perspective on that matter
> earlier in this thread). We should do either (1) or (2) to keep the
> consistency.

Note that we've also had vboot as a sub-directory since it was
introduced and test_fs is also a sub-directory.  My two cents is that
sub-directories help with organization as the number of tests increase.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190725/8cc59ef6/attachment.sig>

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Sam Protsenko]

Hi Tom,

On Thu, Jul 25, 2019 at 6:13 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jul 25, 2019 at 04:33:21PM +0300, Sam Protsenko wrote:
> > Hi Simon,
> >
> > On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi,
> > >
> > > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> > > >
> > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > > > ---
> > > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > > >
> > > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > > similarity index 100%
> > > > rename from test/py/tests/test_avb.py
> > > > rename to test/py/tests/test_android/test_avb.py
> > > > --
> > >
> > > I'd prefer to keep tsts in one place. What is the goal of this patch?
> > >
> >
> > Similar patch was merged recently (adding test_android/ dir):
> >
> >     https://patchwork.ozlabs.org/patch/1128013/
> >
> > So we need either:
> >   1. move that test out of test_android/ dir, and drop this one
> >   2. or apply this patch
> >
> > What would you prefer? (I've explained my perspective on that matter
> > earlier in this thread). We should do either (1) or (2) to keep the
> > consistency.
>
> Note that we've also had vboot as a sub-directory since it was
> introduced and test_fs is also a sub-directory.  My two cents is that
> sub-directories help with organization as the number of tests increase.
>

If there are no further concerns, can you please apply it for -rc2, so
it doesn't get lost in ML?

Thanks!

> --
> Tom

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Tom Rini]

On Wed, Aug 07, 2019 at 03:12:51PM +0300, Sam Protsenko wrote:
> Hi Tom,
> 
> On Thu, Jul 25, 2019 at 6:13 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Jul 25, 2019 at 04:33:21PM +0300, Sam Protsenko wrote:
> > > Hi Simon,
> > >
> > > On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> > > > >
> > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > > > > ---
> > > > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > > > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > > > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > > > >
> > > > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > > > similarity index 100%
> > > > > rename from test/py/tests/test_avb.py
> > > > > rename to test/py/tests/test_android/test_avb.py
> > > > > --
> > > >
> > > > I'd prefer to keep tsts in one place. What is the goal of this patch?
> > > >
> > >
> > > Similar patch was merged recently (adding test_android/ dir):
> > >
> > >     https://patchwork.ozlabs.org/patch/1128013/
> > >
> > > So we need either:
> > >   1. move that test out of test_android/ dir, and drop this one
> > >   2. or apply this patch
> > >
> > > What would you prefer? (I've explained my perspective on that matter
> > > earlier in this thread). We should do either (1) or (2) to keep the
> > > consistency.
> >
> > Note that we've also had vboot as a sub-directory since it was
> > introduced and test_fs is also a sub-directory.  My two cents is that
> > sub-directories help with organization as the number of tests increase.
> >
> 
> If there are no further concerns, can you please apply it for -rc2, so
> it doesn't get lost in ML?

For the record, yes.  Given that we do have other sub-directories of
tests and that over time organization will help with clarity not hinder
it, I'm going to grab this.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/7b8a199a/attachment.sig>

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

[Tom Rini]

On Tue, Jul 02, 2019 at 09:18:02PM +0300, Sam Protsenko wrote:

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/b94a12c0/attachment.sig>