* [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs
@ 2019-07-28 23:58 Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
2019-08-12 8:14 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-28 23:58 UTC (permalink / raw)
To: Tony Lindgren, Lee Jones
Cc: linux-omap, linux-kernel, Gustavo A. R. Silva, Stephen Rothwell,
Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume':
drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (!IS_ERR(omap->hsic480m_clk[i])) {
^
drivers/mfd/omap-usb-host.c:313:3: note: here
case OMAP_EHCI_PORT_MODE_TLL:
^~~~
drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend':
drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (!IS_ERR(omap->hsic480m_clk[i]))
^
drivers/mfd/omap-usb-host.c:349:3: note: here
case OMAP_EHCI_PORT_MODE_TLL:
^~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/mfd/omap-usb-host.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 792b855a9104..4798d9f3f9d5 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -308,7 +308,7 @@ static int usbhs_runtime_resume(struct device *dev)
i, r);
}
}
- /* Fall through as HSIC mode needs utmi_clk */
+ /* Fall through - as HSIC mode needs utmi_clk */
case OMAP_EHCI_PORT_MODE_TLL:
if (!IS_ERR(omap->utmi_clk[i])) {
@@ -344,7 +344,7 @@ static int usbhs_runtime_suspend(struct device *dev)
if (!IS_ERR(omap->hsic480m_clk[i]))
clk_disable_unprepare(omap->hsic480m_clk[i]);
- /* Fall through as utmi_clks were used in HSIC mode */
+ /* Fall through - as utmi_clks were used in HSIC mode */
case OMAP_EHCI_PORT_MODE_TLL:
if (!IS_ERR(omap->utmi_clk[i]))
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs
2019-07-28 23:58 [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-29 16:35 ` Kees Cook
2019-08-12 8:14 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-07-29 16:35 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Tony Lindgren, Lee Jones, linux-omap, linux-kernel, Stephen Rothwell
On Sun, Jul 28, 2019 at 06:58:58PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume':
> drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i])) {
> ^
> drivers/mfd/omap-usb-host.c:313:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend':
> drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i]))
> ^
> drivers/mfd/omap-usb-host.c:349:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 792b855a9104..4798d9f3f9d5 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -308,7 +308,7 @@ static int usbhs_runtime_resume(struct device *dev)
> i, r);
> }
> }
> - /* Fall through as HSIC mode needs utmi_clk */
> + /* Fall through - as HSIC mode needs utmi_clk */
>
> case OMAP_EHCI_PORT_MODE_TLL:
> if (!IS_ERR(omap->utmi_clk[i])) {
> @@ -344,7 +344,7 @@ static int usbhs_runtime_suspend(struct device *dev)
>
> if (!IS_ERR(omap->hsic480m_clk[i]))
> clk_disable_unprepare(omap->hsic480m_clk[i]);
> - /* Fall through as utmi_clks were used in HSIC mode */
> + /* Fall through - as utmi_clks were used in HSIC mode */
>
> case OMAP_EHCI_PORT_MODE_TLL:
> if (!IS_ERR(omap->utmi_clk[i]))
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs
2019-07-28 23:58 [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
@ 2019-08-12 8:14 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-08-12 8:14 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Tony Lindgren, linux-omap, linux-kernel, Stephen Rothwell, Kees Cook
On Sun, 28 Jul 2019, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume':
> drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i])) {
> ^
> drivers/mfd/omap-usb-host.c:313:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend':
> drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i]))
> ^
> drivers/mfd/omap-usb-host.c:349:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-12 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-28 23:58 [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
2019-08-12 8:14 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.