From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: divide the tx and rx bottom functions
Date: Thu, 15 Aug 2019 22:17:49 -0700 (PDT) [thread overview]
Message-ID: <20190815.221749.1827065487915332350.davem@davemloft.net> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2F18D43A3@RTITMBSVM03.realtek.com.tw>
From: Hayes Wang <hayeswang@realtek.com>
Date: Fri, 16 Aug 2019 02:59:16 +0000
> David Miller [mailto:davem@davemloft.net]
>> Sent: Friday, August 16, 2019 4:59 AM
> [...]
>> Theoretically, yes.
>>
>> But do you have actual performance numbers showing this to be worth
>> the change?
>>
>> Always provide performance numbers with changes that are supposed to
>> improve performance.
>
> On x86, they are almost the same.
> Tx/Rx: 943/943 Mbits/sec -> 945/944
>
> For arm platform,
> Tx/Rx: 917/917 Mbits/sec -> 933/933
> Improve about 1.74%.
Belongs in the commit message.
next prev parent reply other threads:[~2019-08-16 5:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:30 [PATCH net-next] r8152: divide the tx and rx bottom functions Hayes Wang
2019-08-15 20:58 ` David Miller
2019-08-16 2:59 ` Hayes Wang
2019-08-16 5:17 ` David Miller [this message]
2019-08-16 6:39 ` Eric Dumazet
2019-08-16 8:10 ` Hayes Wang
2019-08-16 8:19 ` Eric Dumazet
2019-08-16 9:08 ` Hayes Wang
2019-08-16 9:27 ` Eric Dumazet
2019-08-16 10:04 ` Hayes Wang
2019-08-19 6:40 ` [PATCH net-next v2] " Hayes Wang
2019-08-20 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815.221749.1827065487915332350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.