* [PATCHv2] runqueue: Add a progress meter for checking the task stamps
@ 2019-08-16 10:58 Peter Kjellerstedt
2019-08-16 16:20 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Peter Kjellerstedt @ 2019-08-16 10:58 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
bitbake/lib/bb/runqueue.py | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 7fa074f679..86dbd16def 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
stamppresent = []
tocheck = set()
+ msg = "Checking task stamps"
+ bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data)
+
+ checked = 0
for tid in sorted(sqdata.sq_revdeps):
(mc, fn, taskname, taskfn) = split_tid_mcfn(tid)
+ checked = checked + 1
+ bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data)
+
taskdep = rqdata.dataCaches[mc].task_deps[taskfn]
if 'noexec' in taskdep and taskname in taskdep['noexec']:
@@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
continue
tocheck.add(tid)
+ bb.event.fire(bb.event.ProcessFinished(msg), cooker.data)
valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] runqueue: Add a progress meter for checking the task stamps
2019-08-16 10:58 [PATCHv2] runqueue: Add a progress meter for checking the task stamps Peter Kjellerstedt
@ 2019-08-16 16:20 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2019-08-16 16:20 UTC (permalink / raw)
To: Peter Kjellerstedt, bitbake-devel
On Fri, 2019-08-16 at 12:58 +0200, Peter Kjellerstedt wrote:
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> bitbake/lib/bb/runqueue.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index 7fa074f679..86dbd16def 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
> stamppresent = []
> tocheck = set()
>
> + msg = "Checking task stamps"
> + bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data)
> +
> + checked = 0
> for tid in sorted(sqdata.sq_revdeps):
> (mc, fn, taskname, taskfn) = split_tid_mcfn(tid)
>
> + checked = checked + 1
> + bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data)
> +
> taskdep = rqdata.dataCaches[mc].task_deps[taskfn]
>
> if 'noexec' in taskdep and taskname in taskdep['noexec']:
> @@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
> continue
>
> tocheck.add(tid)
> + bb.event.fire(bb.event.ProcessFinished(msg), cooker.data)
>
> valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
This was discussed on irc. The performance patches which I've posted
should remove the need for a progress bar on this section of code. We
really shouldn't be taking a long time here...
Cheers,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-16 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16 10:58 [PATCHv2] runqueue: Add a progress meter for checking the task stamps Peter Kjellerstedt
2019-08-16 16:20 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.