* [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov
@ 2019-08-16 12:39 Geert Uytterhoeven
2019-08-16 15:37 ` Simon Horman
2019-08-17 6:41 ` Niklas Söderlund
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-08-16 12:39 UTC (permalink / raw)
To: Simon Horman, Magnus Damm; +Cc: linux-renesas-soc, Geert Uytterhoeven
As of commit 980532a5dda319ee ("soc: renesas: rcar-sysc: Use
GENPD_FLAG_ALWAYS_ON"), the local variable "gov" is assigned just once,
so it can be eliminated.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in renesas-devel for v5.4.
drivers/soc/renesas/rcar-sysc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soc/renesas/rcar-sysc.c b/drivers/soc/renesas/rcar-sysc.c
index 20fa9f34295c2879..40c1ddaa3b4fcae5 100644
--- a/drivers/soc/renesas/rcar-sysc.c
+++ b/drivers/soc/renesas/rcar-sysc.c
@@ -212,7 +212,6 @@ static int __init rcar_sysc_pd_setup(struct rcar_sysc_pd *pd)
{
struct generic_pm_domain *genpd = &pd->genpd;
const char *name = pd->genpd.name;
- struct dev_power_governor *gov = &simple_qos_governor;
int error;
if (pd->flags & PD_CPU) {
@@ -266,7 +265,7 @@ static int __init rcar_sysc_pd_setup(struct rcar_sysc_pd *pd)
rcar_sysc_power(&pd->ch, true);
finalize:
- error = pm_genpd_init(genpd, gov, false);
+ error = pm_genpd_init(genpd, &simple_qos_governor, false);
if (error)
pr_err("Failed to init PM domain %s: %d\n", name, error);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov
2019-08-16 12:39 [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov Geert Uytterhoeven
@ 2019-08-16 15:37 ` Simon Horman
2019-08-17 6:41 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-08-16 15:37 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc
On Fri, Aug 16, 2019 at 02:39:19PM +0200, Geert Uytterhoeven wrote:
> As of commit 980532a5dda319ee ("soc: renesas: rcar-sysc: Use
> GENPD_FLAG_ALWAYS_ON"), the local variable "gov" is assigned just once,
> so it can be eliminated.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in renesas-devel for v5.4.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov
2019-08-16 12:39 [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov Geert Uytterhoeven
2019-08-16 15:37 ` Simon Horman
@ 2019-08-17 6:41 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2019-08-17 6:41 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Simon Horman, Magnus Damm, linux-renesas-soc
Hi Geert,
Thanks for your work.
On 2019-08-16 14:39:19 +0200, Geert Uytterhoeven wrote:
> As of commit 980532a5dda319ee ("soc: renesas: rcar-sysc: Use
> GENPD_FLAG_ALWAYS_ON"), the local variable "gov" is assigned just once,
> so it can be eliminated.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> To be queued in renesas-devel for v5.4.
>
> drivers/soc/renesas/rcar-sysc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/renesas/rcar-sysc.c b/drivers/soc/renesas/rcar-sysc.c
> index 20fa9f34295c2879..40c1ddaa3b4fcae5 100644
> --- a/drivers/soc/renesas/rcar-sysc.c
> +++ b/drivers/soc/renesas/rcar-sysc.c
> @@ -212,7 +212,6 @@ static int __init rcar_sysc_pd_setup(struct rcar_sysc_pd *pd)
> {
> struct generic_pm_domain *genpd = &pd->genpd;
> const char *name = pd->genpd.name;
> - struct dev_power_governor *gov = &simple_qos_governor;
> int error;
>
> if (pd->flags & PD_CPU) {
> @@ -266,7 +265,7 @@ static int __init rcar_sysc_pd_setup(struct rcar_sysc_pd *pd)
> rcar_sysc_power(&pd->ch, true);
>
> finalize:
> - error = pm_genpd_init(genpd, gov, false);
> + error = pm_genpd_init(genpd, &simple_qos_governor, false);
> if (error)
> pr_err("Failed to init PM domain %s: %d\n", name, error);
>
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-17 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16 12:39 [PATCH] soc: renesas: rcar-sysc: Eliminate local variable gov Geert Uytterhoeven
2019-08-16 15:37 ` Simon Horman
2019-08-17 6:41 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.