* [Buildroot] [PATCH] package/gstreamer1/gst1-plugins-base: fix dispmanx option
@ 2019-08-17 12:24 Thomas Petazzoni
2019-08-20 11:20 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2019-08-17 12:24 UTC (permalink / raw)
To: buildroot
There is a typo in the handling of the
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX option: we're adding
dispmax to GST1_PLUGINS_BASE_WINSYS_LIST, which causes the following
build failure:
meson.build:1:0: ERROR: Options "dispmax" are not in allowed choices: "x11, wayland, win32, cocoa, dispmanx, viv-fb, gbm, auto"
We fix this by using the proper option name, "dispmanx" instead of the
slightly incorrect "dispmax".
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
index 66c136c36c..90d2478bbc 100644
--- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
+++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
@@ -74,7 +74,7 @@ GST1_PLUGINS_BASE_DEPENDENCIES += wayland wayland-protocols
endif
ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX),y)
-GST1_PLUGINS_BASE_WINSYS_LIST += dispmax
+GST1_PLUGINS_BASE_WINSYS_LIST += dispmanx
GST1_PLUGINS_BASE_DEPENDENCIES += rpi-userland
endif
GST1_PLUGINS_BASE_CONF_OPTS += -Dgl_winsys='$(subst $(space),$(comma),$(GST1_PLUGINS_BASE_WINSYS_LIST))'
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/gstreamer1/gst1-plugins-base: fix dispmanx option
2019-08-17 12:24 [Buildroot] [PATCH] package/gstreamer1/gst1-plugins-base: fix dispmanx option Thomas Petazzoni
@ 2019-08-20 11:20 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2019-08-20 11:20 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> There is a typo in the handling of the
> BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX option: we're adding
> dispmax to GST1_PLUGINS_BASE_WINSYS_LIST, which causes the following
> build failure:
> meson.build:1:0: ERROR: Options "dispmax" are not in allowed choices: "x11, wayland, win32, cocoa, dispmanx, viv-fb, gbm, auto"
> We fix this by using the proper option name, "dispmanx" instead of the
> slightly incorrect "dispmax".
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-20 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-17 12:24 [Buildroot] [PATCH] package/gstreamer1/gst1-plugins-base: fix dispmanx option Thomas Petazzoni
2019-08-20 11:20 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.