All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0
@ 2019-08-19  2:12 Yuan Chao
  2019-08-20  1:03 ` Tim Orling
  0 siblings, 1 reply; 3+ messages in thread
From: Yuan Chao @ 2019-08-19  2:12 UTC (permalink / raw)
  To: openembedded-devel

Add depends of python-vcversioner and python3-vcversioner.

Signed-off-by: Yuan Chao <yuanc.fnst@cn.fujitsu.com>
---
 meta-python/recipes-devtools/python/python-flask-pymongo.inc        | 6 ++++--
 ...{python-flask-pymongo_0.5.1.bb => python-flask-pymongo_2.3.0.bb} | 0
 ...ython3-flask-pymongo_0.5.1.bb => python3-flask-pymongo_2.3.0.bb} | 0
 3 files changed, 4 insertions(+), 2 deletions(-)
 rename meta-python/recipes-devtools/python/{python-flask-pymongo_0.5.1.bb => python-flask-pymongo_2.3.0.bb} (100%)
 rename meta-python/recipes-devtools/python/{python3-flask-pymongo_0.5.1.bb => python3-flask-pymongo_2.3.0.bb} (100%)

diff --git a/meta-python/recipes-devtools/python/python-flask-pymongo.inc b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
index fb2d6ed..bc41fd2 100644
--- a/meta-python/recipes-devtools/python/python-flask-pymongo.inc
+++ b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
@@ -5,9 +5,11 @@ SECTION = "devel/python"
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://flask_pymongo/wrappers.py;beginline=1;endline=24;md5=424c4e1047d28e01b4e4634a069c019d"
 
-SRC_URI[md5sum] = "d7a1b717f27154e1f3a355f8ec2467d6"
-SRC_URI[sha256sum] = "2baaa2ba5107d72b3a8bd4b5c0c8881316e35340ad1ae979cc13f1f3c8843b3d"
+SRC_URI[md5sum] = "94df71e6800b1d7915cc91a74b70f959"
+SRC_URI[sha256sum] = "620eb02dc8808a5fcb90f26cab6cba9d6bf497b15032ae3ca99df80366e33314"
 
 PYPI_PACKAGE = "Flask-PyMongo"
 
+DEPENDS = "python-vcversioner python-vcversioner-native python3-vcversioner python3-vcversioner-native"
+
 RDEPENDS_${PN} = "${PYTHON_PN}-pymongo ${PYTHON_PN}-flask"
diff --git a/meta-python/recipes-devtools/python/python-flask-pymongo_0.5.1.bb b/meta-python/recipes-devtools/python/python-flask-pymongo_2.3.0.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python-flask-pymongo_0.5.1.bb
rename to meta-python/recipes-devtools/python/python-flask-pymongo_2.3.0.bb
diff --git a/meta-python/recipes-devtools/python/python3-flask-pymongo_0.5.1.bb b/meta-python/recipes-devtools/python/python3-flask-pymongo_2.3.0.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python3-flask-pymongo_0.5.1.bb
rename to meta-python/recipes-devtools/python/python3-flask-pymongo_2.3.0.bb
-- 
2.7.4





^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0
  2019-08-19  2:12 [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0 Yuan Chao
@ 2019-08-20  1:03 ` Tim Orling
  2019-08-20  2:19   ` Yuan, Chao
  0 siblings, 1 reply; 3+ messages in thread
From: Tim Orling @ 2019-08-20  1:03 UTC (permalink / raw)
  To: Yuan Chao; +Cc: openembedded-devel

On Sun, Aug 18, 2019 at 7:13 PM Yuan Chao <yuanc.fnst@cn.fujitsu.com> wrote:

> Add depends of python-vcversioner and python3-vcversioner.
>
> Signed-off-by: Yuan Chao <yuanc.fnst@cn.fujitsu.com>
> ---
>  meta-python/recipes-devtools/python/python-flask-pymongo.inc        | 6
> ++++--
>  ...{python-flask-pymongo_0.5.1.bb => python-flask-pymongo_2.3.0.bb} | 0
>  ...ython3-flask-pymongo_0.5.1.bb => python3-flask-pymongo_2.3.0.bb} | 0
>  3 files changed, 4 insertions(+), 2 deletions(-)
>  rename meta-python/recipes-devtools/python/{python-flask-pymongo_0.5.1.bb
> => python-flask-pymongo_2.3.0.bb} (100%)
>  rename meta-python/recipes-devtools/python/{
> python3-flask-pymongo_0.5.1.bb => python3-flask-pymongo_2.3.0.bb} (100%)
>
> diff --git a/meta-python/recipes-devtools/python/python-flask-pymongo.inc
> b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
> index fb2d6ed..bc41fd2 100644
> --- a/meta-python/recipes-devtools/python/python-flask-pymongo.inc
> +++ b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
> @@ -5,9 +5,11 @@ SECTION = "devel/python"
>  LICENSE = "BSD"
>  LIC_FILES_CHKSUM =
> "file://flask_pymongo/wrappers.py;beginline=1;endline=24;md5=424c4e1047d28e01b4e4634a069c019d"
>
> -SRC_URI[md5sum] = "d7a1b717f27154e1f3a355f8ec2467d6"
> -SRC_URI[sha256sum] =
> "2baaa2ba5107d72b3a8bd4b5c0c8881316e35340ad1ae979cc13f1f3c8843b3d"
> +SRC_URI[md5sum] = "94df71e6800b1d7915cc91a74b70f959"
> +SRC_URI[sha256sum] =
> "620eb02dc8808a5fcb90f26cab6cba9d6bf497b15032ae3ca99df80366e33314"
>
>  PYPI_PACKAGE = "Flask-PyMongo"
>
> +DEPENDS = "python-vcversioner python-vcversioner-native
> python3-vcversioner python3-vcversioner-native"
> +


Nacked-by: Tim Orling <ticotimo@gmail.com>

This is not the right way to do this. Use ${PYTHON_PN} otherwise you are
forcing build of both python 2 and python 3 packages every time. We will be
moving python 2 support out of meta-python in preparation for Python 2 EOL
next year.

Also, does it DEPEND (build time dependency) on both the native and target
vcversioner? That doesn’t feel right.

>
>  RDEPENDS_${PN} = "${PYTHON_PN}-pymongo ${PYTHON_PN}-flask"
> diff --git a/meta-python/recipes-devtools/python/
> python-flask-pymongo_0.5.1.bb b/meta-python/recipes-devtools/python/
> python-flask-pymongo_2.3.0.bb
> similarity index 100%
> rename from meta-python/recipes-devtools/python/
> python-flask-pymongo_0.5.1.bb
> rename to meta-python/recipes-devtools/python/
> python-flask-pymongo_2.3.0.bb
> diff --git a/meta-python/recipes-devtools/python/
> python3-flask-pymongo_0.5.1.bb b/meta-python/recipes-devtools/python/
> python3-flask-pymongo_2.3.0.bb
> similarity index 100%
> rename from meta-python/recipes-devtools/python/
> python3-flask-pymongo_0.5.1.bb
> rename to meta-python/recipes-devtools/python/
> python3-flask-pymongo_2.3.0.bb
> --
> 2.7.4
>
>
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0
  2019-08-20  1:03 ` Tim Orling
@ 2019-08-20  2:19   ` Yuan, Chao
  0 siblings, 0 replies; 3+ messages in thread
From: Yuan, Chao @ 2019-08-20  2:19 UTC (permalink / raw)
  To: Tim Orling; +Cc: openembedded-devel

Thanks, I will use ${PYTHON_PN} in a v3.

DEPEND on vcversioner is needed by setup.py:
         setup_requires=["vcversioner"],
And I have tried that if do not add native in DEPEND, it will throw an error when do_configure :
         Traceback (most recent call last):
                   File "setup.py", line 18, in <module>
                            from setuptools import find_packages, setup
ImportError: No module named setuptools
WARNING: exit code 1 from a shell command.
However, setuptools is actually inherit in .bb file.
I don’t know why but, when adding native in DEPEND, it works well.

Best Regards,
Yuan

From: Tim Orling <ticotimo@gmail.com>
Sent: Tuesday, August 20, 2019 9:03 AM
To: Yuan, Chao/袁 超 <yuanc.fnst@cn.fujitsu.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0



On Sun, Aug 18, 2019 at 7:13 PM Yuan Chao <yuanc.fnst@cn.fujitsu.com<mailto:yuanc.fnst@cn.fujitsu.com>> wrote:
Add depends of python-vcversioner and python3-vcversioner.

Signed-off-by: Yuan Chao <yuanc.fnst@cn.fujitsu.com<mailto:yuanc.fnst@cn.fujitsu.com>>
---
 meta-python/recipes-devtools/python/python-flask-pymongo.inc        | 6 ++++--
 ...{python-flask-pymongo_0.5.1.bb<http://python-flask-pymongo_0.5.1.bb> => python-flask-pymongo_2.3.0.bb<http://python-flask-pymongo_2.3.0.bb>} | 0
 ...ython3-flask-pymongo_0.5.1.bb<http://ython3-flask-pymongo_0.5.1.bb> => python3-flask-pymongo_2.3.0.bb<http://python3-flask-pymongo_2.3.0.bb>} | 0
 3 files changed, 4 insertions(+), 2 deletions(-)
 rename meta-python/recipes-devtools/python/{python-flask-pymongo_0.5.1.bb<http://python-flask-pymongo_0.5.1.bb> => python-flask-pymongo_2.3.0.bb<http://python-flask-pymongo_2.3.0.bb>} (100%)
 rename meta-python/recipes-devtools/python/{python3-flask-pymongo_0.5.1.bb<http://python3-flask-pymongo_0.5.1.bb> => python3-flask-pymongo_2.3.0.bb<http://python3-flask-pymongo_2.3.0.bb>} (100%)

diff --git a/meta-python/recipes-devtools/python/python-flask-pymongo.inc b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
index fb2d6ed..bc41fd2 100644
--- a/meta-python/recipes-devtools/python/python-flask-pymongo.inc
+++ b/meta-python/recipes-devtools/python/python-flask-pymongo.inc
@@ -5,9 +5,11 @@ SECTION = "devel/python"
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://flask_pymongo/wrappers.py;beginline=1;endline=24;md5=424c4e1047d28e01b4e4634a069c019d"

-SRC_URI[md5sum] = "d7a1b717f27154e1f3a355f8ec2467d6"
-SRC_URI[sha256sum] = "2baaa2ba5107d72b3a8bd4b5c0c8881316e35340ad1ae979cc13f1f3c8843b3d"
+SRC_URI[md5sum] = "94df71e6800b1d7915cc91a74b70f959"
+SRC_URI[sha256sum] = "620eb02dc8808a5fcb90f26cab6cba9d6bf497b15032ae3ca99df80366e33314"

 PYPI_PACKAGE = "Flask-PyMongo"

+DEPENDS = "python-vcversioner python-vcversioner-native python3-vcversioner python3-vcversioner-native"
+

Nacked-by: Tim Orling <ticotimo@gmail.com<mailto:ticotimo@gmail.com>>

This is not the right way to do this. Use ${PYTHON_PN} otherwise you are forcing build of both python 2 and python 3 packages every time. We will be moving python 2 support out of meta-python in preparation for Python 2 EOL next year.

Also, does it DEPEND (build time dependency) on both the native and target vcversioner? That doesn’t feel right.

 RDEPENDS_${PN} = "${PYTHON_PN}-pymongo ${PYTHON_PN}-flask"
diff --git a/meta-python/recipes-devtools/python/python-flask-pymongo_0.5.1.bb<http://python-flask-pymongo_0.5.1.bb> b/meta-python/recipes-devtools/python/python-flask-pymongo_2.3.0.bb<http://python-flask-pymongo_2.3.0.bb>
similarity index 100%
rename from meta-python/recipes-devtools/python/python-flask-pymongo_0.5.1.bb<http://python-flask-pymongo_0.5.1.bb>
rename to meta-python/recipes-devtools/python/python-flask-pymongo_2.3.0.bb<http://python-flask-pymongo_2.3.0.bb>
diff --git a/meta-python/recipes-devtools/python/python3-flask-pymongo_0.5.1.bb<http://python3-flask-pymongo_0.5.1.bb> b/meta-python/recipes-devtools/python/python3-flask-pymongo_2.3.0.bb<http://python3-flask-pymongo_2.3.0.bb>
similarity index 100%
rename from meta-python/recipes-devtools/python/python3-flask-pymongo_0.5.1.bb<http://python3-flask-pymongo_0.5.1.bb>
rename to meta-python/recipes-devtools/python/python3-flask-pymongo_2.3.0.bb<http://python3-flask-pymongo_2.3.0.bb>
--
2.7.4



--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel



^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20  2:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19  2:12 [meta-python] [PATCH v2] python-flask-pymongo: upgrade 0.5.1 -> 2.3.0 Yuan Chao
2019-08-20  1:03 ` Tim Orling
2019-08-20  2:19   ` Yuan, Chao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.