* [PATCH] pinctrl: rk805: Make structures constant
@ 2019-08-19 7:57 Nishka Dasgupta
2019-08-20 10:28 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-08-19 7:57 UTC (permalink / raw)
To: linus.walleij, linux-gpio; +Cc: Nishka Dasgupta
Static structures rk805_pinctrl_desc and rk805_gpio_chip, of types
gpio_chip and pinctrl_desc respectively, are not used except to be
copied into the fields of a different variable. Hence make
rk805_pinctrl_desc and rk805_gpio_chip both constant to protect them
from unintended modification.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/pinctrl/pinctrl-rk805.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rk805.c b/drivers/pinctrl/pinctrl-rk805.c
index a8459cafd4ea..26adbe9d6d42 100644
--- a/drivers/pinctrl/pinctrl-rk805.c
+++ b/drivers/pinctrl/pinctrl-rk805.c
@@ -197,7 +197,7 @@ static int rk805_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
return !(val & pci->pin_cfg[offset].dir_msk);
}
-static struct gpio_chip rk805_gpio_chip = {
+static const struct gpio_chip rk805_gpio_chip = {
.label = "rk805-gpio",
.request = gpiochip_generic_request,
.free = gpiochip_generic_free,
@@ -404,7 +404,7 @@ static const struct pinconf_ops rk805_pinconf_ops = {
.pin_config_set = rk805_pinconf_set,
};
-static struct pinctrl_desc rk805_pinctrl_desc = {
+static const struct pinctrl_desc rk805_pinctrl_desc = {
.name = "rk805-pinctrl",
.pctlops = &rk805_pinctrl_ops,
.pmxops = &rk805_pinmux_ops,
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: rk805: Make structures constant
2019-08-19 7:57 [PATCH] pinctrl: rk805: Make structures constant Nishka Dasgupta
@ 2019-08-20 10:28 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-08-20 10:28 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: open list:GPIO SUBSYSTEM
On Mon, Aug 19, 2019 at 9:58 AM Nishka Dasgupta
<nishkadg.linux@gmail.com> wrote:
> Static structures rk805_pinctrl_desc and rk805_gpio_chip, of types
> gpio_chip and pinctrl_desc respectively, are not used except to be
> copied into the fields of a different variable. Hence make
> rk805_pinctrl_desc and rk805_gpio_chip both constant to protect them
> from unintended modification.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Patch applied!
Thanks
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-20 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 7:57 [PATCH] pinctrl: rk805: Make structures constant Nishka Dasgupta
2019-08-20 10:28 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.