From: Vinod Koul <vkoul@kernel.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Sibi Sankar <sibis@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file
Date: Tue, 20 Aug 2019 18:04:43 +0530 [thread overview]
Message-ID: <20190820123443.GA12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190820122719.GD31261@centauri>
On 20-08-19, 14:27, Niklas Cassel wrote:
> On Tue, Aug 20, 2019 at 12:12:10PM +0530, Vinod Koul wrote:
> > Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc
> > nodes
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/pm8150.dtsi | 95 ++++++++++++++++++++++++++++
> > 1 file changed, 95 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> > new file mode 100644
> > index 000000000000..4a678be46d37
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> > @@ -0,0 +1,95 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> > +// Copyright (c) 2019, Linaro Limited
> > +
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > +
> > +&spmi_bus {
> > + pm8150_0: pmic@0 {
> > + compatible = "qcom,pm8150", "qcom,spmi-pmic";
> > + reg = <0x0 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pon: power-on@800 {
> > + compatible = "qcom,pm8916-pon";
> > + reg = <0x0800>;
> > + pwrkey {
> > + compatible = "qcom,pm8941-pwrkey";
> > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>
> Here you use 0 for 3rd cell
>
> > + debounce = <15625>;
> > + bias-pull-up;
> > + linux,code = <KEY_POWER>;
> > +
> > + status = "disabled";
> > + };
> > + };
> > +
> > + pm8150_adc: adc@3100 {
> > + compatible = "qcom,spmi-adc5";
> > + reg = <0x3100>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + #io-channel-cells = <1>;
> > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>
> Here you use 0x0 for 3rd cell, be consistent.
Will make it either at this and other places, thanks for pointing!
--
~Vinod
next prev parent reply other threads:[~2019-08-20 12:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 6:42 [PATCH v2 0/8] arm64: dts: qcom: sm8150: Add SM8150 DTS Vinod Koul
2019-08-20 6:42 ` [PATCH v2 1/8] arm64: dts: qcom: sm8150: add base dts file Vinod Koul
2019-08-20 12:27 ` Niklas Cassel
2019-08-20 12:33 ` Vinod Koul
2019-08-20 13:33 ` Amit Kucheria
2019-08-20 13:33 ` Amit Kucheria
2019-08-20 16:37 ` Vinod Koul
2019-08-20 16:37 ` Vinod Koul
2019-08-20 6:42 ` [PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file Vinod Koul
2019-08-20 12:27 ` Niklas Cassel
2019-08-20 12:34 ` Vinod Koul [this message]
2019-08-20 6:42 ` [PATCH v2 3/8] arm64: dts: qcom: pm8150b: " Vinod Koul
2019-08-20 12:27 ` Niklas Cassel
2019-08-20 12:35 ` Vinod Koul
2019-08-20 6:42 ` [PATCH v2 4/8] arm64: dts: qcom: pm8150l: " Vinod Koul
2019-08-20 6:42 ` [PATCH v2 5/8] arm64: dts: qcom: sm8150-mtp: add base dts file Vinod Koul
2019-08-20 12:26 ` Niklas Cassel
2019-08-20 12:36 ` Vinod Koul
2019-08-20 6:42 ` [PATCH v2 6/8] arm64: dts: qcom: sm8150-mtp: Add regulators Vinod Koul
2019-08-20 12:26 ` Niklas Cassel
2019-08-20 12:37 ` Vinod Koul
2019-08-20 6:42 ` [PATCH v2 7/8] arm64: dts: qcom: sm8150: Add reserved-memory regions Vinod Koul
2019-08-20 12:24 ` Niklas Cassel
2019-08-20 6:42 ` [PATCH v2 8/8] arm64: dts: qcom: sm8150: Add apps shared nodes Vinod Koul
2019-08-20 12:28 ` [PATCH v2 0/8] arm64: dts: qcom: sm8150: Add SM8150 DTS Niklas Cassel
2019-08-20 12:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820123443.GA12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.