* [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
@ 2019-08-22 6:59 Chris Wilson
2019-08-22 9:06 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Chris Wilson @ 2019-08-22 6:59 UTC (permalink / raw)
To: intel-gfx
You have to cut it off at the neck, otherwise it just reappears in the
next merge, like commit 3f866026f0ce ("Merge drm/drm-next
into drm-intel-next-queued")
References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/i915_gem_batch_pool.c | 132 ---------------------
1 file changed, 132 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/i915_gem_batch_pool.c
diff --git a/drivers/gpu/drm/i915/i915_gem_batch_pool.c b/drivers/gpu/drm/i915/i915_gem_batch_pool.c
deleted file mode 100644
index 8675a608a6fe..000000000000
--- a/drivers/gpu/drm/i915/i915_gem_batch_pool.c
+++ /dev/null
@@ -1,132 +0,0 @@
-/*
- * SPDX-License-Identifier: MIT
- *
- * Copyright © 2014-2018 Intel Corporation
- */
-
-#include "i915_gem_batch_pool.h"
-#include "i915_drv.h"
-
-/**
- * DOC: batch pool
- *
- * In order to submit batch buffers as 'secure', the software command parser
- * must ensure that a batch buffer cannot be modified after parsing. It does
- * this by copying the user provided batch buffer contents to a kernel owned
- * buffer from which the hardware will actually execute, and by carefully
- * managing the address space bindings for such buffers.
- *
- * The batch pool framework provides a mechanism for the driver to manage a
- * set of scratch buffers to use for this purpose. The framework can be
- * extended to support other uses cases should they arise.
- */
-
-/**
- * i915_gem_batch_pool_init() - initialize a batch buffer pool
- * @pool: the batch buffer pool
- * @engine: the associated request submission engine
- */
-void i915_gem_batch_pool_init(struct i915_gem_batch_pool *pool,
- struct intel_engine_cs *engine)
-{
- int n;
-
- pool->engine = engine;
-
- for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++)
- INIT_LIST_HEAD(&pool->cache_list[n]);
-}
-
-/**
- * i915_gem_batch_pool_fini() - clean up a batch buffer pool
- * @pool: the pool to clean up
- *
- * Note: Callers must hold the struct_mutex.
- */
-void i915_gem_batch_pool_fini(struct i915_gem_batch_pool *pool)
-{
- int n;
-
- lockdep_assert_held(&pool->engine->i915->drm.struct_mutex);
-
- for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++) {
- struct drm_i915_gem_object *obj, *next;
-
- list_for_each_entry_safe(obj, next,
- &pool->cache_list[n],
- batch_pool_link)
- i915_gem_object_put(obj);
-
- INIT_LIST_HEAD(&pool->cache_list[n]);
- }
-}
-
-/**
- * i915_gem_batch_pool_get() - allocate a buffer from the pool
- * @pool: the batch buffer pool
- * @size: the minimum desired size of the returned buffer
- *
- * Returns an inactive buffer from @pool with at least @size bytes,
- * with the pages pinned. The caller must i915_gem_object_unpin_pages()
- * on the returned object.
- *
- * Note: Callers must hold the struct_mutex
- *
- * Return: the buffer object or an error pointer
- */
-struct drm_i915_gem_object *
-i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool,
- size_t size)
-{
- struct drm_i915_gem_object *obj;
- struct list_head *list;
- int n, ret;
-
- lockdep_assert_held(&pool->engine->i915->drm.struct_mutex);
-
- /* Compute a power-of-two bucket, but throw everything greater than
- * 16KiB into the same bucket: i.e. the the buckets hold objects of
- * (1 page, 2 pages, 4 pages, 8+ pages).
- */
- n = fls(size >> PAGE_SHIFT) - 1;
- if (n >= ARRAY_SIZE(pool->cache_list))
- n = ARRAY_SIZE(pool->cache_list) - 1;
- list = &pool->cache_list[n];
-
- list_for_each_entry(obj, list, batch_pool_link) {
- struct dma_resv *resv = obj->base.resv;
-
- /* The batches are strictly LRU ordered */
- if (!dma_resv_test_signaled_rcu(resv, true))
- break;
-
- /*
- * The object is now idle, clear the array of shared
- * fences before we add a new request. Although, we
- * remain on the same engine, we may be on a different
- * timeline and so may continually grow the array,
- * trapping a reference to all the old fences, rather
- * than replace the existing fence.
- */
- if (rcu_access_pointer(resv->fence)) {
- dma_resv_lock(resv, NULL);
- dma_resv_add_excl_fence(resv, NULL);
- dma_resv_unlock(resv);
- }
-
- if (obj->base.size >= size)
- goto found;
- }
-
- obj = i915_gem_object_create_internal(pool->engine->i915, size);
- if (IS_ERR(obj))
- return obj;
-
-found:
- ret = i915_gem_object_pin_pages(obj);
- if (ret)
- return ERR_PTR(ret);
-
- list_move_tail(&obj->batch_pool_link, list);
- return obj;
-}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 6:59 [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c Chris Wilson
@ 2019-08-22 9:06 ` Patchwork
2019-08-22 9:26 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-08-22 9:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kill the undead i915_gem_batch_pool.c
URL : https://patchwork.freedesktop.org/series/65593/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7db6eec8126c drm/i915: Kill the undead i915_gem_batch_pool.c
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")'
#10:
References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
-:15: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
deleted file mode 100644
total: 1 errors, 1 warnings, 0 checks, 0 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 6:59 [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c Chris Wilson
2019-08-22 9:06 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-08-22 9:26 ` Patchwork
2019-08-22 11:12 ` [PATCH] " Joonas Lahtinen
2019-08-23 2:15 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-08-22 9:26 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kill the undead i915_gem_batch_pool.c
URL : https://patchwork.freedesktop.org/series/65593/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6763 -> Patchwork_14137
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/
Known issues
------------
Here are the changes found in Patchwork_14137 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/fi-icl-u2/igt@gem_close_race@basic-threads.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/fi-icl-u2/igt@gem_close_race@basic-threads.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [WARN][4] ([fdo#109483] / [fdo#111156])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@gem_mmap_gtt@basic-small-bo-tiledx:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111156]: https://bugs.freedesktop.org/show_bug.cgi?id=111156
Participating hosts (56 -> 47)
------------------------------
Missing (9): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6763 -> Patchwork_14137
CI-20190529: 20190529
CI_DRM_6763: a9a5855cece4d78bc2dfd4c719191a9ccabab4fb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5147: 289dcb935ee195352f987c0ae7dd31693bf7de0f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14137: 7db6eec8126c31e58b88dddc918f0b9259814dd8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7db6eec8126c drm/i915: Kill the undead i915_gem_batch_pool.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 6:59 [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c Chris Wilson
2019-08-22 9:06 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-22 9:26 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-08-22 11:12 ` Joonas Lahtinen
2019-08-22 11:17 ` Chris Wilson
2019-08-23 2:15 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 9+ messages in thread
From: Joonas Lahtinen @ 2019-08-22 11:12 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Quoting Chris Wilson (2019-08-22 09:59:17)
> You have to cut it off at the neck, otherwise it just reappears in the
> next merge, like commit 3f866026f0ce ("Merge drm/drm-next
> into drm-intel-next-queued")
>
> References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 11:12 ` [PATCH] " Joonas Lahtinen
@ 2019-08-22 11:17 ` Chris Wilson
2019-10-09 18:53 ` Sean Paul
0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-08-22 11:17 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx
Quoting Joonas Lahtinen (2019-08-22 12:12:03)
> Quoting Chris Wilson (2019-08-22 09:59:17)
> > You have to cut it off at the neck, otherwise it just reappears in the
> > next merge, like commit 3f866026f0ce ("Merge drm/drm-next
> > into drm-intel-next-queued")
> >
> > References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
And once more the nails have been put back in the coffin.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 6:59 [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c Chris Wilson
` (2 preceding siblings ...)
2019-08-22 11:12 ` [PATCH] " Joonas Lahtinen
@ 2019-08-23 2:15 ` Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-08-23 2:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kill the undead i915_gem_batch_pool.c
URL : https://patchwork.freedesktop.org/series/65593/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6763_full -> Patchwork_14137_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14137_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb4/igt@gem_exec_balancer@smoke.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb5/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_reloc@basic-wc-gtt-active:
- shard-skl: [PASS][3] -> [DMESG-WARN][4] ([fdo#106107])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-skl6/igt@gem_exec_reloc@basic-wc-gtt-active.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-skl5/igt@gem_exec_reloc@basic-wc-gtt-active.html
* igt@gem_exec_schedule@deep-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb8/igt@gem_exec_schedule@deep-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb1/igt@gem_exec_schedule@deep-bsd.html
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl4/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl8/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
* igt@kms_flip@bo-too-big:
- shard-glk: [PASS][9] -> [INCOMPLETE][10] ([fdo#103359] / [k.org#198133]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-glk6/igt@kms_flip@bo-too-big.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-glk2/igt@kms_flip@bo-too-big.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#106978] / [fdo#107713])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb2/igt@kms_psr@psr2_basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb1/igt@kms_psr@psr2_basic.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109276]) +15 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb4/igt@prime_busy@hang-bsd2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][21] ([fdo#110841]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][23] ([fdo#109276]) -> [PASS][24] +17 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb5/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-apl: [INCOMPLETE][27] ([fdo#103927]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][31] ([fdo#105767]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- shard-skl: [FAIL][33] ([fdo#103184] / [fdo#103232] / [fdo#108472]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-skl3/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-skl4/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-hsw: [FAIL][35] ([fdo#102887]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-hsw2/igt@kms_flip@2x-flip-vs-expired-vblank.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-hsw6/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][37] ([fdo#105363]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@dpms-vs-vblank-race:
- shard-glk: [FAIL][39] ([fdo#103060]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-glk6/igt@kms_flip@dpms-vs-vblank-race.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-glk9/igt@kms_flip@dpms-vs-vblank-race.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][41] ([fdo#103167]) -> [PASS][42] +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][43] ([fdo#108145]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][45] ([fdo#109642] / [fdo#111068]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][47] ([fdo#108341]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb1/igt@kms_psr@no_drrs.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb1/igt@kms_psr@psr2_sprite_render.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][51] ([fdo#99912]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-glk1/igt@kms_setmode@basic.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-glk4/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-wait-busy-hang:
- shard-iclb: [INCOMPLETE][53] ([fdo#107713]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb7/igt@kms_vblank@pipe-a-wait-busy-hang.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb1/igt@kms_vblank@pipe-a-wait-busy-hang.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][55] ([fdo#103665]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@perf@polling:
- shard-skl: [FAIL][57] ([fdo#110728]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-skl9/igt@perf@polling.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-skl1/igt@perf@polling.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-iclb: [FAIL][59] ([fdo#105010]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb7/igt@perf_pmu@rc6-runtime-pm-long.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb4/igt@perf_pmu@rc6-runtime-pm-long.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][61] ([fdo#111330]) -> [SKIP][62] ([fdo#109276]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: [SKIP][63] ([fdo#109271]) -> [INCOMPLETE][64] ([fdo#103927])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-apl: [FAIL][65] ([fdo#108145]) -> [INCOMPLETE][66] ([fdo#103927])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6763/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/shard-apl5/igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb.html
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6763 -> Patchwork_14137
CI-20190529: 20190529
CI_DRM_6763: a9a5855cece4d78bc2dfd4c719191a9ccabab4fb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5147: 289dcb935ee195352f987c0ae7dd31693bf7de0f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14137: 7db6eec8126c31e58b88dddc918f0b9259814dd8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14137/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
2019-08-22 11:17 ` Chris Wilson
@ 2019-10-09 18:53 ` Sean Paul
2019-10-09 18:57 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Sean Paul @ 2019-10-09 18:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On Thu, Aug 22, 2019 at 7:17 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Joonas Lahtinen (2019-08-22 12:12:03)
> > Quoting Chris Wilson (2019-08-22 09:59:17)
> > > You have to cut it off at the neck, otherwise it just reappears in the
> > > next merge, like commit 3f866026f0ce ("Merge drm/drm-next
> > > into drm-intel-next-queued")
> > >
> > > References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> And once more the nails have been put back in the coffin.
Months later, a hand reaches out from the grave and says:
Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
(warnings from i915.rst htmldocs build)
Sean
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
2019-10-09 18:53 ` Sean Paul
@ 2019-10-09 18:57 ` Chris Wilson
2019-10-09 19:12 ` Sean Paul
0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-10-09 18:57 UTC (permalink / raw)
To: Sean Paul; +Cc: Intel Graphics Development
Quoting Sean Paul (2019-10-09 19:53:31)
> On Thu, Aug 22, 2019 at 7:17 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Joonas Lahtinen (2019-08-22 12:12:03)
> > > Quoting Chris Wilson (2019-08-22 09:59:17)
> > > > You have to cut it off at the neck, otherwise it just reappears in the
> > > > next merge, like commit 3f866026f0ce ("Merge drm/drm-next
> > > > into drm-intel-next-queued")
> > > >
> > > > References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > >
> > > Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >
> > And once more the nails have been put back in the coffin.
>
> Months later, a hand reaches out from the grave and says:
>
> Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
> Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
> Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
commit b047463c852272ef9956ad3a4c706f78f8b06c17
Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Date: Fri Aug 30 11:58:48 2019 +0300
drm/i915: Remove link to missing "Batchbuffer Pools" documentation
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c
2019-10-09 18:57 ` Chris Wilson
@ 2019-10-09 19:12 ` Sean Paul
0 siblings, 0 replies; 9+ messages in thread
From: Sean Paul @ 2019-10-09 19:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development, Sean Paul
On Wed, Oct 09, 2019 at 07:57:33PM +0100, Chris Wilson wrote:
> Quoting Sean Paul (2019-10-09 19:53:31)
> > On Thu, Aug 22, 2019 at 7:17 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Joonas Lahtinen (2019-08-22 12:12:03)
> > > > Quoting Chris Wilson (2019-08-22 09:59:17)
> > > > > You have to cut it off at the neck, otherwise it just reappears in the
> > > > > next merge, like commit 3f866026f0ce ("Merge drm/drm-next
> > > > > into drm-intel-next-queued")
> > > > >
> > > > > References: 3f866026f0ce ("Merge drm/drm-next into drm-intel-next-queued")
> > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > >
> > > > Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > >
> > > And once more the nails have been put back in the coffin.
> >
> > Months later, a hand reaches out from the grave and says:
> >
> > Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
> > Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
> > Error: Cannot open file ../drivers/gpu/drm/i915/i915_gem_batch_pool.c
>
> commit b047463c852272ef9956ad3a4c706f78f8b06c17
> Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Date: Fri Aug 30 11:58:48 2019 +0300
>
> drm/i915: Remove link to missing "Batchbuffer Pools" documentation
>
Ah, that's so much less fun :-)
Thanks for the reference, I look forward to getting it in -misc on the next
backmerge.
Sean
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-09 19:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 6:59 [PATCH] drm/i915: Kill the undead i915_gem_batch_pool.c Chris Wilson
2019-08-22 9:06 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-22 9:26 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-22 11:12 ` [PATCH] " Joonas Lahtinen
2019-08-22 11:17 ` Chris Wilson
2019-10-09 18:53 ` Sean Paul
2019-10-09 18:57 ` Chris Wilson
2019-10-09 19:12 ` Sean Paul
2019-08-23 2:15 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.