All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] drm/panfrost: Enable devfreq to work without regulator
@ 2019-08-22  9:15 Dan Carpenter
  2019-08-22  9:32 ` [PATCH] drm/panfrost: Add missing check for pfdev->regulator Steven Price
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2019-08-22  9:15 UTC (permalink / raw)
  To: steven.price; +Cc: dri-devel

Hello Steven Price,

This is a semi-automatic email about new static checker warnings.

The patch e21dd290881b: "drm/panfrost: Enable devfreq to work without 
regulator" from Aug 16, 2019, leads to the following Smatch complaint:

    drivers/gpu/drm/panfrost/panfrost_devfreq.c:56 panfrost_devfreq_target()
    error: we previously assumed 'pfdev->regulator' could be null (see line 42)

drivers/gpu/drm/panfrost/panfrost_devfreq.c
    41		 */
    42		if (old_clk_rate < target_rate && pfdev->regulator) {
                                                  ^^^^^^^^^^^^^^^^
We added some new checks.

    43			err = regulator_set_voltage(pfdev->regulator, target_volt,
    44						    target_volt);
    45			if (err) {
    46				dev_err(dev, "Cannot set voltage %lu uV\n",
    47					target_volt);
    48				return err;
    49			}
    50		}
    51	
    52		err = clk_set_rate(pfdev->clock, target_rate);
    53		if (err) {
    54			dev_err(dev, "Cannot set frequency %lu (%d)\n", target_rate,
    55				err);
    56			regulator_set_voltage(pfdev->regulator, pfdev->devfreq.cur_volt,
                                              ^^^^^^^^^^^^^^^^
But here it isn't checked.

    57					      pfdev->devfreq.cur_volt);
    58			return err;

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/panfrost: Add missing check for pfdev->regulator
  2019-08-22  9:15 [bug report] drm/panfrost: Enable devfreq to work without regulator Dan Carpenter
@ 2019-08-22  9:32 ` Steven Price
  2019-08-23  1:52   ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Steven Price @ 2019-08-22  9:32 UTC (permalink / raw)
  To: Daniel Vetter, David Airlie, Rob Herring, Tomeu Vizoso
  Cc: dri-devel, linux-kernel, Steven Price, Dan Carpenter

When modifying panfrost_devfreq_target() to support a device without a
regulator defined I missed the check on the error path. Let's add it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator")
Signed-off-by: Steven Price <steven.price@arm.com>
---
 drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index 710d903f8e0d..a1f5fa6a742a 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -53,8 +53,10 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq,
 	if (err) {
 		dev_err(dev, "Cannot set frequency %lu (%d)\n", target_rate,
 			err);
-		regulator_set_voltage(pfdev->regulator, pfdev->devfreq.cur_volt,
-				      pfdev->devfreq.cur_volt);
+		if (pfdev->regulator)
+			regulator_set_voltage(pfdev->regulator,
+					      pfdev->devfreq.cur_volt,
+					      pfdev->devfreq.cur_volt);
 		return err;
 	}
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing check for pfdev->regulator
  2019-08-22  9:32 ` [PATCH] drm/panfrost: Add missing check for pfdev->regulator Steven Price
@ 2019-08-23  1:52   ` Rob Herring
  2019-08-23  9:37       ` Steven Price
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-08-23  1:52 UTC (permalink / raw)
  To: Steven Price
  Cc: Daniel Vetter, David Airlie, Tomeu Vizoso, dri-devel,
	linux-kernel, Dan Carpenter

On Thu, Aug 22, 2019 at 4:32 AM Steven Price <steven.price@arm.com> wrote:
>
> When modifying panfrost_devfreq_target() to support a device without a
> regulator defined I missed the check on the error path. Let's add it.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Looks fine to me, but seems to be delayed getting to the list and
patchwork. I'm guessing you're not subscribed to dri-devel because all
your patches seem to get delayed.

Rob

>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index 710d903f8e0d..a1f5fa6a742a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -53,8 +53,10 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq,
>         if (err) {
>                 dev_err(dev, "Cannot set frequency %lu (%d)\n", target_rate,
>                         err);
> -               regulator_set_voltage(pfdev->regulator, pfdev->devfreq.cur_volt,
> -                                     pfdev->devfreq.cur_volt);
> +               if (pfdev->regulator)
> +                       regulator_set_voltage(pfdev->regulator,
> +                                             pfdev->devfreq.cur_volt,
> +                                             pfdev->devfreq.cur_volt);
>                 return err;
>         }
>
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing check for pfdev->regulator
  2019-08-23  1:52   ` Rob Herring
@ 2019-08-23  9:37       ` Steven Price
  0 siblings, 0 replies; 5+ messages in thread
From: Steven Price @ 2019-08-23  9:37 UTC (permalink / raw)
  To: Rob Herring
  Cc: Tomeu Vizoso, David Airlie, linux-kernel, dri-devel, Dan Carpenter

On 23/08/2019 02:52, Rob Herring wrote:
> On Thu, Aug 22, 2019 at 4:32 AM Steven Price <steven.price@arm.com> wrote:
>>
>> When modifying panfrost_devfreq_target() to support a device without a
>> regulator defined I missed the check on the error path. Let's add it.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator")
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Looks fine to me, but seems to be delayed getting to the list and
> patchwork. I'm guessing you're not subscribed to dri-devel because all
> your patches seem to get delayed.

Ah, yes I'm subscribed with a different email address - hopefully now
also subscribed with my @arm.com one.

Steve

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing check for pfdev->regulator
@ 2019-08-23  9:37       ` Steven Price
  0 siblings, 0 replies; 5+ messages in thread
From: Steven Price @ 2019-08-23  9:37 UTC (permalink / raw)
  To: Rob Herring
  Cc: David Airlie, dri-devel, Dan Carpenter, linux-kernel, Tomeu Vizoso

On 23/08/2019 02:52, Rob Herring wrote:
> On Thu, Aug 22, 2019 at 4:32 AM Steven Price <steven.price@arm.com> wrote:
>>
>> When modifying panfrost_devfreq_target() to support a device without a
>> regulator defined I missed the check on the error path. Let's add it.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator")
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Looks fine to me, but seems to be delayed getting to the list and
> patchwork. I'm guessing you're not subscribed to dri-devel because all
> your patches seem to get delayed.

Ah, yes I'm subscribed with a different email address - hopefully now
also subscribed with my @arm.com one.

Steve
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-23  9:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22  9:15 [bug report] drm/panfrost: Enable devfreq to work without regulator Dan Carpenter
2019-08-22  9:32 ` [PATCH] drm/panfrost: Add missing check for pfdev->regulator Steven Price
2019-08-23  1:52   ` Rob Herring
2019-08-23  9:37     ` Steven Price
2019-08-23  9:37       ` Steven Price

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.