All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment
@ 2019-08-22 20:19 Heinrich Schuchardt
  2019-08-23  3:22 ` Bin Meng
  2019-08-27  0:18 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2019-08-22 20:19 UTC (permalink / raw)
  To: u-boot

The assigned value NULL is overwritten before being used. Remove the
assignment.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 cmd/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/gpio.c b/cmd/gpio.c
index 53366f36e7..eff36ab2af 100644
--- a/cmd/gpio.c
+++ b/cmd/gpio.c
@@ -91,7 +91,7 @@ static int do_gpio_status(bool all, const char *gpio_name)

 		if (!gpio_name || !bank_name ||
 		    !strncasecmp(gpio_name, bank_name, banklen)) {
-			const char *p = NULL;
+			const char *p;
 			int offset;

 			p = gpio_name + banklen;
--
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment
  2019-08-22 20:19 [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment Heinrich Schuchardt
@ 2019-08-23  3:22 ` Bin Meng
  2019-08-27  0:18 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2019-08-23  3:22 UTC (permalink / raw)
  To: u-boot

On Fri, Aug 23, 2019 at 4:19 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The assigned value NULL is overwritten before being used. Remove the
> assignment.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  cmd/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment
  2019-08-22 20:19 [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment Heinrich Schuchardt
  2019-08-23  3:22 ` Bin Meng
@ 2019-08-27  0:18 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-08-27  0:18 UTC (permalink / raw)
  To: u-boot

On Thu, Aug 22, 2019 at 10:19:41PM +0200, Heinrich Schuchardt wrote:

> The assigned value NULL is overwritten before being used. Remove the
> assignment.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/44aa226f/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-27  0:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 20:19 [U-Boot] [PATCH 1/1] cmd: gpio: remove redundant assignment Heinrich Schuchardt
2019-08-23  3:22 ` Bin Meng
2019-08-27  0:18 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.