* [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()'
@ 2019-08-22 21:15 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2019-08-22 21:15 UTC (permalink / raw)
To: linus.walleij, airlied, daniel
Cc: dri-devel, linux-kernel, kernel-janitors, Christophe JAILLET
If we don't find any matching components, we should go through the error
handling path, in order to free some resources.
Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/mcde/mcde_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 9a09eba53182..5649887d2b90 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -484,7 +484,8 @@ static int mcde_probe(struct platform_device *pdev)
}
if (!match) {
dev_err(dev, "no matching components\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto clk_disable;
}
if (IS_ERR(match)) {
dev_err(dev, "could not create component match\n");
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()'
@ 2019-08-22 21:15 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2019-08-22 21:15 UTC (permalink / raw)
To: linus.walleij, airlied, daniel
Cc: dri-devel, linux-kernel, kernel-janitors, Christophe JAILLET
If we don't find any matching components, we should go through the error
handling path, in order to free some resources.
Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/mcde/mcde_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 9a09eba53182..5649887d2b90 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -484,7 +484,8 @@ static int mcde_probe(struct platform_device *pdev)
}
if (!match) {
dev_err(dev, "no matching components\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto clk_disable;
}
if (IS_ERR(match)) {
dev_err(dev, "could not create component match\n");
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()'
2019-08-22 21:15 ` Christophe JAILLET
@ 2019-08-26 20:07 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-08-26 20:07 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Dave Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS,
linux-kernel, kernel-janitors
On Thu, Aug 22, 2019 at 11:15 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> If we don't find any matching components, we should go through the error
> handling path, in order to free some resources.
>
> Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()'
@ 2019-08-26 20:07 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-08-26 20:07 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Dave Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS,
linux-kernel, kernel-janitors
On Thu, Aug 22, 2019 at 11:15 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> If we don't find any matching components, we should go through the error
> handling path, in order to free some resources.
>
> Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-26 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 21:15 [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()' Christophe JAILLET
2019-08-22 21:15 ` Christophe JAILLET
2019-08-26 20:07 ` Linus Walleij
2019-08-26 20:07 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.