All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Leontiev <scileont@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved
Date: Fri, 23 Aug 2019 17:40:43 +0300	[thread overview]
Message-ID: <20190823144043.26792-1-scileont@gmail.com> (raw)

From: Anton Leontiev <aleontiev@elvees.com>

Original commit c61d94d86035 ("pxe: implement fdtdir extlinux.conf tag")
states, that if FDT file cannot be retrieved then FDT packaged in
firmware should be used.

If FDT file cannot be retrieved and it is specified explicitly using
FDT keyword then the label is skipped. If it cannot be found in
FDTDIR then internal FDT is tried first.

Signed-off-by: Anton Leontiev <aleontiev@elvees.com>
---
 cmd/pxe.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/cmd/pxe.c b/cmd/pxe.c
index 2059975446..28390c114c 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -795,9 +795,13 @@ static int label_boot(cmd_tbl_t *cmdtp, struct pxe_label *label)
 			int err = get_relfile_envaddr(cmdtp, fdtfile, "fdt_addr_r");
 			free(fdtfilefree);
 			if (err < 0) {
-				printf("Skipping %s for failure retrieving fdt\n",
-						label->name);
-				goto cleanup;
+				bootm_argv[3] = NULL;
+
+				if (label->fdt) {
+					printf("Skipping %s for failure retrieving FDT\n",
+					       label->name);
+					goto cleanup;
+				}
 			}
 		} else {
 			bootm_argv[3] = NULL;
-- 
2.22.1

             reply	other threads:[~2019-08-23 14:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 14:40 Anton Leontiev [this message]
2019-08-26 15:59 ` [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved Stephen Warren
2019-08-29 11:20   ` Anton Leontiev
2019-08-29 20:35     ` Stephen Warren
2019-08-31 19:52       ` Anton Leontiev
2019-09-03 16:16         ` Stephen Warren
2019-09-03  7:52 ` [U-Boot] [PATCH v2] cmd: pxe: Use internal FDT if retrieving from FDTDIR fails Anton Leontiev
2019-09-03 16:18   ` Stephen Warren
2019-09-17  6:07     ` Anton Leontiev
2019-10-15  5:59   ` Anton Leontiev
2020-12-02 21:21   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823144043.26792-1-scileont@gmail.com \
    --to=scileont@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.