From: Anton Leontiev <scileont@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cmd: pxe: Use internal FDT if retrieving from FDTDIR fails
Date: Tue, 17 Sep 2019 09:07:37 +0300 [thread overview]
Message-ID: <CAPbbKZbsnmhDTSyE58=kqhhUUnXhpQUyBR6uKPyK0tVfKZ1O8Q@mail.gmail.com> (raw)
In-Reply-To: <3ed343ac-7727-ff83-e271-5f1699098f7e@wwwdotorg.org>
2019-09-03 19:18, Stephen Warren <swarren@wwwdotorg.org>:
> Is it possible/sensible to distinguish between "file not found" and
> "error during retrieval"? "File not found" indicates the case you care
> about, and continuing to use a built-in DT makes sense here. "Error
> during retrieval" indicates that the file was found, and hence really
> should be use, yet couldn't be due to download failure. In this case, I
> wonder if we shouldn't outright fail this boot option, just like the
> existing code does?
>
> But either way, I suppose this patch is reasonable.
As I see, for example from do_get_ext2(), currently it is not possible
to distinguish between "file not found" and "error during retrieval".
It seems possible to update all do_get_*() functions to check file
existence before retrieving, but it will require extensive testing and
I prefer this to be changed independently to current patch.
Best regards,
--
Anton Leontiev
next prev parent reply other threads:[~2019-09-17 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 14:40 [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved Anton Leontiev
2019-08-26 15:59 ` Stephen Warren
2019-08-29 11:20 ` Anton Leontiev
2019-08-29 20:35 ` Stephen Warren
2019-08-31 19:52 ` Anton Leontiev
2019-09-03 16:16 ` Stephen Warren
2019-09-03 7:52 ` [U-Boot] [PATCH v2] cmd: pxe: Use internal FDT if retrieving from FDTDIR fails Anton Leontiev
2019-09-03 16:18 ` Stephen Warren
2019-09-17 6:07 ` Anton Leontiev [this message]
2019-10-15 5:59 ` Anton Leontiev
2020-12-02 21:21 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPbbKZbsnmhDTSyE58=kqhhUUnXhpQUyBR6uKPyK0tVfKZ1O8Q@mail.gmail.com' \
--to=scileont@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.