From: "René van Dorst" <opensource@vdorst.com> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>, Nelson Chang <nelson.chang@mediatek.com>, "David S . Miller" <davem@davemloft.net>, Matthias Brugger <matthias.bgg@gmail.com>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, Frank Wunderlich <frank-w@public-files.de>, Stefan Roese <sr@denx.de> Subject: Re: [PATCH net-next v3 2/3] net: ethernet: mediatek: Re-add support SGMII Date: Sat, 24 Aug 2019 13:11:17 +0000 [thread overview] Message-ID: <20190824131117.Horde.vSCF_CQ5jCMHcSTWkh7Woxm@www.vdorst.com> (raw) In-Reply-To: <20190824092156.GD13294@shell.armlinux.org.uk> Hi Russell, Quoting Russell King - ARM Linux admin <linux@armlinux.org.uk>: > On Fri, Aug 23, 2019 at 03:45:15PM +0200, René van Dorst wrote: >> + switch (state->interface) { >> + case PHY_INTERFACE_MODE_SGMII: >> + phylink_set(mask, 10baseT_Half); >> + phylink_set(mask, 10baseT_Full); >> + phylink_set(mask, 100baseT_Half); >> + phylink_set(mask, 100baseT_Full); > > You also want 1000baseX_Full here - the connected PHY could have a fiber > interface on it. Ok, I shall add that mode too. > >> + /* fall through */ >> + case PHY_INTERFACE_MODE_TRGMII: >> phylink_set(mask, 1000baseT_Full); > > I don't know enough about this interface type to comment whether it > should support 1000baseX_Full - if this is connected to a PHY that may > support fiber, then it ought to set it. Mediatek calls it Turbo RGMII. It is a overclock version of RGMII mode. It is used between first GMAC and port 6 of the mt7530 switch. Can be used with an internal and an external mt7530 switch. TRGMII speed are: * mt7621: 1200Mbit * mt7623: 2000Mbit and 2600Mbit. I think that TRGMII is only used in a fixed-link situation in combination with a mt7530 switch and running and maximum speed/full duplex. So reporting 1000baseT_Full seems to me the right option. > >> + break; >> + case PHY_INTERFACE_MODE_2500BASEX: >> + phylink_set(mask, 2500baseX_Full); >> + /* fall through */ >> + case PHY_INTERFACE_MODE_1000BASEX: >> + phylink_set(mask, 1000baseX_Full); > > Both should be set. The reasoning here is that if you have a > Fiberchannel 4Gbaud SFP plugged in and connected directly to the > MAC, it can operate at either 2500Base-X or 1000Base-X. If we > decide to operate at 2500Base-X, then PHY_INTERFACE_MODE_2500BASEX > will be chosen. Otherwise, PHY_INTERFACE_MODE_1000BASEX will be > used. > > The user can use ethtool to control which interface mode is used > by adjusting the advertise mask and/or placing the interface in > manual mode and setting the speed directly. This will change > the PHY_INTERFACE_MODE_xxxxBASEX (via phylink_helper_basex_speed()) > between the two settings. > > If we lose 2500baseX_Full when 1000Base-X is selected, the user > will not be able to go back to 2500Base-X mode. > > Yes, it's a little confusing and has slightly different rules > from the other modes - partly due to phylink_helper_basex_speed(). > These are the only interface modes that we dynamically switch > between depending on the settings that the user configures via > ethtool. Thanks for this extra information. I made a list for each mode what that mode should report back when chosen. PHY_INTERFACE_MODE_SGMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Full 1000baseX_Full PHY_INTERFACE_MODE_1000BASEX: PHY_INTERFACE_MODE_2500BASEX: 1000baseX_Full 2500baseX_Full PHY_INTERFACE_MODE_TRGMII: 1000baseT_Full PHY_INTERFACE_MODE_RGMII: PHY_INTERFACE_MODE_RGMII_ID: PHY_INTERFACE_MODE_RGMII_RXID: PHY_INTERFACE_MODE_RGMII_TXID: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full 1000baseX_Full PHY_INTERFACE_MODE_GMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full PHY_INTERFACE_MODE_MII: PHY_INTERFACE_MODE_RMII: PHY_INTERFACE_MODE_REVMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full case PHY_INTERFACE_MODE_NA: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full 1000baseX_Full 2500baseX_Full I think this is the full list. Or do I miss something? Greats, René > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up
WARNING: multiple messages have this Message-ID (diff)
From: "René van Dorst" <opensource@vdorst.com> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Nelson Chang <nelson.chang@mediatek.com>, Frank Wunderlich <frank-w@public-files.de>, netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin <john@phrozen.org>, Matthias Brugger <matthias.bgg@gmail.com>, Stefan Roese <sr@denx.de>, "David S . Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 2/3] net: ethernet: mediatek: Re-add support SGMII Date: Sat, 24 Aug 2019 13:11:17 +0000 [thread overview] Message-ID: <20190824131117.Horde.vSCF_CQ5jCMHcSTWkh7Woxm@www.vdorst.com> (raw) In-Reply-To: <20190824092156.GD13294@shell.armlinux.org.uk> Hi Russell, Quoting Russell King - ARM Linux admin <linux@armlinux.org.uk>: > On Fri, Aug 23, 2019 at 03:45:15PM +0200, René van Dorst wrote: >> + switch (state->interface) { >> + case PHY_INTERFACE_MODE_SGMII: >> + phylink_set(mask, 10baseT_Half); >> + phylink_set(mask, 10baseT_Full); >> + phylink_set(mask, 100baseT_Half); >> + phylink_set(mask, 100baseT_Full); > > You also want 1000baseX_Full here - the connected PHY could have a fiber > interface on it. Ok, I shall add that mode too. > >> + /* fall through */ >> + case PHY_INTERFACE_MODE_TRGMII: >> phylink_set(mask, 1000baseT_Full); > > I don't know enough about this interface type to comment whether it > should support 1000baseX_Full - if this is connected to a PHY that may > support fiber, then it ought to set it. Mediatek calls it Turbo RGMII. It is a overclock version of RGMII mode. It is used between first GMAC and port 6 of the mt7530 switch. Can be used with an internal and an external mt7530 switch. TRGMII speed are: * mt7621: 1200Mbit * mt7623: 2000Mbit and 2600Mbit. I think that TRGMII is only used in a fixed-link situation in combination with a mt7530 switch and running and maximum speed/full duplex. So reporting 1000baseT_Full seems to me the right option. > >> + break; >> + case PHY_INTERFACE_MODE_2500BASEX: >> + phylink_set(mask, 2500baseX_Full); >> + /* fall through */ >> + case PHY_INTERFACE_MODE_1000BASEX: >> + phylink_set(mask, 1000baseX_Full); > > Both should be set. The reasoning here is that if you have a > Fiberchannel 4Gbaud SFP plugged in and connected directly to the > MAC, it can operate at either 2500Base-X or 1000Base-X. If we > decide to operate at 2500Base-X, then PHY_INTERFACE_MODE_2500BASEX > will be chosen. Otherwise, PHY_INTERFACE_MODE_1000BASEX will be > used. > > The user can use ethtool to control which interface mode is used > by adjusting the advertise mask and/or placing the interface in > manual mode and setting the speed directly. This will change > the PHY_INTERFACE_MODE_xxxxBASEX (via phylink_helper_basex_speed()) > between the two settings. > > If we lose 2500baseX_Full when 1000Base-X is selected, the user > will not be able to go back to 2500Base-X mode. > > Yes, it's a little confusing and has slightly different rules > from the other modes - partly due to phylink_helper_basex_speed(). > These are the only interface modes that we dynamically switch > between depending on the settings that the user configures via > ethtool. Thanks for this extra information. I made a list for each mode what that mode should report back when chosen. PHY_INTERFACE_MODE_SGMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Full 1000baseX_Full PHY_INTERFACE_MODE_1000BASEX: PHY_INTERFACE_MODE_2500BASEX: 1000baseX_Full 2500baseX_Full PHY_INTERFACE_MODE_TRGMII: 1000baseT_Full PHY_INTERFACE_MODE_RGMII: PHY_INTERFACE_MODE_RGMII_ID: PHY_INTERFACE_MODE_RGMII_RXID: PHY_INTERFACE_MODE_RGMII_TXID: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full 1000baseX_Full PHY_INTERFACE_MODE_GMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full PHY_INTERFACE_MODE_MII: PHY_INTERFACE_MODE_RMII: PHY_INTERFACE_MODE_REVMII: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full case PHY_INTERFACE_MODE_NA: 10baseT_Half 10baseT_Full 100baseT_Half 100baseT_Full 1000baseT_Half 1000baseT_Full 1000baseX_Full 2500baseX_Full I think this is the full list. Or do I miss something? Greats, René > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-24 13:11 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 13:45 [PATCH net-next v3 0/3] net: ethernet: mediatek: convert to PHYLINK René van Dorst 2019-08-23 13:45 ` René van Dorst 2019-08-23 13:45 ` [PATCH net-next v3 1/3] net: ethernet: mediatek: Add basic PHYLINK support René van Dorst 2019-08-23 13:45 ` René van Dorst 2019-08-24 9:11 ` Russell King - ARM Linux admin 2019-08-24 9:11 ` Russell King - ARM Linux admin 2019-08-24 12:33 ` René van Dorst 2019-08-24 12:33 ` René van Dorst 2019-08-23 13:45 ` [PATCH net-next v3 2/3] net: ethernet: mediatek: Re-add support SGMII René van Dorst 2019-08-23 13:45 ` René van Dorst 2019-08-24 9:21 ` Russell King - ARM Linux admin 2019-08-24 9:21 ` Russell King - ARM Linux admin 2019-08-24 13:11 ` René van Dorst [this message] 2019-08-24 13:11 ` René van Dorst 2019-08-24 13:32 ` Russell King - ARM Linux admin 2019-08-24 13:32 ` Russell King - ARM Linux admin 2019-08-25 11:41 ` René van Dorst 2019-08-25 11:41 ` René van Dorst 2019-08-23 13:45 ` [PATCH net-next v3 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API René van Dorst 2019-08-23 13:45 ` René van Dorst 2019-08-23 17:56 ` Aw: [PATCH net-next v3 0/3] net: ethernet: mediatek: convert to PHYLINK Frank Wunderlich 2019-08-23 17:56 ` Frank Wunderlich 2019-08-23 17:56 ` Frank Wunderlich 2019-08-24 7:41 ` René van Dorst 2019-08-24 7:41 ` René van Dorst 2019-08-24 7:41 ` René van Dorst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190824131117.Horde.vSCF_CQ5jCMHcSTWkh7Woxm@www.vdorst.com \ --to=opensource@vdorst.com \ --cc=davem@davemloft.net \ --cc=frank-w@public-files.de \ --cc=john@phrozen.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=nelson.chang@mediatek.com \ --cc=netdev@vger.kernel.org \ --cc=sean.wang@mediatek.com \ --cc=sr@denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.