From: Jacopo Mondi <jacopo@jmondi.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
tfiga@google.com
Cc: Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org (open list:MEDIA INPUT
INFRASTRUCTURE (V4L/DVB))
Subject: [PATCH v2 07/10] media: i2c: ov5670: Register controls from firmware
Date: Tue, 27 Aug 2019 11:23:35 +0200 [thread overview]
Message-ID: <20190827092339.8858-10-jacopo@jmondi.org> (raw)
In-Reply-To: <20190827092339.8858-1-jacopo@jmondi.org>
Use the newly introduced helper to parse properties from firmware and
register the associated v4l2 control.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
drivers/media/i2c/ov5670.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 041fcbb4eebd..2bc57e85f721 100644
--- a/drivers/media/i2c/ov5670.c
+++ b/drivers/media/i2c/ov5670.c
@@ -7,6 +7,7 @@
#include <linux/pm_runtime.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
+#include <media/v4l2-fwnode.h>
#define OV5670_REG_CHIP_ID 0x300a
#define OV5670_CHIP_ID 0x005670
@@ -2059,6 +2060,7 @@ static const struct v4l2_ctrl_ops ov5670_ctrl_ops = {
/* Initialize control handlers */
static int ov5670_init_controls(struct ov5670 *ov5670)
{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
struct v4l2_ctrl_handler *ctrl_hdlr;
s64 vblank_max;
s64 vblank_def;
@@ -2129,6 +2131,11 @@ static int ov5670_init_controls(struct ov5670 *ov5670)
goto error;
}
+ ret = v4l2_fwnode_register_controls(dev_fwnode(&client->dev),
+ ctrl_hdlr, &ov5670_ctrl_ops);
+ if (ret)
+ goto error;
+
ov5670->sd.ctrl_handler = ctrl_hdlr;
return 0;
--
2.23.0
next prev parent reply other threads:[~2019-08-27 9:22 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:23 [PATCH v2 00/10] media: Report camera sensor properties Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 01/10] media: dt-bindings: Document 'location' property Jacopo Mondi
2019-08-27 9:23 ` Jacopo Mondi
2019-08-27 12:21 ` Laurent Pinchart
2019-08-27 12:21 ` Laurent Pinchart
2019-08-29 12:46 ` Jacopo Mondi
2019-08-29 12:46 ` Jacopo Mondi
2019-09-02 13:38 ` Rob Herring
2019-09-02 13:38 ` Rob Herring
2019-09-02 16:40 ` Jacopo Mondi
2019-09-02 16:40 ` Jacopo Mondi
2019-09-02 16:49 ` Laurent Pinchart
2019-09-02 16:49 ` Laurent Pinchart
2019-09-02 19:48 ` Jacopo Mondi
2019-09-02 19:48 ` Jacopo Mondi
2019-09-03 13:22 ` Laurent Pinchart
2019-09-03 13:22 ` Laurent Pinchart
2019-09-12 12:51 ` Mauro Carvalho Chehab
2019-09-12 16:36 ` Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 02/10] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_LOCATION Jacopo Mondi
2019-08-27 12:50 ` Laurent Pinchart
2019-08-29 12:47 ` Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 03/10] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION Jacopo Mondi
2019-08-27 12:51 ` Laurent Pinchart
2019-09-02 11:20 ` Jacopo Mondi
2019-09-02 16:43 ` Laurent Pinchart
2019-09-03 4:16 ` Tomasz Figa
2019-09-03 13:17 ` Laurent Pinchart
2019-09-03 15:22 ` Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 04/10] media: v4l2-ctrl: Add V4L2_CID_CAMERA_SENSOR_LOCATION Jacopo Mondi
2019-08-27 12:53 ` Laurent Pinchart
2019-08-27 9:23 ` [PATCH v2 04/10] media: v4l2-ctrls: " Jacopo Mondi
2019-08-27 9:36 ` Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 05/10] media: v4l2-ctrl: Add V4L2_CID_CAMERA_SENSOR_ROTATION Jacopo Mondi
2019-08-27 13:07 ` Laurent Pinchart
2019-08-27 9:23 ` [PATCH v2 05/10] media: v4l2-ctrls: " Jacopo Mondi
2019-08-27 9:36 ` Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 06/10] media: v4l2-fwnode: Add helper to register controls from fw Jacopo Mondi
2019-08-27 13:16 ` Laurent Pinchart
2019-08-29 12:55 ` Jacopo Mondi
2019-08-29 10:31 ` Hans Verkuil
2019-08-29 12:45 ` Jacopo Mondi
2019-08-29 13:04 ` Hans Verkuil
2019-08-29 15:05 ` Laurent Pinchart
2019-08-29 15:32 ` Hans Verkuil
2019-09-02 9:39 ` Jacopo Mondi
2019-09-02 9:46 ` Laurent Pinchart
2019-08-27 9:23 ` Jacopo Mondi [this message]
2019-08-27 9:23 ` [PATCH v2 08/10] media: i2c: ov13858: Register controls from firmware Jacopo Mondi
2019-08-27 9:23 ` [PATCH v2 09/10] media: i2c: ov5670: Report native size and crop bounds Jacopo Mondi
2019-08-29 10:20 ` Hans Verkuil
2019-08-29 12:40 ` Jacopo Mondi
2019-08-29 12:55 ` Hans Verkuil
2019-08-29 13:18 ` Jacopo Mondi
2019-08-29 13:39 ` Hans Verkuil
2019-08-29 16:43 ` Jacopo Mondi
2019-09-02 10:05 ` Laurent Pinchart
2019-09-03 13:06 ` Sakari Ailus
2019-09-03 16:49 ` Jacopo Mondi
2019-09-26 8:11 ` Hans Verkuil
2019-09-26 18:56 ` Jacopo Mondi
2019-10-07 14:23 ` Tomasz Figa
2019-08-27 9:23 ` [PATCH v2 10/10] media: i2c: ov13858: " Jacopo Mondi
2019-08-27 9:23 ` [DO NOT MERGE] mb/google/poppy/variant/soraka: Add camera properties Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827092339.8858-10-jacopo@jmondi.org \
--to=jacopo@jmondi.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.