[PATCH] lpfc: Raise config max for lpfc_fcp_mq_threshold variable

[PATCH] lpfc: Raise config max for lpfc_fcp_mq_threshold variable

[James Smart]

Raise the config max for lpfc_fcp_mq_threshold variable to 256.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
CC: Hannes Reinecke <hare@suse.de>

---
Martin, this fix applies 5.3/scsi-fixes patch:
  scsi: lpfc: Mitigate high memory pre-allocation by SCSI-MQ
---
 drivers/scsi/lpfc/lpfc_attr.c | 2 +-
 drivers/scsi/lpfc/lpfc_sli4.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 491a999056aa..25aa7a53d255 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -5713,7 +5713,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2,
  *      0    = Set nr_hw_queues by the number of CPUs or HW queues.
  *      1,128 = Manually specify the maximum nr_hw_queue value to be set,
  *
- * Value range is [0,128]. Default value is 8.
+ * Value range is [0,256]. Default value is 8.
  */
 LPFC_ATTR_R(fcp_mq_threshold, LPFC_FCP_MQ_THRESHOLD_DEF,
 	    LPFC_FCP_MQ_THRESHOLD_MIN, LPFC_FCP_MQ_THRESHOLD_MAX,
diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h
index 2d1823e449aa..a4be83d1f37e 100644
--- a/drivers/scsi/lpfc/lpfc_sli4.h
+++ b/drivers/scsi/lpfc/lpfc_sli4.h
@@ -46,7 +46,7 @@
 
 /* FCP MQ queue count limiting */
 #define LPFC_FCP_MQ_THRESHOLD_MIN	0
-#define LPFC_FCP_MQ_THRESHOLD_MAX	128
+#define LPFC_FCP_MQ_THRESHOLD_MAX	256
 #define LPFC_FCP_MQ_THRESHOLD_DEF	8
 
 /* Common buffer size to accomidate SCSI and NVME IO buffers */
-- 
2.13.7

Re: [PATCH] lpfc: Raise config max for lpfc_fcp_mq_threshold variable

[Hannes Reinecke]

On 8/27/19 11:28 PM, James Smart wrote:
> Raise the config max for lpfc_fcp_mq_threshold variable to 256.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> CC: Hannes Reinecke <hare@suse.de>
> 
> ---
> Martin, this fix applies 5.3/scsi-fixes patch:
>    scsi: lpfc: Mitigate high memory pre-allocation by SCSI-MQ
> ---
>   drivers/scsi/lpfc/lpfc_attr.c | 2 +-
>   drivers/scsi/lpfc/lpfc_sli4.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index 491a999056aa..25aa7a53d255 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -5713,7 +5713,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2,
>    *      0    = Set nr_hw_queues by the number of CPUs or HW queues.
>    *      1,128 = Manually specify the maximum nr_hw_queue value to be set,
>    *
> - * Value range is [0,128]. Default value is 8.
> + * Value range is [0,256]. Default value is 8.
>    */
>   LPFC_ATTR_R(fcp_mq_threshold, LPFC_FCP_MQ_THRESHOLD_DEF,
>   	    LPFC_FCP_MQ_THRESHOLD_MIN, LPFC_FCP_MQ_THRESHOLD_MAX,
> diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h
> index 2d1823e449aa..a4be83d1f37e 100644
> --- a/drivers/scsi/lpfc/lpfc_sli4.h
> +++ b/drivers/scsi/lpfc/lpfc_sli4.h
> @@ -46,7 +46,7 @@
>   
>   /* FCP MQ queue count limiting */
>   #define LPFC_FCP_MQ_THRESHOLD_MIN	0
> -#define LPFC_FCP_MQ_THRESHOLD_MAX	128
> +#define LPFC_FCP_MQ_THRESHOLD_MAX	256
>   #define LPFC_FCP_MQ_THRESHOLD_DEF	8
>   
>   /* Common buffer size to accomidate SCSI and NVME IO buffers */
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@suse.de                              +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

Re: [PATCH] lpfc: Raise config max for lpfc_fcp_mq_threshold variable

[Martin K. Petersen]

James,

> Raise the config max for lpfc_fcp_mq_threshold variable to 256.

Not a big fan of these magic values.

Applied to 5.3/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering