[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Yang Xu]

Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
these cases have been added into runtests/numa, but forget to add it
in runtest/syscalls.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 runtest/syscalls | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/runtest/syscalls b/runtest/syscalls
index c41ba2a0d..1694ef147 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1177,6 +1177,11 @@ setitimer01 setitimer01
 setitimer02 setitimer02
 setitimer03 setitimer03
 
+set_mempolicy01 set_mempolicy01
+set_mempolicy02 set_mempolicy02
+set_mempolicy03 set_mempolicy03
+set_mempolicy04 set_mempolicy04
+
 setns01 setns01
 setns02 setns02
 
-- 
2.18.1

[LTP] [PATCH 2/2] runtest/numa: add migrate_pages*

[Yang Xu]

Since migrate_pages must depend on numa, add it into
runtest/numa.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 runtest/numa | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/runtest/numa b/runtest/numa
index 7885be90c..45d15e768 100644
--- a/runtest/numa
+++ b/runtest/numa
@@ -12,6 +12,10 @@ move_pages10 move_pages10
 move_pages11 move_pages11
 move_pages12 move_pages12
 
+migrate_pages01 migrate_pages01
+migrate_pages02 migrate_pages02
+migrate_pages03 migrate_pages03
+
 set_mempolicy01 set_mempolicy01
 set_mempolicy02 set_mempolicy02
 set_mempolicy03 set_mempolicy03
-- 
2.18.1

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Xiao Yang]

Hi,

This patch set looks good to me.
Just one comment, migrate_pages should be added before move_pages in 
alphabetical order.

Reviewed-by: Xiao Yang <ice_yangxiao@163.com>

Best Regards,
Xiao Yang
On 2019/08/28 18:14, Yang Xu wrote:
> Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
> these cases have been added into runtests/numa, but forget to add it
> in runtest/syscalls.
>
> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> ---
>   runtest/syscalls | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index c41ba2a0d..1694ef147 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -1177,6 +1177,11 @@ setitimer01 setitimer01
>   setitimer02 setitimer02
>   setitimer03 setitimer03
>
> +set_mempolicy01 set_mempolicy01
> +set_mempolicy02 set_mempolicy02
> +set_mempolicy03 set_mempolicy03
> +set_mempolicy04 set_mempolicy04
> +
>   setns01 setns01
>   setns02 setns02
>

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Petr Vorel]

Hi,

> Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
> these cases have been added into runtests/numa, but forget to add it
> in runtest/syscalls.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
>  runtest/syscalls | 5 +++++
>  1 file changed, 5 insertions(+)

> diff --git a/runtest/syscalls b/runtest/syscalls
> index c41ba2a0d..1694ef147 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -1177,6 +1177,11 @@ setitimer01 setitimer01
>  setitimer02 setitimer02
>  setitimer03 setitimer03

> +set_mempolicy01 set_mempolicy01
> +set_mempolicy02 set_mempolicy02
> +set_mempolicy03 set_mempolicy03
> +set_mempolicy04 set_mempolicy04
> +
>  setns01 setns01
>  setns02 setns02

Wouldn't be better to move all NUMA tests out of syscalls?
Syscalls are big already.

BTW I'm looking forward to the new testrunner [1][2], which also solve problem
of runtest files :)

Kind regards,
Petr

[1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
[2] https://github.com/metan-ucw/ltp/tree/master/docparse

[LTP] [PATCH 2/2] runtest/numa: add migrate_pages*

[Petr Vorel]

Hi Xu,

> Since migrate_pages must depend on numa, add it into
> runtest/numa.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Thanks for the patch, merged.

Kind regards,
Petr

[LTP] [PATCH 2/2] runtest/numa: add migrate_pages*

[Xiao Yang]

On 2019/08/30 4:41, Petr Vorel wrote:
> Hi Xu,
>
>> Since migrate_pages must depend on numa, add it into
>> runtest/numa.
>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> Thanks for the patch, merged.
Hi Petr,

Why don't sort numa tests alphabetically as my replied?

Best Regards,
Xiao Yang
> Kind regards,
> Petr
>

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Xiao Yang]

On 2019/08/30 4:38, Petr Vorel wrote:
> Hi,
>
>> Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
>> these cases have been added into runtests/numa, but forget to add it
>> in runtest/syscalls.
>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>> ---
>>   runtest/syscalls | 5 +++++
>>   1 file changed, 5 insertions(+)
>> diff --git a/runtest/syscalls b/runtest/syscalls
>> index c41ba2a0d..1694ef147 100644
>> --- a/runtest/syscalls
>> +++ b/runtest/syscalls
>> @@ -1177,6 +1177,11 @@ setitimer01 setitimer01
>>   setitimer02 setitimer02
>>   setitimer03 setitimer03
>> +set_mempolicy01 set_mempolicy01
>> +set_mempolicy02 set_mempolicy02
>> +set_mempolicy03 set_mempolicy03
>> +set_mempolicy04 set_mempolicy04
>> +
>>   setns01 setns01
>>   setns02 setns02
> Wouldn't be better to move all NUMA tests out of syscalls?
> Syscalls are big already.
Hi Petr,

all NUMA tests actually verify the functionality of 
syscalls(move_pages(2), set_mempolicy(2), etc)
so I think that they can be added into syscalls group.

PS: If someone want to run syscalls from LTP as many as possible, they 
just need to run syscalls group directly.

Best Regards,
Xiao Yang
> BTW I'm looking forward to the new testrunner [1][2], which also solve problem
> of runtest files :)
>
> Kind regards,
> Petr
>
> [1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
> [2] https://github.com/metan-ucw/ltp/tree/master/docparse
>
>
> .
>

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Yang Xu]

on 2019/08/30 10:04, Xiao Yang wrote:

> On 2019/08/30 4:38, Petr Vorel wrote:
>> Hi,
>>> Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
>>> these cases have been added into runtests/numa, but forget to add it
>>> in runtest/syscalls.
>>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
>> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>>> ---
>>>    runtest/syscalls | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>> index c41ba2a0d..1694ef147 100644
>>> --- a/runtest/syscalls
>>> +++ b/runtest/syscalls
>>> @@ -1177,6 +1177,11 @@ setitimer01 setitimer01
>>>    setitimer02 setitimer02
>>>    setitimer03 setitimer03
>>> +set_mempolicy01 set_mempolicy01
>>> +set_mempolicy02 set_mempolicy02
>>> +set_mempolicy03 set_mempolicy03
>>> +set_mempolicy04 set_mempolicy04
>>> +
>>>    setns01 setns01
>>>    setns02 setns02
>> Wouldn't be better to move all NUMA tests out of syscalls?
>> Syscalls are big already.
> Hi Petr,
> all NUMA tests actually verify the functionality of
> syscalls(move_pages(2), set_mempolicy(2), etc)
> so I think that they can be added into syscalls group.
> PS: If someone want to run syscalls from LTP as many as possible, they
> just need to run syscalls group directly.
+1 , set_mempolicy syscall should belong to numa and syscall group.

> Best Regards,
> Xiao Yang
>> BTW I'm looking forward to the new testrunner [1][2], which also solve problem
>> of runtest files :)
Hi Petr

For new testrunner,  I think it is a good improvement to save test time by parallel running case.
I am also looking forward to it.

>> Kind regards,
>> Petr
>> [1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
>> [2] https://github.com/metan-ucw/ltp/tree/master/docparse
>> .
> .

[LTP] [PATCH 2/2] runtest/numa: add migrate_pages*

[Petr Vorel]

Hi Yang,

> On 2019/08/30 4:41, Petr Vorel wrote:
> > Hi Xu,

> > > Since migrate_pages must depend on numa, add it into
> > > runtest/numa.
> > > Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> > Thanks for the patch, merged.
> Hi Petr,

> Why don't sort numa tests alphabetically as my replied?
I'm sorry. I overlooked it as you put your commend to 1st commit
(this is a second commit). Feel free to fix it or I'll do it later today.

BTW I suggest also sort alphabetically Numa-testcases numa01.sh
and rename it to numa_testcases numa01.sh

Kind regards,
Petr

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Petr Vorel]

Hi Yang,

> On 2019/08/30 4:38, Petr Vorel wrote:
> > Hi,

> > > Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"),
> > > these cases have been added into runtests/numa, but forget to add it
> > > in runtest/syscalls.
> > > Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> > Reviewed-by: Petr Vorel<pvorel@suse.cz>
> > > ---
> > >   runtest/syscalls | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > > diff --git a/runtest/syscalls b/runtest/syscalls
> > > index c41ba2a0d..1694ef147 100644
> > > --- a/runtest/syscalls
> > > +++ b/runtest/syscalls
> > > @@ -1177,6 +1177,11 @@ setitimer01 setitimer01
> > >   setitimer02 setitimer02
> > >   setitimer03 setitimer03
> > > +set_mempolicy01 set_mempolicy01
> > > +set_mempolicy02 set_mempolicy02
> > > +set_mempolicy03 set_mempolicy03
> > > +set_mempolicy04 set_mempolicy04
> > > +
> > >   setns01 setns01
> > >   setns02 setns02
> > Wouldn't be better to move all NUMA tests out of syscalls?
> > Syscalls are big already.
> Hi Petr,

> all NUMA tests actually verify the functionality of syscalls(move_pages(2),
> set_mempolicy(2), etc)
> so I think that they can be added into syscalls group.

> PS: If someone want to run syscalls from LTP as many as possible, they just
> need to run syscalls group directly.
OK, ack.

PS: I'd prefer syscalls to be just includes of other runtests (otherwise we keep
forgetting to add testcases), but that won't happen until docparse & new runner
are released.


Kind regards,
Petr

[LTP] [PATCH 2/2] runtest/numa: add migrate_pages*

[Petr Vorel]

Hi Yang,

> Hi Petr,

> Why don't sort numa tests alphabetically as my replied?
Fix merged. Thanks for reporting it.

Kind regards,
Petr

[LTP] [PATCH 1/2] runtest/syscalls: add set_mempolicy*

[Petr Vorel]

Hi,

> > PS: If someone want to run syscalls from LTP as many as possible, they
> > just need to run syscalls group directly.
> +1 , set_mempolicy syscall should belong to numa and syscall group.
OK, merged. + I sorted them properly, with other set_* tests in that commit.

Kind regards,
Petr