* [PATCH][V2] autofs: remove redundant assignment to variable err
@ 2019-09-01 15:35 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2019-09-01 15:35 UTC (permalink / raw)
To: Ian Kent, autofs; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable err is being assigned a value that is never read and
is being re-assigned a little later on. The assignment is redundant
and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: Fix spelling mistake "Unused"
---
fs/autofs/dev-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs/dev-ioctl.c b/fs/autofs/dev-ioctl.c
index a3cdb0036c5d..65d84b4d4464 100644
--- a/fs/autofs/dev-ioctl.c
+++ b/fs/autofs/dev-ioctl.c
@@ -422,7 +422,7 @@ static int autofs_dev_ioctl_requester(struct file *fp,
struct autofs_info *ino;
struct path path;
dev_t devid;
- int err = -ENOENT;
+ int err;
/* param->path has been checked in validate_dev_ioctl() */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH][V2] autofs: remove redundant assignment to variable err
@ 2019-09-01 15:35 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2019-09-01 15:35 UTC (permalink / raw)
To: Ian Kent, autofs; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable err is being assigned a value that is never read and
is being re-assigned a little later on. The assignment is redundant
and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: Fix spelling mistake "Unused"
---
fs/autofs/dev-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs/dev-ioctl.c b/fs/autofs/dev-ioctl.c
index a3cdb0036c5d..65d84b4d4464 100644
--- a/fs/autofs/dev-ioctl.c
+++ b/fs/autofs/dev-ioctl.c
@@ -422,7 +422,7 @@ static int autofs_dev_ioctl_requester(struct file *fp,
struct autofs_info *ino;
struct path path;
dev_t devid;
- int err = -ENOENT;
+ int err;
/* param->path has been checked in validate_dev_ioctl() */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-01 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-01 15:35 [PATCH][V2] autofs: remove redundant assignment to variable err Colin King
2019-09-01 15:35 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.