From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: festevam@gmail.com, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
shengjiu.wang@nxp.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, timur@kernel.org,
gabrielcsmo@gmail.com, NXP Linux Team <linux-imx@nxp.com>,
Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>
Subject: Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode
Date: Mon, 2 Sep 2019 13:39:44 +0100 [thread overview]
Message-ID: <20190902123944.GB5819@sirena.co.uk> (raw)
In-Reply-To: <20190830225514.5283-1-daniel.baluta@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Sat, Aug 31, 2019 at 01:55:14AM +0300, Daniel Baluta wrote:
> Fix this by setting CHMOD to Output Mode so that pins will output zero
> when slots are masked or channels are disabled.
This patch seems to do this unconditionally. This is fine for
configurations where the SoC is the only thing driving the bus but will
mean that for TDM configurations where something else also drives some
of the slots we'll end up with both devices driving simultaneously. The
safest thing would be to set this only if TDM isn't configured.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, shengjiu.wang@nxp.com,
linux-kernel@vger.kernel.org, nicoleotsuka@gmail.com,
NXP Linux Team <linux-imx@nxp.com>,
Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>,
gabrielcsmo@gmail.com, festevam@gmail.com
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode
Date: Mon, 2 Sep 2019 13:39:44 +0100 [thread overview]
Message-ID: <20190902123944.GB5819@sirena.co.uk> (raw)
In-Reply-To: <20190830225514.5283-1-daniel.baluta@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 531 bytes --]
On Sat, Aug 31, 2019 at 01:55:14AM +0300, Daniel Baluta wrote:
> Fix this by setting CHMOD to Output Mode so that pins will output zero
> when slots are masked or channels are disabled.
This patch seems to do this unconditionally. This is fine for
configurations where the SoC is the only thing driving the bus but will
mean that for TDM configurations where something else also drives some
of the slots we'll end up with both devices driving simultaneously. The
safest thing would be to set this only if TDM isn't configured.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-02 12:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 22:55 [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode Daniel Baluta
2019-08-30 22:55 ` [alsa-devel] " Daniel Baluta
2019-08-30 22:55 ` Daniel Baluta
2019-09-01 19:49 ` Cosmin-Gabriel Samoila
2019-09-01 19:49 ` [alsa-devel] " Cosmin-Gabriel Samoila
2019-09-02 12:39 ` Mark Brown [this message]
2019-09-02 12:39 ` Mark Brown
2019-09-02 13:35 ` Daniel Baluta
2019-09-02 13:35 ` [alsa-devel] " Daniel Baluta
2019-09-02 15:52 ` Mark Brown
2019-09-02 15:52 ` [alsa-devel] " Mark Brown
2020-09-03 3:09 Shengjiu Wang
2020-09-03 3:40 ` Nicolin Chen
2020-09-03 3:40 ` Nicolin Chen
2020-09-03 3:40 ` Nicolin Chen
2020-09-03 5:38 ` Shengjiu Wang
2020-09-03 5:38 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902123944.GB5819@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=gabrielcsmo@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.