From: Thierry Reding <thierry.reding@gmail.com> To: Robin Murphy <robin.murphy@arm.com> Cc: Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Will Deacon <will@kernel.org>, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iommu: dma: Use of_iommu_get_resv_regions() Date: Mon, 2 Sep 2019 16:52:45 +0200 [thread overview] Message-ID: <20190902145245.GC1445@ulmo> (raw) In-Reply-To: <1caeaaa0-c5aa-b630-6d42-055b26764f40@arm.com> [-- Attachment #1: Type: text/plain, Size: 2661 bytes --] On Mon, Sep 02, 2019 at 03:22:35PM +0100, Robin Murphy wrote: > On 29/08/2019 12:14, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > For device tree nodes, use the standard of_iommu_get_resv_regions() > > implementation to obtain the reserved memory regions associated with a > > device. > > This covers the window between iommu_probe_device() setting up a default > domain and the device's driver finally probing and taking control, but > iommu_probe_device() represents the point that the IOMMU driver first knows > about this device - there's still a window from whenever the IOMMU driver > itself probed up to here where the "unidentified" traffic may have already > been disrupted. Some IOMMU drivers have no option but to make the necessary > configuration during their own probe routine, at which point a struct device > for the display/etc. endpoint may not even exist yet. Yeah, I think I'm actually running into this issue with the ARM SMMU driver. The above works fine with the Tegra SMMU driver, though, because it doesn't touch the SMMU configuration until a device is attached to a domain. For anything earlier than iommu_probe_device(), I don't see a way of doing this generically. I've been working on a prototype to make these reserved memory regions early on for ARM SMMU but I've been failing so far. I think it would possibly work if we just switched the default for stream IDs to be "bypass" if they have any devices that have reserved memory regions, but again, this isn't quite working (yet). Thierry > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > drivers/iommu/dma-iommu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > index de68b4a02aea..31d48e55ab55 100644 > > --- a/drivers/iommu/dma-iommu.c > > +++ b/drivers/iommu/dma-iommu.c > > @@ -19,6 +19,7 @@ > > #include <linux/iova.h> > > #include <linux/irq.h> > > #include <linux/mm.h> > > +#include <linux/of_iommu.h> > > #include <linux/pci.h> > > #include <linux/scatterlist.h> > > #include <linux/vmalloc.h> > > @@ -164,6 +165,8 @@ void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list) > > if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode)) > > iort_iommu_msi_get_resv_regions(dev, list); > > + if (dev->of_node) > > + of_iommu_get_resv_regions(dev, list); > > } > > EXPORT_SYMBOL(iommu_dma_get_resv_regions); > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com> To: Robin Murphy <robin.murphy@arm.com> Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring <robh+dt@kernel.org>, Will Deacon <will@kernel.org> Subject: Re: [PATCH 2/2] iommu: dma: Use of_iommu_get_resv_regions() Date: Mon, 2 Sep 2019 16:52:45 +0200 [thread overview] Message-ID: <20190902145245.GC1445@ulmo> (raw) In-Reply-To: <1caeaaa0-c5aa-b630-6d42-055b26764f40@arm.com> [-- Attachment #1.1: Type: text/plain, Size: 2661 bytes --] On Mon, Sep 02, 2019 at 03:22:35PM +0100, Robin Murphy wrote: > On 29/08/2019 12:14, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > For device tree nodes, use the standard of_iommu_get_resv_regions() > > implementation to obtain the reserved memory regions associated with a > > device. > > This covers the window between iommu_probe_device() setting up a default > domain and the device's driver finally probing and taking control, but > iommu_probe_device() represents the point that the IOMMU driver first knows > about this device - there's still a window from whenever the IOMMU driver > itself probed up to here where the "unidentified" traffic may have already > been disrupted. Some IOMMU drivers have no option but to make the necessary > configuration during their own probe routine, at which point a struct device > for the display/etc. endpoint may not even exist yet. Yeah, I think I'm actually running into this issue with the ARM SMMU driver. The above works fine with the Tegra SMMU driver, though, because it doesn't touch the SMMU configuration until a device is attached to a domain. For anything earlier than iommu_probe_device(), I don't see a way of doing this generically. I've been working on a prototype to make these reserved memory regions early on for ARM SMMU but I've been failing so far. I think it would possibly work if we just switched the default for stream IDs to be "bypass" if they have any devices that have reserved memory regions, but again, this isn't quite working (yet). Thierry > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > drivers/iommu/dma-iommu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > index de68b4a02aea..31d48e55ab55 100644 > > --- a/drivers/iommu/dma-iommu.c > > +++ b/drivers/iommu/dma-iommu.c > > @@ -19,6 +19,7 @@ > > #include <linux/iova.h> > > #include <linux/irq.h> > > #include <linux/mm.h> > > +#include <linux/of_iommu.h> > > #include <linux/pci.h> > > #include <linux/scatterlist.h> > > #include <linux/vmalloc.h> > > @@ -164,6 +165,8 @@ void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list) > > if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode)) > > iort_iommu_msi_get_resv_regions(dev, list); > > + if (dev->of_node) > > + of_iommu_get_resv_regions(dev, list); > > } > > EXPORT_SYMBOL(iommu_dma_get_resv_regions); > > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 156 bytes --] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-02 14:52 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-29 11:14 [PATCH 0/2] iommu: Support reserved-memory regions Thierry Reding 2019-08-29 11:14 ` Thierry Reding 2019-08-29 11:14 ` [PATCH 1/2] iommu: Implement of_iommu_get_resv_regions() Thierry Reding 2019-08-29 11:14 ` Thierry Reding 2019-09-02 13:38 ` Rob Herring 2019-09-02 13:38 ` Rob Herring 2019-09-02 13:38 ` Rob Herring 2019-09-02 13:54 ` Robin Murphy 2019-09-02 13:54 ` Robin Murphy 2019-09-02 15:00 ` Thierry Reding 2019-09-02 15:00 ` Thierry Reding 2019-09-02 15:00 ` Thierry Reding 2019-09-09 14:04 ` Will Deacon 2019-09-09 14:04 ` Will Deacon 2019-08-29 11:14 ` [PATCH 2/2] iommu: dma: Use of_iommu_get_resv_regions() Thierry Reding 2019-08-29 11:14 ` Thierry Reding 2019-09-02 14:22 ` Robin Murphy 2019-09-02 14:22 ` Robin Murphy 2019-09-02 14:52 ` Thierry Reding [this message] 2019-09-02 14:52 ` Thierry Reding 2019-09-17 17:59 ` Will Deacon 2019-09-17 17:59 ` Will Deacon 2019-11-27 12:16 ` Thierry Reding 2019-11-27 12:16 ` Thierry Reding 2019-11-27 14:16 ` Thierry Reding 2019-11-27 14:16 ` Thierry Reding 2019-11-27 17:09 ` Robin Murphy 2019-11-27 17:09 ` Robin Murphy 2019-11-28 11:43 ` Thierry Reding 2019-11-28 11:43 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190902145245.GC1445@ulmo \ --to=thierry.reding@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.