From: Christoph Hellwig <hch@infradead.org>
To: James Smart <jsmart2021@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Treat discovery subsystems as unique subsystems
Date: Mon, 2 Sep 2019 09:12:27 -0700 [thread overview]
Message-ID: <20190902161227.GA27231@infradead.org> (raw)
In-Reply-To: <20190830201145.6729-1-jsmart2021@gmail.com>
On Fri, Aug 30, 2019 at 01:11:45PM -0700, James Smart wrote:
> @@ -2358,6 +2358,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>
> lockdep_assert_held(&nvme_subsystems_lock);
>
> + if (!strcmp(subsysnqn, NVME_DISC_SUBSYS_NAME))
> + return NULL;
> +
Can you throw in a comment here?
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-09-02 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 20:11 [PATCH] nvme: Treat discovery subsystems as unique subsystems James Smart
2019-08-30 21:04 ` Sagi Grimberg
2019-09-01 10:04 ` Max Gurtovoy
2019-09-01 14:41 ` James Smart
2019-09-02 16:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902161227.GA27231@infradead.org \
--to=hch@infradead.org \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.