* [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C
@ 2019-09-03 12:10 YueHaibing
2019-09-03 12:21 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-09-03 12:10 UTC (permalink / raw)
To: heikki.krogerus, gregkh; +Cc: linux-usb, linux-kernel, YueHaibing
If CONFIG_REGMAP_I2C is not set, building fails:
drivers/usb/typec/tps6598x.o: In function `tps6598x_probe':
tps6598x.c:(.text+0x5f0): undefined reference to `__devm_regmap_init_i2c'
Select REGMAP_I2C to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/usb/typec/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
index 89d9193..895e241 100644
--- a/drivers/usb/typec/Kconfig
+++ b/drivers/usb/typec/Kconfig
@@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
config TYPEC_TPS6598X
tristate "TI TPS6598x USB Power Delivery controller driver"
depends on I2C
+ select REGMAP_I2C
help
Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power
Delivery controller.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C
2019-09-03 12:10 [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C YueHaibing
@ 2019-09-03 12:21 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2019-09-03 12:21 UTC (permalink / raw)
To: YueHaibing; +Cc: gregkh, linux-usb, linux-kernel
On Tue, Sep 03, 2019 at 08:10:26PM +0800, YueHaibing wrote:
> If CONFIG_REGMAP_I2C is not set, building fails:
>
> drivers/usb/typec/tps6598x.o: In function `tps6598x_probe':
> tps6598x.c:(.text+0x5f0): undefined reference to `__devm_regmap_init_i2c'
>
> Select REGMAP_I2C to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index 89d9193..895e241 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
> config TYPEC_TPS6598X
> tristate "TI TPS6598x USB Power Delivery controller driver"
> depends on I2C
> + select REGMAP_I2C
> help
> Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power
> Delivery controller.
> --
> 2.7.4
>
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 12:10 [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C YueHaibing
2019-09-03 12:21 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.