* [PATCH v2] um: irq: Fix LAST_IRQ usage
@ 2019-09-04 7:10 Johannes Berg
2019-09-04 7:30 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2019-09-04 7:10 UTC (permalink / raw)
To: linux-um; +Cc: Erel Geron, Johannes Berg
From: Erel Geron <erelx.geron@intel.com>
LAST_IRQ was used incorrectly in init_IRQ.
Fix this.
Change-Id: I8676920b31fbe61adadc35e36d6f8ad677af5b08
Signed-off-by: Erel Geron <erelx.geron@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-on: https://git-ger-8.devtools.intel.com/gerrit/95123
Tested-by: Johannes Berg <johannes.berg@intel.com>
---
arch/um/include/asm/irq.h | 2 +-
arch/um/kernel/irq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/include/asm/irq.h b/arch/um/include/asm/irq.h
index 49ed3e35b35a..ce7a78c3bcf2 100644
--- a/arch/um/include/asm/irq.h
+++ b/arch/um/include/asm/irq.h
@@ -23,7 +23,7 @@
#define VECTOR_BASE_IRQ 15
#define VECTOR_IRQ_SPACE 8
-#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ)
+#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ - 1)
#else
diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c
index efde1f16c603..402e59bdb65b 100644
--- a/arch/um/kernel/irq.c
+++ b/arch/um/kernel/irq.c
@@ -480,7 +480,7 @@ void __init init_IRQ(void)
irq_set_chip_and_handler(TIMER_IRQ, &SIGVTALRM_irq_type, handle_edge_irq);
- for (i = 1; i < LAST_IRQ; i++)
+ for (i = 1; i <= LAST_IRQ; i++)
irq_set_chip_and_handler(i, &normal_irq_type, handle_edge_irq);
/* Initialize EPOLL Loop */
os_setup_epoll();
--
2.20.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] um: irq: Fix LAST_IRQ usage
2019-09-04 7:10 [PATCH v2] um: irq: Fix LAST_IRQ usage Johannes Berg
@ 2019-09-04 7:30 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2019-09-04 7:30 UTC (permalink / raw)
To: linux-um; +Cc: Erel Geron
On Wed, 2019-09-04 at 09:10 +0200, Johannes Berg wrote:
> From: Erel Geron <erelx.geron@intel.com>
>
> LAST_IRQ was used incorrectly in init_IRQ.
> Fix this.
Oops, ignore this one - I accidentally sent it instead of the virtio
code.
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 7:10 [PATCH v2] um: irq: Fix LAST_IRQ usage Johannes Berg
2019-09-04 7:30 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.