* [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
@ 2019-09-04 10:07 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-09-04 10:07 UTC (permalink / raw)
To: intel-gfx
Cc: Chris Wilson, Jason Ekstrand, denys.kostin, Mika Kuoppala, stable
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: denys.kostin@globallogic.com
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 8639fcccdb42..243d3f77be13 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(i915))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
@ 2019-09-04 10:07 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-09-04 10:07 UTC (permalink / raw)
To: intel-gfx
Cc: Chris Wilson, Jason Ekstrand, denys.kostin, Mika Kuoppala, stable
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
>From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: denys.kostin@globallogic.com
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 8639fcccdb42..243d3f77be13 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(i915))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2)
2019-09-04 10:07 ` Chris Wilson
(?)
@ 2019-09-04 10:49 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2019-09-04 10:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2)
URL : https://patchwork.freedesktop.org/series/64920/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6833 -> Patchwork_14275
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/
Known issues
------------
Here are the changes found in Patchwork_14275 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-c:
- fi-skl-6770hq: [PASS][1] -> [SKIP][2] ([fdo#109271] / [fdo#109278]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: [PASS][3] -> [SKIP][4] ([fdo#109271]) +23 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [PASS][5] -> [DMESG-WARN][6] ([fdo#106387]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-bxt-dsi: [INCOMPLETE][7] ([fdo#103927]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
* igt@i915_selftest@live_gem_contexts:
- fi-kbl-guc: [INCOMPLETE][9] ([fdo#111519]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-kbl-guc/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-kbl-guc/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111096]) -> [FAIL][12] ([fdo#111407])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111519]: https://bugs.freedesktop.org/show_bug.cgi?id=111519
Participating hosts (53 -> 47)
------------------------------
Additional (1): fi-icl-u3
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6833 -> Patchwork_14275
CI-20190529: 20190529
CI_DRM_6833: b9d119cf9ec2e09a7a21ec0cc72dea1f1ce89f7a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5168: 04eac35177ba046ce55c495e510bc49443ec7429 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14275: 92bab182d852b9d115f43c71632bda63d7627227 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
92bab182d852 drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-09-04 10:07 ` Chris Wilson
@ 2019-09-04 10:59 ` Mika Kuoppala
-1 siblings, 0 replies; 15+ messages in thread
From: Mika Kuoppala @ 2019-09-04 10:59 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Cc: Chris Wilson, Jason Ekstrand, denys.kostin, stable
Chris Wilson <chris@chris-wilson.co.uk> writes:
> This bit was fliped on for "syncing dependencies between camera and
> graphics". BSpec has no recollection why, and it is causing
> unrecoverable GPU hangs with Vulkan compute workloads.
>
> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
> suppressed.
>
> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Tested-by: denys.kostin@globallogic.com
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.1+
The bug and especially #110228 was like a good detective story.
But one step left the reader curious: from the compute shader
reproducer the territory to search for was shrunk to gpgpu
workarounds. Was the rest brute force or how did you end up
with this particular one?
Great that it got nailed! Thanks everyone,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 8639fcccdb42..243d3f77be13 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
> FLOW_CONTROL_ENABLE |
> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>
> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
> - if (!IS_COFFEELAKE(i915))
> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
> -
> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> --
> 2.23.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
@ 2019-09-04 10:59 ` Mika Kuoppala
0 siblings, 0 replies; 15+ messages in thread
From: Mika Kuoppala @ 2019-09-04 10:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson, Jason Ekstrand, denys.kostin, stable
Chris Wilson <chris@chris-wilson.co.uk> writes:
> This bit was fliped on for "syncing dependencies between camera and
> graphics". BSpec has no recollection why, and it is causing
> unrecoverable GPU hangs with Vulkan compute workloads.
>
> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
> suppressed.
>
> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Tested-by: denys.kostin@globallogic.com
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.1+
The bug and especially #110228 was like a good detective story.
But one step left the reader curious: from the compute shader
reproducer the territory to search for was shrunk to gpgpu
workarounds. Was the rest brute force or how did you end up
with this particular one?
Great that it got nailed! Thanks everyone,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 8639fcccdb42..243d3f77be13 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
> FLOW_CONTROL_ENABLE |
> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>
> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
> - if (!IS_COFFEELAKE(i915))
> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
> -
> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> --
> 2.23.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2)
2019-09-04 10:07 ` Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2019-09-04 12:19 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2019-09-04 12:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2)
URL : https://patchwork.freedesktop.org/series/64920/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6833_full -> Patchwork_14275_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14275_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#111325]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +21 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_tiled_pread_pwrite:
- shard-apl: [PASS][5] -> [INCOMPLETE][6] ([fdo#103927]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-apl3/igt@gem_tiled_pread_pwrite.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-apl3/igt@gem_tiled_pread_pwrite.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([fdo#106107])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-skl5/igt@kms_fbcon_fbt@fbc-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-skl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [fdo#110403])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103166])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][23] -> [FAIL][24] ([fdo#99912])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-hsw1/igt@kms_setmode@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-hsw5/igt@kms_setmode@basic.html
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][25] -> [SKIP][26] ([fdo#109271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-kbl6/igt@perf_pmu@rc6.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-kbl3/igt@perf_pmu@rc6.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_eio@hibernate:
- shard-iclb: [FAIL][29] ([fdo#111550]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb8/igt@gem_eio@hibernate.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb3/igt@gem_eio@hibernate.html
* igt@gem_eio@reset-stress:
- shard-iclb: [FAIL][31] ([fdo#109661]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb8/igt@gem_eio@reset-stress.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb1/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][33] ([fdo#110854]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb3/igt@gem_exec_balancer@smoke.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][35] ([fdo#111325]) -> [PASS][36] +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-iclb: [FAIL][37] ([fdo#103375]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb8/igt@i915_suspend@fence-restore-tiled2untiled.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
- shard-apl: [INCOMPLETE][39] ([fdo#103927]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][41] ([fdo#105363]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [INCOMPLETE][43] ([fdo#103540]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-hsw7/igt@kms_flip@flip-vs-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-hsw8/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [INCOMPLETE][45] ([fdo#109507]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-iclb: [INCOMPLETE][47] ([fdo#107713]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb7/igt@kms_flip_tiling@flip-to-x-tiled.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb2/igt@kms_flip_tiling@flip-to-x-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [FAIL][49] ([fdo#103167]) -> [PASS][50] +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][51] ([fdo#108341]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb1/igt@kms_psr@no_drrs.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-hsw: [FAIL][55] ([fdo#103375]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-hsw5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-hsw5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@perf_pmu@cpu-hotplug:
- shard-iclb: [TIMEOUT][57] ([fdo#109673]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb8/igt@perf_pmu@cpu-hotplug.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb3/igt@perf_pmu@cpu-hotplug.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][59] ([fdo#109276]) -> [PASS][60] +19 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb6/igt@prime_busy@hang-bsd2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb2/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][61] ([fdo#111330]) -> [SKIP][62] ([fdo#109276]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-iclb3/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@perf_pmu@cpu-hotplug:
- shard-hsw: [TIMEOUT][63] ([fdo#111546]) -> [INCOMPLETE][64] ([fdo#103540])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6833/shard-hsw5/igt@perf_pmu@cpu-hotplug.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/shard-hsw6/igt@perf_pmu@cpu-hotplug.html
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111546]: https://bugs.freedesktop.org/show_bug.cgi?id=111546
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6833 -> Patchwork_14275
CI-20190529: 20190529
CI_DRM_6833: b9d119cf9ec2e09a7a21ec0cc72dea1f1ce89f7a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5168: 04eac35177ba046ce55c495e510bc49443ec7429 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14275: 92bab182d852b9d115f43c71632bda63d7627227 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14275/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-09-04 10:07 ` Chris Wilson
` (3 preceding siblings ...)
(?)
@ 2019-09-04 12:35 ` Sasha Levin
-1 siblings, 0 replies; 15+ messages in thread
From: Sasha Levin @ 2019-09-04 12:35 UTC (permalink / raw)
To: Sasha Levin, Chris Wilson, intel-gfx; +Cc: stable
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 8424171e135c drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics.
The bot has tested the following trees: v5.2.11, v4.19.69, v4.14.141, v4.9.190, v4.4.190.
v5.2.11: Failed to apply! Possible dependencies:
Unable to calculate
v4.19.69: Failed to apply! Possible dependencies:
0c7d2aedf51b ("drm/i915/icl: Add Wa_1406609255")
25d140faaa25 ("drm/i915: Record GT workarounds in a list")
288f1ced5e24 ("drm/i915: Reduce context HW ID lifetime")
30b710840e4b ("drm/i915: Cleanup gt powerstate from gem")
452420d22d5b ("drm/i915: Fuse per-context workaround handling with the common framework")
4a15c75c4246 ("drm/i915: Introduce per-engine workarounds")
6a00b8feb86d ("drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7")
71ffd49cc9b9 ("drm/i915/icl:Add Wa_1606682166")
745aa6cdee6b ("drm/i915: Fix icl workarounds whitespaces")
805615dae057 ("drm/i915: Remove useless error return from intel_init_mocs_engine()")
85f04aa569ad ("drm/i915: Deduplicate register definition for GAMW_ECO_DEV_RW_IA")
b2164e481556 ("drm/i915/execlists: Onion unwind for logical_ring_init() failure")
f57f9371e285 ("drm/i915/icl: WaAllowUMDToModifySamplerMode")
v4.14.141: Failed to apply! Possible dependencies:
1e998343f95b ("drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD")
212154ba4d1c ("drm/i915: Transform WaDisablePooledEuLoadBalancingFix into a simple register write")
2cbecff4122c ("drm/i915/cnl: WaPushConstantDereferenceHoldDisable")
32ced39c1b12 ("drm/i915: Transform whitelisting WAs into a simple reg write")
392572feb01c ("drm/i915/cnl: WA FtrEnableFastAnisoL1BankingFix")
4827c547c51f ("drm/i915: Transform WaDisableGafsUnitClkGating into a simple reg write")
5152defe4a53 ("drm/i915/preempt: Default to disabled mid-command preemption levels")
53221e11c7a0 ("drm/i915: Move MMCD_MISC_CTRL from context w/a to standard")
6cf20a0128fa ("drm/i915: Transform WaDisableI2mCycleOnWRPort into a simple reg write")
70a84f3c6075 ("drm/i915: Unconditionally apply the Broxton register workaround set")
7436830c8d1a ("drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too")
7d3c425fefb9 ("drm/i915: Move a bunch of workaround-related code to its own file")
90007bca6162 ("drm/i915/cnl: Introduce initial Cannonlake Workarounds.")
93564044fb2c ("drm/i915: Switch over to the LLC/eLLC hotspot avoidance hash mode for CCS")
efc886cb1355 ("drm/i915: Transform WaInPlaceDecompressionHang into a simple reg write")
f3e2b2c54050 ("drm/i915: Remove pre-production Broxton register workarounds")
v4.9.190: Failed to apply! Possible dependencies:
0e70447605f4 ("drm/i915: Move common code out of i915_gpu_error.c")
1b36595ffb35 ("drm/i915: Show RING registers through debugfs")
22681c7bc79a ("Documentation/gpu: Add section for Intel GVT-g host support")
3f728236c516 ("drm/i915/gvt: trace stub")
579cea5f30f2 ("drm/i915/gvt: golden virtual HW state management")
73cb97010d4f ("drm/i915: Combine seqno + tracking into a global timeline struct")
7d3c425fefb9 ("drm/i915: Move a bunch of workaround-related code to its own file")
82d375d1b568 ("drm/i915/gvt: Introduce basic vGPU life cycle management")
8453d674ae7e ("drm/i915/gvt: vGPU execlist virtualization")
c8fe6a6811a7 ("drm/i915/gvt: vGPU interrupt virtualization.")
d636951ec01b ("drm/i915: Cleanup instdone collection")
e473405783c0 ("drm/i915/gvt: vGPU workload scheduler")
e95433c73a11 ("drm/i915: Rearrange i915_wait_request() accounting with callers")
f97fbf9606a1 ("drm/i915: Add unit tests for the breadcrumb rbtree, insert/remove")
f9e613728090 ("drm/i915: Try to print INSTDONE bits for all slice/subslice")
v4.4.190: Failed to apply! Possible dependencies:
0a9d2bed5557 ("drm/i915/skl: Making DC6 entry is the last call in suspend flow.")
0ad35fed618c ("drm/i915: gvt: Introduce the basic architecture of GVT-g")
1f814daca43a ("drm/i915: add support for checking if we hold an RPM reference")
22681c7bc79a ("Documentation/gpu: Add section for Intel GVT-g host support")
22cba31bae9d ("Documentation/sphinx: add basic working Sphinx configuration and build")
2f693e28b8df ("drm/i915: Make turning on/off PW1 and Misc I/O part of the init/fini sequences")
399bb5b6db02 ("drm/i915: Move allocation of various workqueues earlier during init")
414b7999b8be ("drm/i915/gen9: Remove csr.state, csr_lock and related code.")
5d7a6eefc3b0 ("drm/i915: Split out load time early initialization")
643a24b6ecdc ("drm/i915: Kconfig for extra driver debugging")
666a45379e2c ("drm/i915: Separate cherryview from valleyview")
73dfc227ff5c ("drm/i915/skl: init/uninit display core as part of the HW power domain state")
755412e29c77 ("drm/i915: Add an optional selection from i915 of CONFIG_MMU_NOTIFIER")
7d3c425fefb9 ("drm/i915: Move a bunch of workaround-related code to its own file")
9c5308ea1cd4 ("drm/i915/skl: Refuse to load outdated dmc firmware")
b6e7d894c3d2 ("drm/i915/skl: Store and print the DMC firmware version we load")
bc87229f323e ("drm/i915/skl: enable PC9/10 power states during suspend-to-idle")
c73666f394fc ("drm/i915/skl: If needed sanitize bios programmed cdclk")
ca00c2b986ea ("Documentation/gpu: split up the gpu documentation")
cb597fcea5c2 ("Documentation/gpu: add new gpu.rst converted from DocBook gpu.tmpl")
ebae38d061df ("drm/i915/gen9: csr_init after runtime pm enable")
f4448375467d ("drm/i915/gen9: Use dev_priv in csr functions")
f514c2d84285 ("drm/i915/gen9: flush DMC fw loading work during system suspend")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks,
Sasha
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* FAILED: patch "[PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE)" failed to apply to 4.19-stable tree
@ 2019-09-16 15:18 gregkh
2019-09-16 16:35 ` [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Jason Ekstrand
0 siblings, 1 reply; 15+ messages in thread
From: gregkh @ 2019-09-16 15:18 UTC (permalink / raw)
To: chris, jani.nikula, jason, mika.kuoppala, stable; +Cc: stable
The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 2eb0964eec5f1d99f9eaf4963eee267acc72b615 Mon Sep 17 00:00:00 2001
From: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed, 4 Sep 2019 11:07:07 +0100
Subject: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE)
for skl+
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
From BSpec, setting bit5 to 0 enables relaxed padding requirements for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: denys.kostin@globallogic.com
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190904100707.7377-1-chris@chris-wilson.co.uk
(cherry picked from commit 9d7b01e93526efe79dbf75b69cc5972b5a4f7b37)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 98dfb086320f..99e8242194c0 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -308,11 +308,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(i915))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-09-16 15:18 FAILED: patch "[PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE)" failed to apply to 4.19-stable tree gregkh
@ 2019-09-16 16:35 ` Jason Ekstrand
0 siblings, 0 replies; 15+ messages in thread
From: Jason Ekstrand @ 2019-09-16 16:35 UTC (permalink / raw)
To: stable
Cc: Chris Wilson, Jason Ekstrand, denys.kostin, Mika Kuoppala, Jani Nikula
From: Chris Wilson <chris@chris-wilson.co.uk>
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
From BSpec, setting bit5 to 0 enables relaxed padding requirements for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Back-ported from 2eb0964eec5f1d99f9eaf4963eee267acc72b615 to 4.19.72 by
Jason Ekstrand
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: denys.kostin@globallogic.com
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190904100707.7377-1-chris@chris-wilson.co.uk
(cherry picked from commit 9d7b01e93526efe79dbf75b69cc5972b5a4f7b37)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
---
drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
index c44bb37e434c..bbb7411fc11b 100644
--- a/drivers/gpu/drm/i915/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/intel_workarounds.c
@@ -227,11 +227,6 @@ static int gen9_ctx_workarounds_init(struct drm_i915_private *dev_priv)
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(dev_priv))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
--
2.21.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
@ 2019-08-08 16:36 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-08-08 16:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson, Jason Ekstrand, Mika Kuoppala, stable
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 704ace01e7f5..b95c1d59a347 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(i915))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
--
2.23.0.rc1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
@ 2019-08-08 16:36 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-08-08 16:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson, Jason Ekstrand, Mika Kuoppala, stable
This bit was fliped on for "syncing dependencies between camera and
graphics". BSpec has no recollection why, and it is causing
unrecoverable GPU hangs with Vulkan compute workloads.
>From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
suppressed.
Reported-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between camera and graphics")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.1+
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 704ace01e7f5..b95c1d59a347 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
FLOW_CONTROL_ENABLE |
PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
- /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
- if (!IS_COFFEELAKE(i915))
- WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
- GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
-
/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
--
2.23.0.rc1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-08-08 16:36 ` Chris Wilson
(?)
@ 2019-08-08 17:30 ` Jason Ekstrand
2019-08-08 17:33 ` Jason Ekstrand
-1 siblings, 1 reply; 15+ messages in thread
From: Jason Ekstrand @ 2019-08-08 17:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel GFX, stable
[-- Attachment #1.1: Type: text/plain, Size: 2142 bytes --]
This is consistent with what the Windows driver does and what I've heard
from HW people.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson <chris@chris-wilson.co.uk>
wrote:
> This bit was fliped on for "syncing dependencies between camera and
> graphics". BSpec has no recollection why, and it is causing
> unrecoverable GPU hangs with Vulkan compute workloads.
>
> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
> suppressed.
>
> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between
> camera and graphics")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.1+
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 704ace01e7f5..b95c1d59a347 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct
> intel_engine_cs *engine,
> FLOW_CONTROL_ENABLE |
> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>
> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
> - if (!IS_COFFEELAKE(i915))
> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
> -
> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> --
> 2.23.0.rc1
>
>
[-- Attachment #1.2: Type: text/html, Size: 3237 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-08-08 17:30 ` Jason Ekstrand
@ 2019-08-08 17:33 ` Jason Ekstrand
2019-08-09 4:35 ` Jason Ekstrand
0 siblings, 1 reply; 15+ messages in thread
From: Jason Ekstrand @ 2019-08-08 17:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel GFX, stable
[-- Attachment #1.1: Type: text/plain, Size: 2499 bytes --]
Note: This doesn't actually fix 110998. I can still get a hard-hang with a
slightly different version of the reproducer example. However, it does fix
the original and I suspect it will fix the UE4 editor hang in 110228
On Thu, Aug 8, 2019 at 12:30 PM Jason Ekstrand <jason@jlekstrand.net> wrote:
> This is consistent with what the Windows driver does and what I've heard
> from HW people.
>
> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
>
> On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson <chris@chris-wilson.co.uk>
> wrote:
>
>> This bit was fliped on for "syncing dependencies between camera and
>> graphics". BSpec has no recollection why, and it is causing
>> unrecoverable GPU hangs with Vulkan compute workloads.
>>
>> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
>> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
>> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
>> suppressed.
>>
>> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
>> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
>> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies
>> between camera and graphics")
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Jason Ekstrand <jason@jlekstrand.net>
>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Cc: <stable@vger.kernel.org> # v4.1+
>> ---
>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 704ace01e7f5..b95c1d59a347 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct
>> intel_engine_cs *engine,
>> FLOW_CONTROL_ENABLE |
>> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>>
>> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
>> - if (!IS_COFFEELAKE(i915))
>> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
>> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
>> -
>> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
>> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>> --
>> 2.23.0.rc1
>>
>>
[-- Attachment #1.2: Type: text/html, Size: 3859 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-08-08 17:33 ` Jason Ekstrand
@ 2019-08-09 4:35 ` Jason Ekstrand
2019-08-14 18:40 ` Jason Ekstrand
0 siblings, 1 reply; 15+ messages in thread
From: Jason Ekstrand @ 2019-08-09 4:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel GFX, stable
[-- Attachment #1.1: Type: text/plain, Size: 2614 bytes --]
Also, I think we can provide a better commit message. I'll type something
in the morning when I can actually look stuff up and provide correct
references.
On August 8, 2019 12:33:15 Jason Ekstrand <jason@jlekstrand.net> wrote:
> Note: This doesn't actually fix 110998. I can still get a hard-hang with a
> slightly different version of the reproducer example. However, it does fix
> the original and I suspect it will fix the UE4 editor hang in 110228
>
> On Thu, Aug 8, 2019 at 12:30 PM Jason Ekstrand <jason@jlekstrand.net> wrote:
> This is consistent with what the Windows driver does and what I've heard
> from HW people.
>
> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
>
> On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> This bit was fliped on for "syncing dependencies between camera and
> graphics". BSpec has no recollection why, and it is causing
> unrecoverable GPU hangs with Vulkan compute workloads.
>
> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
> suppressed.
>
> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies between
> camera and graphics")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.1+
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 704ace01e7f5..b95c1d59a347 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct
> intel_engine_cs *engine,
> FLOW_CONTROL_ENABLE |
> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>
> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl */
> - if (!IS_COFFEELAKE(i915))
> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
> -
> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> --
> 2.23.0.rc1
[-- Attachment #1.2: Type: text/html, Size: 4998 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-08-09 4:35 ` Jason Ekstrand
@ 2019-08-14 18:40 ` Jason Ekstrand
2019-08-23 18:53 ` Jason Ekstrand
0 siblings, 1 reply; 15+ messages in thread
From: Jason Ekstrand @ 2019-08-14 18:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel GFX, stable
[-- Attachment #1.1: Type: text/plain, Size: 3752 bytes --]
I was going to ask the status of this and then I looked and realized that I
never provided a commit message blrub. Oops. Here you go:
On Broadwell, the sampler was changed to not require extra padding for
simple (no arrays, mipmapping, or MSAA) 1D, 2D, and buffer surfaces.
Setting the GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC bit in HALF_SLICE_CHICKEN3
disables this and reverts the hardware to the HSW-era behaviour where the
sampler over-fetches near the edges of the surface. While the over-fetch
does not cause faults due to the scratch page, it still means that more
data than needed is getting pulled into the sampler cache. If the
over-fetch from the sampler on a BUFFER surface leaks over into an atomic
on the L3$, hangs can occur.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110228
On Thu, Aug 8, 2019 at 11:35 PM Jason Ekstrand <jason@jlekstrand.net> wrote:
> Also, I think we can provide a better commit message. I'll type something
> in the morning when I can actually look stuff up and provide correct
> references.
>
> On August 8, 2019 12:33:15 Jason Ekstrand <jason@jlekstrand.net> wrote:
>
>> Note: This doesn't actually fix 110998. I can still get a hard-hang with
>> a slightly different version of the reproducer example. However, it does
>> fix the original and I suspect it will fix the UE4 editor hang in 110228
>>
>> On Thu, Aug 8, 2019 at 12:30 PM Jason Ekstrand <jason@jlekstrand.net>
>> wrote:
>>
>>> This is consistent with what the Windows driver does and what I've heard
>>> from HW people.
>>>
>>> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
>>>
>>> On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson <chris@chris-wilson.co.uk>
>>> wrote:
>>>
>>>> This bit was fliped on for "syncing dependencies between camera and
>>>> graphics". BSpec has no recollection why, and it is causing
>>>> unrecoverable GPU hangs with Vulkan compute workloads.
>>>>
>>>> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
>>>> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
>>>> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
>>>> suppressed.
>>>>
>>>> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
>>>> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
>>>> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies
>>>> between camera and graphics")
>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>> Cc: Jason Ekstrand <jason@jlekstrand.net>
>>>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>>>> Cc: <stable@vger.kernel.org> # v4.1+
>>>> ---
>>>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
>>>> 1 file changed, 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>> index 704ace01e7f5..b95c1d59a347 100644
>>>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct
>>>> intel_engine_cs *engine,
>>>> FLOW_CONTROL_ENABLE |
>>>> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>>>>
>>>> - /* Syncing dependencies between camera and graphics:skl,bxt,kbl
>>>> */
>>>> - if (!IS_COFFEELAKE(i915))
>>>> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
>>>> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
>>>> -
>>>> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
>>>> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
>>>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>>>> --
>>>> 2.23.0.rc1
>>>>
>>>>
>
[-- Attachment #1.2: Type: text/html, Size: 6018 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+
2019-08-14 18:40 ` Jason Ekstrand
@ 2019-08-23 18:53 ` Jason Ekstrand
0 siblings, 0 replies; 15+ messages in thread
From: Jason Ekstrand @ 2019-08-23 18:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel GFX, stable
[-- Attachment #1.1: Type: text/plain, Size: 3993 bytes --]
Bump? Has this been landed or looked at beyond my review?
On Wed, Aug 14, 2019 at 1:40 PM Jason Ekstrand <jason@jlekstrand.net> wrote:
> I was going to ask the status of this and then I looked and realized that
> I never provided a commit message blrub. Oops. Here you go:
>
> On Broadwell, the sampler was changed to not require extra padding for
> simple (no arrays, mipmapping, or MSAA) 1D, 2D, and buffer surfaces.
> Setting the GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC bit in HALF_SLICE_CHICKEN3
> disables this and reverts the hardware to the HSW-era behaviour where the
> sampler over-fetches near the edges of the surface. While the over-fetch
> does not cause faults due to the scratch page, it still means that more
> data than needed is getting pulled into the sampler cache. If the
> over-fetch from the sampler on a BUFFER surface leaks over into an atomic
> on the L3$, hangs can occur.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110228
>
> On Thu, Aug 8, 2019 at 11:35 PM Jason Ekstrand <jason@jlekstrand.net>
> wrote:
>
>> Also, I think we can provide a better commit message. I'll type something
>> in the morning when I can actually look stuff up and provide correct
>> references.
>>
>> On August 8, 2019 12:33:15 Jason Ekstrand <jason@jlekstrand.net> wrote:
>>
>>> Note: This doesn't actually fix 110998. I can still get a hard-hang
>>> with a slightly different version of the reproducer example. However, it
>>> does fix the original and I suspect it will fix the UE4 editor hang in
>>> 110228
>>>
>>> On Thu, Aug 8, 2019 at 12:30 PM Jason Ekstrand <jason@jlekstrand.net>
>>> wrote:
>>>
>>>> This is consistent with what the Windows driver does and what I've
>>>> heard from HW people.
>>>>
>>>> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
>>>>
>>>> On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson <chris@chris-wilson.co.uk>
>>>> wrote:
>>>>
>>>>> This bit was fliped on for "syncing dependencies between camera and
>>>>> graphics". BSpec has no recollection why, and it is causing
>>>>> unrecoverable GPU hangs with Vulkan compute workloads.
>>>>>
>>>>> From BSpec, setting bit5 to 0 enables relaxed padding requiremets for
>>>>> buffers, 1D and 2D non-array, non-MSAA, non-mip-mapped linear surfaces;
>>>>> and *must* be set to 0h on skl+ to ensure "Out of Bounds" case is
>>>>> suppressed.
>>>>>
>>>>> Reported-by: Jason Ekstrand <jason@jlekstrand.net>
>>>>> Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
>>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110998
>>>>> Fixes: 8424171e135c ("drm/i915/gen9: h/w w/a: syncing dependencies
>>>>> between camera and graphics")
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Jason Ekstrand <jason@jlekstrand.net>
>>>>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>>>>> Cc: <stable@vger.kernel.org> # v4.1+
>>>>> ---
>>>>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -----
>>>>> 1 file changed, 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>>> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>>> index 704ace01e7f5..b95c1d59a347 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>>>> @@ -297,11 +297,6 @@ static void gen9_ctx_workarounds_init(struct
>>>>> intel_engine_cs *engine,
>>>>> FLOW_CONTROL_ENABLE |
>>>>> PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>>>>>
>>>>> - /* Syncing dependencies between camera and
>>>>> graphics:skl,bxt,kbl */
>>>>> - if (!IS_COFFEELAKE(i915))
>>>>> - WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
>>>>> - GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
>>>>> -
>>>>> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
>>>>> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
>>>>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>>>>> --
>>>>> 2.23.0.rc1
>>>>>
>>>>>
>>
[-- Attachment #1.2: Type: text/html, Size: 6529 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-09-16 16:36 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 10:07 [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Chris Wilson
2019-09-04 10:07 ` Chris Wilson
2019-09-04 10:49 ` ✓ Fi.CI.BAT: success for drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2) Patchwork
2019-09-04 10:59 ` [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Mika Kuoppala
2019-09-04 10:59 ` Mika Kuoppala
2019-09-04 12:19 ` ✓ Fi.CI.IGT: success for drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (rev2) Patchwork
2019-09-04 12:35 ` [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2019-09-16 15:18 FAILED: patch "[PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE)" failed to apply to 4.19-stable tree gregkh
2019-09-16 16:35 ` [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Jason Ekstrand
2019-08-08 16:36 Chris Wilson
2019-08-08 16:36 ` Chris Wilson
2019-08-08 17:30 ` Jason Ekstrand
2019-08-08 17:33 ` Jason Ekstrand
2019-08-09 4:35 ` Jason Ekstrand
2019-08-14 18:40 ` Jason Ekstrand
2019-08-23 18:53 ` Jason Ekstrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.