* [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 11:50 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-09-04 11:50 UTC (permalink / raw)
To: b.zolnierkie, allison, mcgrof, yuehaibing, rfontana, tglx
Cc: dri-devel, linux-fbdev, linux-kernel
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/da8xx-fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index b1cf248..57518d7 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1328,7 +1328,6 @@ static int fb_probe(struct platform_device *device)
{
struct da8xx_lcdc_platform_data *fb_pdata =
dev_get_platdata(&device->dev);
- struct resource *lcdc_regs;
struct lcd_ctrl_config *lcd_cfg;
struct fb_videomode *lcdc_info;
struct fb_info *da8xx_fb_info;
@@ -1346,8 +1345,7 @@ static int fb_probe(struct platform_device *device)
if (lcdc_info == NULL)
return -ENODEV;
- lcdc_regs = platform_get_resource(device, IORESOURCE_MEM, 0);
- da8xx_fb_reg_base = devm_ioremap_resource(&device->dev, lcdc_regs);
+ da8xx_fb_reg_base = devm_platform_ioremap_resource(device, 0);
if (IS_ERR(da8xx_fb_reg_base))
return PTR_ERR(da8xx_fb_reg_base);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 11:50 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-09-04 11:50 UTC (permalink / raw)
To: b.zolnierkie, allison, mcgrof, yuehaibing, rfontana, tglx
Cc: dri-devel, linux-fbdev, linux-kernel
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/da8xx-fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index b1cf248..57518d7 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1328,7 +1328,6 @@ static int fb_probe(struct platform_device *device)
{
struct da8xx_lcdc_platform_data *fb_pdata dev_get_platdata(&device->dev);
- struct resource *lcdc_regs;
struct lcd_ctrl_config *lcd_cfg;
struct fb_videomode *lcdc_info;
struct fb_info *da8xx_fb_info;
@@ -1346,8 +1345,7 @@ static int fb_probe(struct platform_device *device)
if (lcdc_info = NULL)
return -ENODEV;
- lcdc_regs = platform_get_resource(device, IORESOURCE_MEM, 0);
- da8xx_fb_reg_base = devm_ioremap_resource(&device->dev, lcdc_regs);
+ da8xx_fb_reg_base = devm_platform_ioremap_resource(device, 0);
if (IS_ERR(da8xx_fb_reg_base))
return PTR_ERR(da8xx_fb_reg_base);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code
2019-09-04 11:50 ` YueHaibing
(?)
@ 2020-01-03 12:13 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:13 UTC (permalink / raw)
To: YueHaibing
Cc: allison, mcgrof, rfontana, tglx, dri-devel, linux-fbdev, linux-kernel
On 9/4/19 1:50 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This has been already fixed by:
commit c957c88f7be109a14294289f013b03bbe94e8af5
Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
AuthorDate: Mon Jul 22 15:44:21 2019 +0200
Commit: Sekhar Nori <nsekhar@ti.com>
CommitDate: Mon Aug 26 17:53:59 2019 +0530
fbdev: da8xx-fb: use devm_platform_ioremap_resource()
Shrink the code a bit by using the new helper wrapping the calls to
platform_get_resource() and devm_ioremap_resource() together.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/da8xx-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
> index b1cf248..57518d7 100644
> --- a/drivers/video/fbdev/da8xx-fb.c
> +++ b/drivers/video/fbdev/da8xx-fb.c
> @@ -1328,7 +1328,6 @@ static int fb_probe(struct platform_device *device)
> {
> struct da8xx_lcdc_platform_data *fb_pdata =
> dev_get_platdata(&device->dev);
> - struct resource *lcdc_regs;
> struct lcd_ctrl_config *lcd_cfg;
> struct fb_videomode *lcdc_info;
> struct fb_info *da8xx_fb_info;
> @@ -1346,8 +1345,7 @@ static int fb_probe(struct platform_device *device)
> if (lcdc_info == NULL)
> return -ENODEV;
>
> - lcdc_regs = platform_get_resource(device, IORESOURCE_MEM, 0);
> - da8xx_fb_reg_base = devm_ioremap_resource(&device->dev, lcdc_regs);
> + da8xx_fb_reg_base = devm_platform_ioremap_resource(device, 0);
> if (IS_ERR(da8xx_fb_reg_base))
> return PTR_ERR(da8xx_fb_reg_base);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code
@ 2020-01-03 12:13 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:13 UTC (permalink / raw)
To: YueHaibing
Cc: linux-fbdev, linux-kernel, dri-devel, rfontana, mcgrof, tglx, allison
On 9/4/19 1:50 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This has been already fixed by:
commit c957c88f7be109a14294289f013b03bbe94e8af5
Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
AuthorDate: Mon Jul 22 15:44:21 2019 +0200
Commit: Sekhar Nori <nsekhar@ti.com>
CommitDate: Mon Aug 26 17:53:59 2019 +0530
fbdev: da8xx-fb: use devm_platform_ioremap_resource()
Shrink the code a bit by using the new helper wrapping the calls to
platform_get_resource() and devm_ioremap_resource() together.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/da8xx-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
> index b1cf248..57518d7 100644
> --- a/drivers/video/fbdev/da8xx-fb.c
> +++ b/drivers/video/fbdev/da8xx-fb.c
> @@ -1328,7 +1328,6 @@ static int fb_probe(struct platform_device *device)
> {
> struct da8xx_lcdc_platform_data *fb_pdata =
> dev_get_platdata(&device->dev);
> - struct resource *lcdc_regs;
> struct lcd_ctrl_config *lcd_cfg;
> struct fb_videomode *lcdc_info;
> struct fb_info *da8xx_fb_info;
> @@ -1346,8 +1345,7 @@ static int fb_probe(struct platform_device *device)
> if (lcdc_info == NULL)
> return -ENODEV;
>
> - lcdc_regs = platform_get_resource(device, IORESOURCE_MEM, 0);
> - da8xx_fb_reg_base = devm_ioremap_resource(&device->dev, lcdc_regs);
> + da8xx_fb_reg_base = devm_platform_ioremap_resource(device, 0);
> if (IS_ERR(da8xx_fb_reg_base))
> return PTR_ERR(da8xx_fb_reg_base);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code
@ 2020-01-03 12:13 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:13 UTC (permalink / raw)
To: YueHaibing
Cc: linux-fbdev, linux-kernel, dri-devel, rfontana, mcgrof, tglx, allison
On 9/4/19 1:50 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This has been already fixed by:
commit c957c88f7be109a14294289f013b03bbe94e8af5
Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
AuthorDate: Mon Jul 22 15:44:21 2019 +0200
Commit: Sekhar Nori <nsekhar@ti.com>
CommitDate: Mon Aug 26 17:53:59 2019 +0530
fbdev: da8xx-fb: use devm_platform_ioremap_resource()
Shrink the code a bit by using the new helper wrapping the calls to
platform_get_resource() and devm_ioremap_resource() together.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/da8xx-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
> index b1cf248..57518d7 100644
> --- a/drivers/video/fbdev/da8xx-fb.c
> +++ b/drivers/video/fbdev/da8xx-fb.c
> @@ -1328,7 +1328,6 @@ static int fb_probe(struct platform_device *device)
> {
> struct da8xx_lcdc_platform_data *fb_pdata > dev_get_platdata(&device->dev);
> - struct resource *lcdc_regs;
> struct lcd_ctrl_config *lcd_cfg;
> struct fb_videomode *lcdc_info;
> struct fb_info *da8xx_fb_info;
> @@ -1346,8 +1345,7 @@ static int fb_probe(struct platform_device *device)
> if (lcdc_info = NULL)
> return -ENODEV;
>
> - lcdc_regs = platform_get_resource(device, IORESOURCE_MEM, 0);
> - da8xx_fb_reg_base = devm_ioremap_resource(&device->dev, lcdc_regs);
> + da8xx_fb_reg_base = devm_platform_ioremap_resource(device, 0);
> if (IS_ERR(da8xx_fb_reg_base))
> return PTR_ERR(da8xx_fb_reg_base);
>
^ permalink raw reply [flat|nested] 6+ messages in thread