From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Laight <David.Laight@aculab.com>
Cc: "'Nathan Chancellor'" <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp
Date: Wed, 4 Sep 2019 08:01:35 -0500 [thread overview]
Message-ID: <20190904130135.GN9749@gate.crashing.org> (raw)
In-Reply-To: <1bcd7086f3d24dfa82eec03980f30fbc@AcuMS.aculab.com>
On Wed, Sep 04, 2019 at 08:16:45AM +0000, David Laight wrote:
> From: Nathan Chancellor [mailto:natechancellor@gmail.com]
> > Fair enough so I guess we are back to just outright disabling the
> > warning.
>
> Just disabling the warning won't stop the compiler generating code
> that breaks a 'user' implementation of setjmp().
Yeah. I have a patch (will send in an hour or so) that enables the
"returns_twice" attribute for setjmp (in <asm/setjmp.h>). In testing
(with GCC trunk) it showed no difference in code generation, but
better save than sorry.
It also sets "noreturn" on longjmp, and that *does* help, it saves a
hundred insns or so (all in xmon, no surprise there).
I don't think this will make LLVM shut up about this though. And
technically it is right: the C standard does say that in hosted mode
setjmp is a reserved name and you need to include <setjmp.h> to access
it (not <asm/setjmp.h>).
So why is the kernel compiled as hosted? Does adding -ffreestanding
hurt anything? Is that actually supported on LLVM, on all relevant
versions of it? Does it shut up the warning there (if not, that would
be an LLVM bug)?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Laight <David.Laight@aculab.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Paul Mackerras <paulus@samba.org>,
'Nathan Chancellor' <natechancellor@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp
Date: Wed, 4 Sep 2019 08:01:35 -0500 [thread overview]
Message-ID: <20190904130135.GN9749@gate.crashing.org> (raw)
In-Reply-To: <1bcd7086f3d24dfa82eec03980f30fbc@AcuMS.aculab.com>
On Wed, Sep 04, 2019 at 08:16:45AM +0000, David Laight wrote:
> From: Nathan Chancellor [mailto:natechancellor@gmail.com]
> > Fair enough so I guess we are back to just outright disabling the
> > warning.
>
> Just disabling the warning won't stop the compiler generating code
> that breaks a 'user' implementation of setjmp().
Yeah. I have a patch (will send in an hour or so) that enables the
"returns_twice" attribute for setjmp (in <asm/setjmp.h>). In testing
(with GCC trunk) it showed no difference in code generation, but
better save than sorry.
It also sets "noreturn" on longjmp, and that *does* help, it saves a
hundred insns or so (all in xmon, no surprise there).
I don't think this will make LLVM shut up about this though. And
technically it is right: the C standard does say that in hosted mode
setjmp is a reserved name and you need to include <setjmp.h> to access
it (not <asm/setjmp.h>).
So why is the kernel compiled as hosted? Does adding -ffreestanding
hurt anything? Is that actually supported on LLVM, on all relevant
versions of it? Does it shut up the warning there (if not, that would
be an LLVM bug)?
Segher
next prev parent reply other threads:[~2019-09-04 13:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 2:32 [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp Nathan Chancellor
2019-08-12 2:32 ` Nathan Chancellor
2019-08-12 5:37 ` Christophe Leroy
2019-08-12 16:55 ` Nathan Chancellor
2019-08-12 16:55 ` Nathan Chancellor
2019-08-12 17:35 ` Nick Desaulniers
2019-08-12 17:35 ` Nick Desaulniers
2019-08-27 0:12 ` Nathan Chancellor
2019-08-27 0:12 ` Nathan Chancellor
2019-08-28 13:43 ` Michael Ellerman
2019-08-28 13:43 ` Michael Ellerman
2019-08-28 17:53 ` Nathan Chancellor
2019-08-28 17:53 ` Nathan Chancellor
2019-08-28 18:01 ` Nick Desaulniers
2019-08-28 18:01 ` Nick Desaulniers
2019-08-28 18:45 ` Nathan Chancellor
2019-08-28 18:45 ` Nathan Chancellor
2019-08-28 22:16 ` Nick Desaulniers
2019-08-28 22:16 ` Nick Desaulniers
2019-08-29 8:32 ` Segher Boessenkool
2019-08-29 8:32 ` Segher Boessenkool
2019-08-29 9:59 ` David Laight
2019-09-03 5:55 ` Nathan Chancellor
2019-09-03 5:55 ` Nathan Chancellor
2019-09-03 19:31 ` Segher Boessenkool
2019-09-03 19:31 ` Segher Boessenkool
2019-09-04 0:24 ` Nathan Chancellor
2019-09-04 0:24 ` Nathan Chancellor
2019-09-04 8:16 ` David Laight
2019-09-04 13:01 ` Segher Boessenkool [this message]
2019-09-04 13:01 ` Segher Boessenkool
2019-09-04 23:15 ` Nathan Chancellor
2019-09-04 23:15 ` Nathan Chancellor
2019-09-10 18:30 ` Michael Ellerman
2019-09-10 18:30 ` Michael Ellerman
2019-09-10 18:37 ` Nathan Chancellor
2019-09-10 18:37 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904130135.GN9749@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=David.Laight@aculab.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.