From: Deepa Dinamani <deepa.kernel@gmail.com>
To: arnd@arndb.de, linux-kernel@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, cai@lca.pw,
deepa.kernel@gmail.com, jlayton@kernel.org,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: [PATCH] ext4: Reduce ext4 timestamp warnings
Date: Wed, 4 Sep 2019 08:02:51 -0700 [thread overview]
Message-ID: <20190904150251.27004-1-deepa.kernel@gmail.com> (raw)
In-Reply-To: <31a671ea-a00b-37da-5f30-558c3ab6d690@thelounge.net>
When ext4 file systems were created intentionally with 128 byte inodes,
the rate-limited warning of eventual possible timestamp overflow are
still emitted rather frequently. Remove the warning for now.
Discussion for whether any warning is needed,
and where it should be emitted, can be found at
https://lore.kernel.org/lkml/1567523922.5576.57.camel@lca.pw/.
I can post a separate follow-up patch after the conclusion.
Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---
fs/ext4/ext4.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 9e3ae3be3de9..24b14bd3feab 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -833,10 +833,8 @@ do { \
(raw_inode)->xtime ## _extra = \
ext4_encode_extra_time(&(inode)->xtime); \
} \
- else {\
+ else \
(raw_inode)->xtime = cpu_to_le32(clamp_t(int32_t, (inode)->xtime.tv_sec, S32_MIN, S32_MAX)); \
- ext4_warning_inode(inode, "inode does not support timestamps beyond 2038"); \
- } \
} while (0)
#define EXT4_EINODE_SET_XTIME(xtime, einode, raw_inode) \
--
2.17.1
next prev parent reply other threads:[~2019-09-04 15:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:18 "beyond 2038" warnings from loopback mount is noisy Qian Cai
2019-09-03 16:18 ` Deepa Dinamani
2019-09-03 16:36 ` Deepa Dinamani
2019-09-03 18:15 ` Qian Cai
2019-09-03 19:39 ` Andreas Dilger
2019-09-03 19:50 ` Arnd Bergmann
2019-09-03 21:13 ` Qian Cai
2019-09-03 21:17 ` Theodore Y. Ts'o
2019-09-03 21:31 ` Deepa Dinamani
2019-09-03 21:48 ` Arnd Bergmann
2019-09-03 22:38 ` Theodore Y. Ts'o
2019-09-03 22:47 ` Deepa Dinamani
2019-09-03 23:03 ` Theodore Y. Ts'o
2019-09-04 4:50 ` Deepa Dinamani
2019-09-04 12:58 ` Theodore Y. Ts'o
2019-09-04 13:21 ` Reindl Harald
2019-09-04 14:25 ` Deepa Dinamani
2019-09-03 22:16 ` Theodore Y. Ts'o
2019-09-03 21:52 ` Reindl Harald
2019-09-04 15:02 ` Deepa Dinamani [this message]
2019-09-04 18:39 ` [PATCH] ext4: Reduce ext4 timestamp warnings Andreas Dilger
2019-09-04 20:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904150251.27004-1-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=cai@lca.pw \
--cc=jlayton@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.