From: Deepa Dinamani <deepa.kernel@gmail.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Arnd Bergmann <arnd@arndb.de>, Qian Cai <cai@lca.pw>,
Jeff Layton <jlayton@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: "beyond 2038" warnings from loopback mount is noisy
Date: Tue, 3 Sep 2019 15:47:54 -0700 [thread overview]
Message-ID: <CABeXuvp2F4cr_77UJDYVfQ=gD8QXn+t4X3Qxs6YbyMXYJYO7mg@mail.gmail.com> (raw)
In-Reply-To: <20190903223815.GH2899@mit.edu>
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 9e3ae3be3de9..5a971d1b6d5e 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -835,7 +835,9 @@ do {
> > \
> > }
> > \
> > else {\
> > (raw_inode)->xtime = cpu_to_le32(clamp_t(int32_t,
> > (inode)->xtime.tv_sec, S32_MIN, S32_MAX)); \
> > - ext4_warning_inode(inode, "inode does not support
> > timestamps beyond 2038"); \
> > + if (((inode)->xtime.tv_sec != (raw_inode)->xtime) && \
> > + ((inode)->i_sb->s_time_max > S32_MAX))
> > \
> > + ext4_warning_inode(inode, "inode does not
> > support timestamps beyond 2038"); \
> > } \
> > } while (0)
>
> Sure, that's much less objectionable.
The reason it was warning for every update was because of the
ratelimiting. I think ratelimiting is not working well here. I will
check that part.
-Deepa
next prev parent reply other threads:[~2019-09-03 22:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:18 "beyond 2038" warnings from loopback mount is noisy Qian Cai
2019-09-03 16:18 ` Deepa Dinamani
2019-09-03 16:36 ` Deepa Dinamani
2019-09-03 18:15 ` Qian Cai
2019-09-03 19:39 ` Andreas Dilger
2019-09-03 19:50 ` Arnd Bergmann
2019-09-03 21:13 ` Qian Cai
2019-09-03 21:17 ` Theodore Y. Ts'o
2019-09-03 21:31 ` Deepa Dinamani
2019-09-03 21:48 ` Arnd Bergmann
2019-09-03 22:38 ` Theodore Y. Ts'o
2019-09-03 22:47 ` Deepa Dinamani [this message]
2019-09-03 23:03 ` Theodore Y. Ts'o
2019-09-04 4:50 ` Deepa Dinamani
2019-09-04 12:58 ` Theodore Y. Ts'o
2019-09-04 13:21 ` Reindl Harald
2019-09-04 14:25 ` Deepa Dinamani
2019-09-03 22:16 ` Theodore Y. Ts'o
2019-09-03 21:52 ` Reindl Harald
2019-09-04 15:02 ` [PATCH] ext4: Reduce ext4 timestamp warnings Deepa Dinamani
2019-09-04 18:39 ` Andreas Dilger
2019-09-04 20:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABeXuvp2F4cr_77UJDYVfQ=gD8QXn+t4X3Qxs6YbyMXYJYO7mg@mail.gmail.com' \
--to=deepa.kernel@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=cai@lca.pw \
--cc=jlayton@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.