From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>, "Dan Murphy" <dmurphy@ti.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] led: triggers: Fix NULL dereference in led_trigger_set() error handling
Date: Thu, 5 Sep 2019 16:32:34 +0300 [thread overview]
Message-ID: <20190905133233.GF3093@kadam> (raw)
In-Reply-To: <BC1CA967-2B9F-44A4-A1A9-FD9C6E874991@kaa.org.ua>
On Thu, Sep 05, 2019 at 03:23:21PM +0300, Oleh Kravchenko wrote:
> Let me summarize the chronology of the last activities below:
> 1. I have sent the patch for the bugs that I have found by static analyzer at PVS-Studio
> Date: Wed, 4 Sep 2019 00:18:19 +0300
> https://www.spinics.net/lists/linux-leds/msg13181.html
>
> 2. At 5 Sep 2019 12:57:19 +0300 Time Dan Cartpen has sent the patch with the same proposal
> 3. Uwe Kleine-König started to discuss his results of review by asking Dan on how he was found it.
>
> Would you mine if you will keep me as a Original author of this patch based on fact 1?
Heh.
No, I didn't steal your patch. :P I am the author of the Smatch static
analysis tool and mostly fix things found by Smatch. I don't use other
static analysis tools except to do a final QC of my patches.
It's super common for people to send duplicate fixes when it's based on
static analysis. Most of the static analysis people hang out on
kernel-janitors so we don't send duplicate patches. For a while people
were getting annoyed by all the duplicates but now they accept it as
their punishment for introducing a bug in the first place.
Anyway, the rule for kernel development is that normally the first
person's patch goes in, so we will take your patch.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>, "Dan Murphy" <dmurphy@ti.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] led: triggers: Fix NULL dereference in led_trigger_set() error handling
Date: Thu, 05 Sep 2019 13:32:34 +0000 [thread overview]
Message-ID: <20190905133233.GF3093@kadam> (raw)
In-Reply-To: <BC1CA967-2B9F-44A4-A1A9-FD9C6E874991@kaa.org.ua>
On Thu, Sep 05, 2019 at 03:23:21PM +0300, Oleh Kravchenko wrote:
> Let me summarize the chronology of the last activities below:
> 1. I have sent the patch for the bugs that I have found by static analyzer at PVS-Studio
> Date: Wed, 4 Sep 2019 00:18:19 +0300
> https://www.spinics.net/lists/linux-leds/msg13181.html
>
> 2. At 5 Sep 2019 12:57:19 +0300 Time Dan Cartpen has sent the patch with the same proposal
> 3. Uwe Kleine-König started to discuss his results of review by asking Dan on how he was found it.
>
> Would you mine if you will keep me as a Original author of this patch based on fact 1?
Heh.
No, I didn't steal your patch. :P I am the author of the Smatch static
analysis tool and mostly fix things found by Smatch. I don't use other
static analysis tools except to do a final QC of my patches.
It's super common for people to send duplicate fixes when it's based on
static analysis. Most of the static analysis people hang out on
kernel-janitors so we don't send duplicate patches. For a while people
were getting annoyed by all the duplicates but now they accept it as
their punishment for introducing a bug in the first place.
Anyway, the rule for kernel development is that normally the first
person's patch goes in, so we will take your patch.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-05 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 9:57 [PATCH] led: triggers: Fix NULL dereference in led_trigger_set() error handling Dan Carpenter
2019-09-05 9:57 ` Dan Carpenter
2019-09-05 11:22 ` Oleh Kravchenko
2019-09-05 11:22 ` Oleh Kravchenko
2019-09-05 12:06 ` Uwe Kleine-König
2019-09-05 12:06 ` Uwe Kleine-König
2019-09-05 12:23 ` Oleh Kravchenko
2019-09-05 12:23 ` Oleh Kravchenko
2019-09-05 12:46 ` Uwe Kleine-König
2019-09-05 12:46 ` Uwe Kleine-König
2019-09-05 20:41 ` Jacek Anaszewski
2019-09-05 20:41 ` Jacek Anaszewski
2019-09-05 13:32 ` Dan Carpenter [this message]
2019-09-05 13:32 ` Dan Carpenter
2019-09-08 9:46 ` Oleh Kravchenko
2019-09-08 9:46 ` Oleh Kravchenko
2019-09-05 12:39 ` Oleh Kravchenko
2019-09-05 12:39 ` Oleh Kravchenko
2019-09-05 13:04 ` Dan Carpenter
2019-09-05 13:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905133233.GF3093@kadam \
--to=dan.carpenter@oracle.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.