* [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig
@ 2019-09-06 7:40 Sébastien Szymanski
2019-09-06 7:40 ` [U-Boot] [PATCH 2/2] configs: opos6uldev: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Sébastien Szymanski
2019-09-09 1:59 ` [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Peng Fan
0 siblings, 2 replies; 6+ messages in thread
From: Sébastien Szymanski @ 2019-09-06 7:40 UTC (permalink / raw)
To: u-boot
This converts the following to Kconfig:
CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
configs/warp7_defconfig | 1 +
configs/warp_defconfig | 1 +
drivers/mmc/Kconfig | 6 ++++++
include/configs/warp.h | 1 -
include/configs/warp7.h | 1 -
scripts/config_whitelist.txt | 1 -
6 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
index a022454976..9a167d2c43 100644
--- a/configs/warp7_defconfig
+++ b/configs/warp7_defconfig
@@ -40,6 +40,7 @@ CONFIG_DM_I2C=y
CONFIG_DM_MMC=y
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_FSL_USDHC=y
+CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX7=y
CONFIG_DM_PMIC=y
diff --git a/configs/warp_defconfig b/configs/warp_defconfig
index 7a6ea6f8c6..d719dc779a 100644
--- a/configs/warp_defconfig
+++ b/configs/warp_defconfig
@@ -31,6 +31,7 @@ CONFIG_ENV_IS_IN_MMC=y
CONFIG_DFU_MMC=y
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_FSL_USDHC=y
+CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
CONFIG_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_GADGET=y
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index 0ccb1ea701..f61b17b86b 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -701,6 +701,12 @@ config FSL_USDHC
help
This enables the Ultra Secured Digital Host Controller enhancements
+config SYS_FSL_ESDHC_HAS_DDR_MODE
+ depends on FSL_ESDHC || FSL_ESDHC_IMX
+ bool "Enable Dual Data Rate support"
+ help
+ This enables Dual Data Rate support (DDR52)
+
endmenu
config SYS_FSL_ERRATUM_ESDHC111
diff --git a/include/configs/warp.h b/include/configs/warp.h
index 5345f5314d..a00c535b50 100644
--- a/include/configs/warp.h
+++ b/include/configs/warp.h
@@ -22,7 +22,6 @@
/* MMC Configs */
#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC2_BASE_ADDR
-#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
/* Watchdog */
#define CONFIG_WATCHDOG_TIMEOUT_MSECS 30000 /* 30s */
diff --git a/include/configs/warp7.h b/include/configs/warp7.h
index 73541fe176..aa259cd9ef 100644
--- a/include/configs/warp7.h
+++ b/include/configs/warp7.h
@@ -18,7 +18,6 @@
/* MMC Config*/
#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
-#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
#define CONFIG_SYS_MMC_IMG_LOAD_PART 1
/* Switch on SERIAL_TAG */
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index b18eab1707..49c041b59e 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -2555,7 +2555,6 @@ CONFIG_SYS_FSL_ERRATUM_A_004934
CONFIG_SYS_FSL_ESDHC_ADDR
CONFIG_SYS_FSL_ESDHC_BE
CONFIG_SYS_FSL_ESDHC_BROKEN_TIMEOUT
-CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
CONFIG_SYS_FSL_ESDHC_LE
CONFIG_SYS_FSL_ESDHC_NUM
CONFIG_SYS_FSL_ESDHC_P1010_BROKEN_SDCLK
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] configs: opos6uldev: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
2019-09-06 7:40 [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Sébastien Szymanski
@ 2019-09-06 7:40 ` Sébastien Szymanski
2019-09-09 1:59 ` [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Peng Fan
1 sibling, 0 replies; 6+ messages in thread
From: Sébastien Szymanski @ 2019-09-06 7:40 UTC (permalink / raw)
To: u-boot
This significally increases performance:
reading zImage, without DDR:
6203640 bytes read in 157 ms (37.7 MiB/s)
reading zImage, with DDR:
6203640 bytes read in 88 ms (67.2 MiB/s)
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
configs/opos6uldev_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/opos6uldev_defconfig b/configs/opos6uldev_defconfig
index 1b68b8e12f..50450a7114 100644
--- a/configs/opos6uldev_defconfig
+++ b/configs/opos6uldev_defconfig
@@ -70,6 +70,7 @@ CONFIG_SYS_I2C_MXC=y
CONFIG_PWRSEQ=y
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_FSL_USDHC=y
+CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
CONFIG_PHYLIB=y
CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ8XXX=y
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig
2019-09-06 7:40 [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Sébastien Szymanski
2019-09-06 7:40 ` [U-Boot] [PATCH 2/2] configs: opos6uldev: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Sébastien Szymanski
@ 2019-09-09 1:59 ` Peng Fan
2019-09-09 6:35 ` Sébastien Szymanski
1 sibling, 1 reply; 6+ messages in thread
From: Peng Fan @ 2019-09-09 1:59 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to
> Kconfig
>
> This converts the following to Kconfig:
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> configs/warp7_defconfig | 1 +
> configs/warp_defconfig | 1 +
> drivers/mmc/Kconfig | 6 ++++++
> include/configs/warp.h | 1 -
> include/configs/warp7.h | 1 -
> scripts/config_whitelist.txt | 1 -
> 6 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index
> a022454976..9a167d2c43 100644
> --- a/configs/warp7_defconfig
> +++ b/configs/warp7_defconfig
> @@ -40,6 +40,7 @@ CONFIG_DM_I2C=y
> CONFIG_DM_MMC=y
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_FSL_USDHC=y
> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> CONFIG_PINCTRL=y
> CONFIG_PINCTRL_IMX7=y
> CONFIG_DM_PMIC=y
> diff --git a/configs/warp_defconfig b/configs/warp_defconfig index
> 7a6ea6f8c6..d719dc779a 100644
> --- a/configs/warp_defconfig
> +++ b/configs/warp_defconfig
> @@ -31,6 +31,7 @@ CONFIG_ENV_IS_IN_MMC=y CONFIG_DFU_MMC=y
> CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y
> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> CONFIG_USB=y
> CONFIG_USB_STORAGE=y
> CONFIG_USB_GADGET=y
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
> 0ccb1ea701..f61b17b86b 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -701,6 +701,12 @@ config FSL_USDHC
> help
> This enables the Ultra Secured Digital Host Controller enhancements
>
> +config SYS_FSL_ESDHC_HAS_DDR_MODE
> + depends on FSL_ESDHC || FSL_ESDHC_IMX
Please drop FSL_ESDHC.
Regards,
Peng.
> + bool "Enable Dual Data Rate support"
> + help
> + This enables Dual Data Rate support (DDR52)
> +
> endmenu
>
> config SYS_FSL_ERRATUM_ESDHC111
> diff --git a/include/configs/warp.h b/include/configs/warp.h index
> 5345f5314d..a00c535b50 100644
> --- a/include/configs/warp.h
> +++ b/include/configs/warp.h
> @@ -22,7 +22,6 @@
>
> /* MMC Configs */
> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC2_BASE_ADDR
> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>
> /* Watchdog */
> #define CONFIG_WATCHDOG_TIMEOUT_MSECS 30000 /* 30s */ diff --git
> a/include/configs/warp7.h b/include/configs/warp7.h index
> 73541fe176..aa259cd9ef 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -18,7 +18,6 @@
>
> /* MMC Config*/
> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>
> /* Switch on SERIAL_TAG */
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index
> b18eab1707..49c041b59e 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -2555,7 +2555,6 @@ CONFIG_SYS_FSL_ERRATUM_A_004934
> CONFIG_SYS_FSL_ESDHC_ADDR CONFIG_SYS_FSL_ESDHC_BE
> CONFIG_SYS_FSL_ESDHC_BROKEN_TIMEOUT
> -CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> CONFIG_SYS_FSL_ESDHC_LE
> CONFIG_SYS_FSL_ESDHC_NUM
> CONFIG_SYS_FSL_ESDHC_P1010_BROKEN_SDCLK
> --
> 2.21.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig
2019-09-09 1:59 ` [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Peng Fan
@ 2019-09-09 6:35 ` Sébastien Szymanski
2019-09-10 1:28 ` Peng Fan
0 siblings, 1 reply; 6+ messages in thread
From: Sébastien Szymanski @ 2019-09-09 6:35 UTC (permalink / raw)
To: u-boot
Hello,
On 9/9/19 3:59 AM, Peng Fan wrote:
>> Subject: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to
>> Kconfig
>>
>> This converts the following to Kconfig:
>>
>> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>>
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>> ---
>> configs/warp7_defconfig | 1 +
>> configs/warp_defconfig | 1 +
>> drivers/mmc/Kconfig | 6 ++++++
>> include/configs/warp.h | 1 -
>> include/configs/warp7.h | 1 -
>> scripts/config_whitelist.txt | 1 -
>> 6 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index
>> a022454976..9a167d2c43 100644
>> --- a/configs/warp7_defconfig
>> +++ b/configs/warp7_defconfig
>> @@ -40,6 +40,7 @@ CONFIG_DM_I2C=y
>> CONFIG_DM_MMC=y
>> CONFIG_SUPPORT_EMMC_BOOT=y
>> CONFIG_FSL_USDHC=y
>> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
>> CONFIG_PINCTRL=y
>> CONFIG_PINCTRL_IMX7=y
>> CONFIG_DM_PMIC=y
>> diff --git a/configs/warp_defconfig b/configs/warp_defconfig index
>> 7a6ea6f8c6..d719dc779a 100644
>> --- a/configs/warp_defconfig
>> +++ b/configs/warp_defconfig
>> @@ -31,6 +31,7 @@ CONFIG_ENV_IS_IN_MMC=y CONFIG_DFU_MMC=y
>> CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y
>> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
>> CONFIG_USB=y
>> CONFIG_USB_STORAGE=y
>> CONFIG_USB_GADGET=y
>> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
>> 0ccb1ea701..f61b17b86b 100644
>> --- a/drivers/mmc/Kconfig
>> +++ b/drivers/mmc/Kconfig
>> @@ -701,6 +701,12 @@ config FSL_USDHC
>> help
>> This enables the Ultra Secured Digital Host Controller enhancements
>>
>> +config SYS_FSL_ESDHC_HAS_DDR_MODE
>> + depends on FSL_ESDHC || FSL_ESDHC_IMX
>
> Please drop FSL_ESDHC.
Why ? SYS_FSL_ESDHC_HAS_DDR_MODE is used in fsl_esdhc.c too.
Regards,
>
> Regards,
> Peng.
>
>> + bool "Enable Dual Data Rate support"
>> + help
>> + This enables Dual Data Rate support (DDR52)
>> +
>> endmenu
>>
>> config SYS_FSL_ERRATUM_ESDHC111
>> diff --git a/include/configs/warp.h b/include/configs/warp.h index
>> 5345f5314d..a00c535b50 100644
>> --- a/include/configs/warp.h
>> +++ b/include/configs/warp.h
>> @@ -22,7 +22,6 @@
>>
>> /* MMC Configs */
>> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC2_BASE_ADDR
>> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>>
>> /* Watchdog */
>> #define CONFIG_WATCHDOG_TIMEOUT_MSECS 30000 /* 30s */ diff --git
>> a/include/configs/warp7.h b/include/configs/warp7.h index
>> 73541fe176..aa259cd9ef 100644
>> --- a/include/configs/warp7.h
>> +++ b/include/configs/warp7.h
>> @@ -18,7 +18,6 @@
>>
>> /* MMC Config*/
>> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
>> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>>
>> /* Switch on SERIAL_TAG */
>> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index
>> b18eab1707..49c041b59e 100644
>> --- a/scripts/config_whitelist.txt
>> +++ b/scripts/config_whitelist.txt
>> @@ -2555,7 +2555,6 @@ CONFIG_SYS_FSL_ERRATUM_A_004934
>> CONFIG_SYS_FSL_ESDHC_ADDR CONFIG_SYS_FSL_ESDHC_BE
>> CONFIG_SYS_FSL_ESDHC_BROKEN_TIMEOUT
>> -CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
>> CONFIG_SYS_FSL_ESDHC_LE
>> CONFIG_SYS_FSL_ESDHC_NUM
>> CONFIG_SYS_FSL_ESDHC_P1010_BROKEN_SDCLK
>> --
>> 2.21.0
>
--
Sébastien Szymanski, Armadeus Systems
Software engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig
2019-09-09 6:35 ` Sébastien Szymanski
@ 2019-09-10 1:28 ` Peng Fan
2019-09-10 8:10 ` Y.b. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Peng Fan @ 2019-09-10 1:28 UTC (permalink / raw)
To: u-boot
+Y.b
> -----Original Message-----
> From: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> Sent: 2019年9月9日 14:36
> To: Peng Fan <peng.fan@nxp.com>; u-boot at lists.denx.de
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; Otavio Salvador
> <otavio@ossystems.com.br>
> Subject: Re: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> to Kconfig
>
> Hello,
>
> On 9/9/19 3:59 AM, Peng Fan wrote:
> >> Subject: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> to
> >> Kconfig
> >>
> >> This converts the following to Kconfig:
> >>
> >> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> >>
> >> Signed-off-by: Sébastien Szymanski
> <sebastien.szymanski@armadeus.com>
> >> ---
> >> configs/warp7_defconfig | 1 +
> >> configs/warp_defconfig | 1 +
> >> drivers/mmc/Kconfig | 6 ++++++
> >> include/configs/warp.h | 1 -
> >> include/configs/warp7.h | 1 -
> >> scripts/config_whitelist.txt | 1 -
> >> 6 files changed, 8 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index
> >> a022454976..9a167d2c43 100644
> >> --- a/configs/warp7_defconfig
> >> +++ b/configs/warp7_defconfig
> >> @@ -40,6 +40,7 @@ CONFIG_DM_I2C=y
> >> CONFIG_DM_MMC=y
> >> CONFIG_SUPPORT_EMMC_BOOT=y
> >> CONFIG_FSL_USDHC=y
> >> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> >> CONFIG_PINCTRL=y
> >> CONFIG_PINCTRL_IMX7=y
> >> CONFIG_DM_PMIC=y
> >> diff --git a/configs/warp_defconfig b/configs/warp_defconfig index
> >> 7a6ea6f8c6..d719dc779a 100644
> >> --- a/configs/warp_defconfig
> >> +++ b/configs/warp_defconfig
> >> @@ -31,6 +31,7 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_DFU_MMC=y
> >> CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y
> >> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> >> CONFIG_USB=y
> >> CONFIG_USB_STORAGE=y
> >> CONFIG_USB_GADGET=y
> >> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
> >> 0ccb1ea701..f61b17b86b 100644
> >> --- a/drivers/mmc/Kconfig
> >> +++ b/drivers/mmc/Kconfig
> >> @@ -701,6 +701,12 @@ config FSL_USDHC
> >> help
> >> This enables the Ultra Secured Digital Host Controller
> >> enhancements
> >>
> >> +config SYS_FSL_ESDHC_HAS_DDR_MODE
> >> + depends on FSL_ESDHC || FSL_ESDHC_IMX
> >
> > Please drop FSL_ESDHC.
>
> Why ? SYS_FSL_ESDHC_HAS_DDR_MODE is used in fsl_esdhc.c too.
Y.b, is this currently used by fsl_esdhc.c?
Thanks,
Peng.
>
> Regards,
>
> >
> > Regards,
> > Peng.
> >
> >> + bool "Enable Dual Data Rate support"
> >> + help
> >> + This enables Dual Data Rate support (DDR52)
> >> +
> >> endmenu
> >>
> >> config SYS_FSL_ERRATUM_ESDHC111
> >> diff --git a/include/configs/warp.h b/include/configs/warp.h index
> >> 5345f5314d..a00c535b50 100644
> >> --- a/include/configs/warp.h
> >> +++ b/include/configs/warp.h
> >> @@ -22,7 +22,6 @@
> >>
> >> /* MMC Configs */
> >> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC2_BASE_ADDR
> >> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> >>
> >> /* Watchdog */
> >> #define CONFIG_WATCHDOG_TIMEOUT_MSECS 30000 /* 30s */ diff
> --git
> >> a/include/configs/warp7.h b/include/configs/warp7.h index
> >> 73541fe176..aa259cd9ef 100644
> >> --- a/include/configs/warp7.h
> >> +++ b/include/configs/warp7.h
> >> @@ -18,7 +18,6 @@
> >>
> >> /* MMC Config*/
> >> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
> >> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> >> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
> >>
> >> /* Switch on SERIAL_TAG */
> >> diff --git a/scripts/config_whitelist.txt
> >> b/scripts/config_whitelist.txt index b18eab1707..49c041b59e 100644
> >> --- a/scripts/config_whitelist.txt
> >> +++ b/scripts/config_whitelist.txt
> >> @@ -2555,7 +2555,6 @@ CONFIG_SYS_FSL_ERRATUM_A_004934
> >> CONFIG_SYS_FSL_ESDHC_ADDR CONFIG_SYS_FSL_ESDHC_BE
> >> CONFIG_SYS_FSL_ESDHC_BROKEN_TIMEOUT
> >> -CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> >> CONFIG_SYS_FSL_ESDHC_LE
> >> CONFIG_SYS_FSL_ESDHC_NUM
> >> CONFIG_SYS_FSL_ESDHC_P1010_BROKEN_SDCLK
> >> --
> >> 2.21.0
> >
> --
> Sébastien Szymanski, Armadeus Systems
> Software engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig
2019-09-10 1:28 ` Peng Fan
@ 2019-09-10 8:10 ` Y.b. Lu
0 siblings, 0 replies; 6+ messages in thread
From: Y.b. Lu @ 2019-09-10 8:10 UTC (permalink / raw)
To: u-boot
Hi,
> -----Original Message-----
> From: Peng Fan
> Sent: Tuesday, September 10, 2019 9:29 AM
> To: Sébastien Szymanski <sebastien.szymanski@armadeus.com>;
> u-boot at lists.denx.de; Y.b. Lu <yangbo.lu@nxp.com>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; Otavio Salvador
> <otavio@ossystems.com.br>
> Subject: RE: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> to Kconfig
>
> +Y.b
>
> > -----Original Message-----
> > From: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> > Sent: 2019年9月9日 14:36
> > To: Peng Fan <peng.fan@nxp.com>; u-boot at lists.denx.de
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>; Otavio Salvador
> > <otavio@ossystems.com.br>
> > Subject: Re: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> to
> > Kconfig
> >
> > Hello,
> >
> > On 9/9/19 3:59 AM, Peng Fan wrote:
> > >> Subject: [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> > to
> > >> Kconfig
> > >>
> > >> This converts the following to Kconfig:
> > >>
> > >> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> > >>
> > >> Signed-off-by: Sébastien Szymanski
> > <sebastien.szymanski@armadeus.com>
> > >> ---
> > >> configs/warp7_defconfig | 1 +
> > >> configs/warp_defconfig | 1 +
> > >> drivers/mmc/Kconfig | 6 ++++++
> > >> include/configs/warp.h | 1 -
> > >> include/configs/warp7.h | 1 -
> > >> scripts/config_whitelist.txt | 1 -
> > >> 6 files changed, 8 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
> > >> index
> > >> a022454976..9a167d2c43 100644
> > >> --- a/configs/warp7_defconfig
> > >> +++ b/configs/warp7_defconfig
> > >> @@ -40,6 +40,7 @@ CONFIG_DM_I2C=y
> > >> CONFIG_DM_MMC=y
> > >> CONFIG_SUPPORT_EMMC_BOOT=y
> > >> CONFIG_FSL_USDHC=y
> > >> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> > >> CONFIG_PINCTRL=y
> > >> CONFIG_PINCTRL_IMX7=y
> > >> CONFIG_DM_PMIC=y
> > >> diff --git a/configs/warp_defconfig b/configs/warp_defconfig index
> > >> 7a6ea6f8c6..d719dc779a 100644
> > >> --- a/configs/warp_defconfig
> > >> +++ b/configs/warp_defconfig
> > >> @@ -31,6 +31,7 @@ CONFIG_ENV_IS_IN_MMC=y
> > CONFIG_DFU_MMC=y
> > >> CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y
> > >> +CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE=y
> > >> CONFIG_USB=y
> > >> CONFIG_USB_STORAGE=y
> > >> CONFIG_USB_GADGET=y
> > >> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
> > >> 0ccb1ea701..f61b17b86b 100644
> > >> --- a/drivers/mmc/Kconfig
> > >> +++ b/drivers/mmc/Kconfig
> > >> @@ -701,6 +701,12 @@ config FSL_USDHC
> > >> help
> > >> This enables the Ultra Secured Digital Host Controller
> > >> enhancements
> > >>
> > >> +config SYS_FSL_ESDHC_HAS_DDR_MODE
> > >> + depends on FSL_ESDHC || FSL_ESDHC_IMX
> > >
> > > Please drop FSL_ESDHC.
> >
> > Why ? SYS_FSL_ESDHC_HAS_DDR_MODE is used in fsl_esdhc.c too.
>
> Y.b, is this currently used by fsl_esdhc.c?
[Y.b. Lu] Yes. This was introduced before fsl_esdhc_imx.c was split out. The patch introducing it was as below.
0e1bf61 mmc: fsl_esdhc: Add support for DDR mode
This was for i.mx eSDHC actually. I should remove SYS_FSL_ESDHC_HAS_DDR_MODE for fsl_esdhc.c.
Although fsl_esdhc supports DDR52, the RCW (reset configure words) for SoC and FPGA should be configured accordingly (for SDHC_CLK_SYNC_OUT/IN signals) to support it.
So let me send a patch to remove it. You can feel free to add it in your new version patch too.
BTW, I think "mmc-ddr-1_8v" dts property is a good idea instead of config option.
Thanks.
>
> Thanks,
> Peng.
>
> >
> > Regards,
> >
> > >
> > > Regards,
> > > Peng.
> > >
> > >> + bool "Enable Dual Data Rate support"
> > >> + help
> > >> + This enables Dual Data Rate support (DDR52)
> > >> +
> > >> endmenu
> > >>
> > >> config SYS_FSL_ERRATUM_ESDHC111
> > >> diff --git a/include/configs/warp.h b/include/configs/warp.h index
> > >> 5345f5314d..a00c535b50 100644
> > >> --- a/include/configs/warp.h
> > >> +++ b/include/configs/warp.h
> > >> @@ -22,7 +22,6 @@
> > >>
> > >> /* MMC Configs */
> > >> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC2_BASE_ADDR
> > >> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> > >>
> > >> /* Watchdog */
> > >> #define CONFIG_WATCHDOG_TIMEOUT_MSECS 30000 /* 30s */ diff
> > --git
> > >> a/include/configs/warp7.h b/include/configs/warp7.h index
> > >> 73541fe176..aa259cd9ef 100644
> > >> --- a/include/configs/warp7.h
> > >> +++ b/include/configs/warp7.h
> > >> @@ -18,7 +18,6 @@
> > >>
> > >> /* MMC Config*/
> > >> #define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
> > >> -#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> > >> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
> > >>
> > >> /* Switch on SERIAL_TAG */
> > >> diff --git a/scripts/config_whitelist.txt
> > >> b/scripts/config_whitelist.txt index b18eab1707..49c041b59e 100644
> > >> --- a/scripts/config_whitelist.txt
> > >> +++ b/scripts/config_whitelist.txt
> > >> @@ -2555,7 +2555,6 @@ CONFIG_SYS_FSL_ERRATUM_A_004934
> > >> CONFIG_SYS_FSL_ESDHC_ADDR CONFIG_SYS_FSL_ESDHC_BE
> > >> CONFIG_SYS_FSL_ESDHC_BROKEN_TIMEOUT
> > >> -CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> > >> CONFIG_SYS_FSL_ESDHC_LE
> > >> CONFIG_SYS_FSL_ESDHC_NUM
> > >> CONFIG_SYS_FSL_ESDHC_P1010_BROKEN_SDCLK
> > >> --
> > >> 2.21.0
> > >
> > --
> > Sébastien Szymanski, Armadeus Systems
> > Software engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-10 8:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 7:40 [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Sébastien Szymanski
2019-09-06 7:40 ` [U-Boot] [PATCH 2/2] configs: opos6uldev: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Sébastien Szymanski
2019-09-09 1:59 ` [U-Boot] [PATCH 1/2] Convert CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE to Kconfig Peng Fan
2019-09-09 6:35 ` Sébastien Szymanski
2019-09-10 1:28 ` Peng Fan
2019-09-10 8:10 ` Y.b. Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.