All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: miklos@szeredi.hu, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, virtio-fs@redhat.com,
	stefanha@redhat.com, linux-fsdevel@vger.kernel.org,
	dgilbert@redhat.com
Subject: Re: [PATCH 00/18] virtiofs: Fix various races and cleanups round 1
Date: Fri, 6 Sep 2019 09:37:26 -0400	[thread overview]
Message-ID: <20190906093703-mutt-send-email-mst__41607.8432391927$1567777109$gmane$org@kernel.org> (raw)
In-Reply-To: <20190905194859.16219-1-vgoyal@redhat.com>

On Thu, Sep 05, 2019 at 03:48:41PM -0400, Vivek Goyal wrote:
> Hi,
> 
> Michael Tsirkin pointed out issues w.r.t various locking related TODO
> items and races w.r.t device removal. 
> 
> In this first round of cleanups, I have taken care of most pressing
> issues.
> 
> These patches apply on top of following.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4
> 
> I have tested these patches with mount/umount and device removal using
> qemu monitor. For example.
> 
> virsh qemu-monitor-command --hmp vm9-f28 device_del myvirtiofs
> 
> Now a mounted device can be removed and file system will return errors
> -ENOTCONN and one can unmount it.
> 
> Miklos, if you are fine with the patches, I am fine if you fold these
> all into existing patch. I kept them separate so that review is easier.
> 
> Any feedback or comments are welcome.
> 
> Thanks
> Vivek
> 


Another version of a patch with fixes all rolled in would also
be nice.
> Vivek Goyal (18):
>   virtiofs: Remove request from processing list before calling end
>   virtiofs: Check whether hiprio queue is connected at submission time
>   virtiofs: Pass fsvq instead of vq as parameter to
>     virtio_fs_enqueue_req
>   virtiofs: Check connected state for VQ_REQUEST queue as well
>   Maintain count of in flight requests for VQ_REQUEST queue
>   virtiofs: ->remove should not clean virtiofs fuse devices
>   virtiofs: Stop virtiofs queues when device is being removed
>   virtiofs: Drain all pending requests during ->remove time
>   virtiofs: Add an helper to start all the queues
>   virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vq
>   virtiofs: stop and drain queues after sending DESTROY
>   virtiofs: Use virtio_fs_free_devs() in error path
>   virtiofs: Do not access virtqueue in request submission path
>   virtiofs: Add a fuse_iqueue operation to put() reference
>   virtiofs: Make virtio_fs object refcounted
>   virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path
>   virtiofs: Remove TODO to quiesce/end_requests
>   virtiofs: Remove TODO item from virtio_fs_free_devs()
> 
>  fs/fuse/fuse_i.h    |   5 +
>  fs/fuse/inode.c     |   6 +
>  fs/fuse/virtio_fs.c | 259 ++++++++++++++++++++++++++++++++------------
>  3 files changed, 198 insertions(+), 72 deletions(-)
> 
> -- 
> 2.20.1

  parent reply	other threads:[~2019-09-06 13:37 UTC|newest]

Thread overview: 177+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 19:48 [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 Vivek Goyal
2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal
2019-09-05 19:48 ` [PATCH 01/18] virtiofs: Remove request from processing list before calling end Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-05 19:48   ` Vivek Goyal
2019-09-06 10:40   ` Stefan Hajnoczi
2019-09-06 10:40   ` Stefan Hajnoczi
2019-09-06 10:40     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 02/18] virtiofs: Check whether hiprio queue is connected at submission time Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:43   ` Stefan Hajnoczi
2019-09-06 10:43   ` Stefan Hajnoczi
2019-09-06 10:43     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 03/18] virtiofs: Pass fsvq instead of vq as parameter to virtio_fs_enqueue_req Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-05 19:48   ` Vivek Goyal
2019-09-06 10:44   ` Stefan Hajnoczi
2019-09-06 10:44     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:44   ` Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 04/18] virtiofs: Check connected state for VQ_REQUEST queue as well Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:45   ` Stefan Hajnoczi
2019-09-06 10:45   ` Stefan Hajnoczi
2019-09-06 10:45     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 05/18] Maintain count of in flight requests for VQ_REQUEST queue Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:46   ` Stefan Hajnoczi
2019-09-06 10:46     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:46   ` Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 06/18] virtiofs: ->remove should not clean virtiofs fuse devices Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:47   ` Stefan Hajnoczi
2019-09-06 10:47     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:47   ` Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 07/18] virtiofs: Stop virtiofs queues when device is being removed Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:47   ` Stefan Hajnoczi
2019-09-06 10:47     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:47   ` Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 08/18] virtiofs: Drain all pending requests during ->remove time Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-05 19:48   ` Vivek Goyal
2019-09-06 10:52   ` Stefan Hajnoczi
2019-09-06 10:52   ` Stefan Hajnoczi
2019-09-06 10:52     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 14:17     ` Vivek Goyal
2019-09-06 14:17     ` Vivek Goyal
2019-09-06 14:17       ` [Virtio-fs] " Vivek Goyal
2019-09-06 14:18       ` Michael S. Tsirkin
2019-09-06 14:18       ` Michael S. Tsirkin
2019-09-06 14:18         ` [Virtio-fs] " Michael S. Tsirkin
2019-09-09 16:10         ` Stefan Hajnoczi
2019-09-09 16:10           ` [Virtio-fs] " Stefan Hajnoczi
2019-09-09 16:10         ` Stefan Hajnoczi
2019-09-08 10:11   ` [Virtio-fs] " piaojun
2019-09-08 10:11     ` piaojun
2019-09-05 19:48 ` [PATCH 09/18] virtiofs: Add an helper to start all the queues Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:54   ` Stefan Hajnoczi
2019-09-06 10:54     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:54   ` Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 10/18] virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vq Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 10:56   ` Stefan Hajnoczi
2019-09-06 10:56     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 10:56   ` Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 11/18] virtiofs: stop and drain queues after sending DESTROY Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 11:50   ` Stefan Hajnoczi
2019-09-06 11:50     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 11:50     ` Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 12/18] virtiofs: Use virtio_fs_free_devs() in error path Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 11:51   ` Stefan Hajnoczi
2019-09-06 11:51     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 11:51   ` Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 13/18] virtiofs: Do not access virtqueue in request submission path Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 11:52   ` Stefan Hajnoczi
2019-09-06 11:52   ` Stefan Hajnoczi
2019-09-06 11:52     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 14/18] virtiofs: Add a fuse_iqueue operation to put() reference Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 12:00   ` Stefan Hajnoczi
2019-09-06 12:00   ` Stefan Hajnoczi
2019-09-06 12:00     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 13:35     ` Vivek Goyal
2019-09-06 13:35     ` Vivek Goyal
2019-09-06 13:35       ` [Virtio-fs] " Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 15/18] virtiofs: Make virtio_fs object refcounted Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 12:03   ` Stefan Hajnoczi
2019-09-06 12:03   ` Stefan Hajnoczi
2019-09-06 12:03     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 13:50     ` Vivek Goyal
2019-09-06 13:50     ` Vivek Goyal
2019-09-06 13:50       ` [Virtio-fs] " Vivek Goyal
2019-09-09 16:12       ` Stefan Hajnoczi
2019-09-09 16:12         ` [Virtio-fs] " Stefan Hajnoczi
2019-09-09 16:12         ` Stefan Hajnoczi
2019-09-08 11:10   ` [Virtio-fs] " piaojun
2019-09-08 11:10     ` piaojun
2019-09-09 15:35     ` Vivek Goyal
2019-09-09 15:35       ` Vivek Goyal
2019-09-09 15:35     ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 12:05   ` Stefan Hajnoczi
2019-09-06 12:05   ` Stefan Hajnoczi
2019-09-06 12:05     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 13:51     ` Vivek Goyal
2019-09-06 13:51       ` [Virtio-fs] " Vivek Goyal
2019-09-09 16:13       ` Stefan Hajnoczi
2019-09-09 16:13       ` Stefan Hajnoczi
2019-09-09 16:13         ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 13:51     ` Vivek Goyal
2019-09-08 11:19   ` [Virtio-fs] " piaojun
2019-09-08 11:19     ` piaojun
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48 ` [PATCH 17/18] virtiofs: Remove TODO to quiesce/end_requests Vivek Goyal
2019-09-05 19:48 ` Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 12:06   ` Stefan Hajnoczi
2019-09-06 12:06     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 12:06   ` Stefan Hajnoczi
2019-09-05 19:48 ` [PATCH 18/18] virtiofs: Remove TODO item from virtio_fs_free_devs() Vivek Goyal
2019-09-05 19:48   ` [Virtio-fs] " Vivek Goyal
2019-09-06 12:06   ` Stefan Hajnoczi
2019-09-06 12:06   ` Stefan Hajnoczi
2019-09-06 12:06     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-05 19:48 ` Vivek Goyal
2019-09-06  8:15 ` [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 Miklos Szeredi
2019-09-06  8:15   ` [Virtio-fs] " Miklos Szeredi
2019-09-06 10:36   ` Stefan Hajnoczi
2019-09-06 10:36     ` [Virtio-fs] " Stefan Hajnoczi
2019-09-06 11:52     ` Miklos Szeredi
2019-09-06 11:52       ` [Virtio-fs] " Miklos Szeredi
2019-09-06 12:08       ` Vivek Goyal
2019-09-06 12:08       ` Vivek Goyal
2019-09-06 12:08         ` [Virtio-fs] " Vivek Goyal
2019-09-06 13:55         ` Miklos Szeredi
2019-09-06 13:55           ` [Virtio-fs] " Miklos Szeredi
2019-09-06 13:57         ` Michael S. Tsirkin
2019-09-06 13:57           ` [Virtio-fs] " Michael S. Tsirkin
2019-09-06 13:57           ` Michael S. Tsirkin
2019-09-06 14:11           ` Miklos Szeredi
2019-09-06 14:11             ` [Virtio-fs] " Miklos Szeredi
2019-09-06 14:17             ` Michael S. Tsirkin
2019-09-06 14:17             ` Michael S. Tsirkin
2019-09-06 14:17               ` [Virtio-fs] " Michael S. Tsirkin
2019-09-08 11:53       ` piaojun
2019-09-08 11:53         ` piaojun
2019-09-09 16:14         ` Stefan Hajnoczi
2019-09-09 16:14         ` Stefan Hajnoczi
2019-09-09 16:14           ` Stefan Hajnoczi
2019-09-09 16:18           ` Michael S. Tsirkin
2019-09-09 16:18             ` Michael S. Tsirkin
2019-09-09 16:18           ` Michael S. Tsirkin
2019-09-09 23:52           ` piaojun
2019-09-09 23:52             ` piaojun
2019-09-06 10:36   ` Stefan Hajnoczi
2019-09-06 13:37 ` Michael S. Tsirkin [this message]
2019-09-06 13:37 ` Michael S. Tsirkin
2019-09-06 13:37   ` [Virtio-fs] " Michael S. Tsirkin
2019-09-05 19:48 Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190906093703-mutt-send-email-mst__41607.8432391927$1567777109$gmane$org@kernel.org' \
    --to=mst@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.