From: Vivek Goyal <vgoyal@redhat.com> To: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, miklos@szeredi.hu Cc: linux-kernel@vger.kernel.org, virtio-fs@redhat.com, vgoyal@redhat.com, stefanha@redhat.com, dgilbert@redhat.com, mst@redhat.com Subject: [PATCH 04/18] virtiofs: Check connected state for VQ_REQUEST queue as well Date: Thu, 5 Sep 2019 15:48:45 -0400 [thread overview] Message-ID: <20190905194859.16219-5-vgoyal@redhat.com> (raw) In-Reply-To: <20190905194859.16219-1-vgoyal@redhat.com> Right now we are checking ->connected state only for VQ_HIPRIO. Now we want to make use of this method for all queues. So check it for VQ_REQUEST as well. This will be helpful if device has been removed and virtqueue is gone. In that case ->connected will be false and request can't be submitted anymore and user space will see error -ENOTCONN. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- fs/fuse/virtio_fs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 9d30530e3ca9..c46dd4d284d6 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -755,6 +755,12 @@ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, spin_lock(&fsvq->lock); + if (!fsvq->connected) { + spin_unlock(&fsvq->lock); + ret = -ENOTCONN; + goto out; + } + vq = fsvq->vq; ret = virtqueue_add_sgs(vq, sgs, out_sgs, in_sgs, req, GFP_ATOMIC); if (ret < 0) { -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, miklos@szeredi.hu Cc: mst@redhat.com, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, vgoyal@redhat.com Subject: [Virtio-fs] [PATCH 04/18] virtiofs: Check connected state for VQ_REQUEST queue as well Date: Thu, 5 Sep 2019 15:48:45 -0400 [thread overview] Message-ID: <20190905194859.16219-5-vgoyal@redhat.com> (raw) In-Reply-To: <20190905194859.16219-1-vgoyal@redhat.com> Right now we are checking ->connected state only for VQ_HIPRIO. Now we want to make use of this method for all queues. So check it for VQ_REQUEST as well. This will be helpful if device has been removed and virtqueue is gone. In that case ->connected will be false and request can't be submitted anymore and user space will see error -ENOTCONN. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- fs/fuse/virtio_fs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 9d30530e3ca9..c46dd4d284d6 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -755,6 +755,12 @@ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, spin_lock(&fsvq->lock); + if (!fsvq->connected) { + spin_unlock(&fsvq->lock); + ret = -ENOTCONN; + goto out; + } + vq = fsvq->vq; ret = virtqueue_add_sgs(vq, sgs, out_sgs, in_sgs, req, GFP_ATOMIC); if (ret < 0) { -- 2.20.1
next prev parent reply other threads:[~2019-09-05 19:50 UTC|newest] Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-05 19:48 [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-05 19:48 ` [PATCH 01/18] virtiofs: Remove request from processing list before calling end Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-06 10:40 ` Stefan Hajnoczi 2019-09-06 10:40 ` Stefan Hajnoczi 2019-09-06 10:40 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 02/18] virtiofs: Check whether hiprio queue is connected at submission time Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:43 ` Stefan Hajnoczi 2019-09-06 10:43 ` Stefan Hajnoczi 2019-09-06 10:43 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 03/18] virtiofs: Pass fsvq instead of vq as parameter to virtio_fs_enqueue_req Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-06 10:44 ` Stefan Hajnoczi 2019-09-06 10:44 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:44 ` Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 04/18] virtiofs: Check connected state for VQ_REQUEST queue as well Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal [this message] 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:45 ` Stefan Hajnoczi 2019-09-06 10:45 ` Stefan Hajnoczi 2019-09-06 10:45 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 05/18] Maintain count of in flight requests for VQ_REQUEST queue Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:46 ` Stefan Hajnoczi 2019-09-06 10:46 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:46 ` Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 06/18] virtiofs: ->remove should not clean virtiofs fuse devices Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:47 ` Stefan Hajnoczi 2019-09-06 10:47 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:47 ` Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 07/18] virtiofs: Stop virtiofs queues when device is being removed Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:47 ` Stefan Hajnoczi 2019-09-06 10:47 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:47 ` Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 08/18] virtiofs: Drain all pending requests during ->remove time Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-06 10:52 ` Stefan Hajnoczi 2019-09-06 10:52 ` Stefan Hajnoczi 2019-09-06 10:52 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 14:17 ` Vivek Goyal 2019-09-06 14:17 ` Vivek Goyal 2019-09-06 14:17 ` [Virtio-fs] " Vivek Goyal 2019-09-06 14:18 ` Michael S. Tsirkin 2019-09-06 14:18 ` Michael S. Tsirkin 2019-09-06 14:18 ` [Virtio-fs] " Michael S. Tsirkin 2019-09-09 16:10 ` Stefan Hajnoczi 2019-09-09 16:10 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-09 16:10 ` Stefan Hajnoczi 2019-09-08 10:11 ` [Virtio-fs] " piaojun 2019-09-08 10:11 ` piaojun 2019-09-05 19:48 ` [PATCH 09/18] virtiofs: Add an helper to start all the queues Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:54 ` Stefan Hajnoczi 2019-09-06 10:54 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:54 ` Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 10/18] virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vq Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 10:56 ` Stefan Hajnoczi 2019-09-06 10:56 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 10:56 ` Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 11/18] virtiofs: stop and drain queues after sending DESTROY Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 11:50 ` Stefan Hajnoczi 2019-09-06 11:50 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 11:50 ` Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 12/18] virtiofs: Use virtio_fs_free_devs() in error path Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 11:51 ` Stefan Hajnoczi 2019-09-06 11:51 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 11:51 ` Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 13/18] virtiofs: Do not access virtqueue in request submission path Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 11:52 ` Stefan Hajnoczi 2019-09-06 11:52 ` Stefan Hajnoczi 2019-09-06 11:52 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 14/18] virtiofs: Add a fuse_iqueue operation to put() reference Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 12:00 ` Stefan Hajnoczi 2019-09-06 12:00 ` Stefan Hajnoczi 2019-09-06 12:00 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 13:35 ` Vivek Goyal 2019-09-06 13:35 ` Vivek Goyal 2019-09-06 13:35 ` [Virtio-fs] " Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 15/18] virtiofs: Make virtio_fs object refcounted Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 12:03 ` Stefan Hajnoczi 2019-09-06 12:03 ` Stefan Hajnoczi 2019-09-06 12:03 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 13:50 ` Vivek Goyal 2019-09-06 13:50 ` Vivek Goyal 2019-09-06 13:50 ` [Virtio-fs] " Vivek Goyal 2019-09-09 16:12 ` Stefan Hajnoczi 2019-09-09 16:12 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-09 16:12 ` Stefan Hajnoczi 2019-09-08 11:10 ` [Virtio-fs] " piaojun 2019-09-08 11:10 ` piaojun 2019-09-09 15:35 ` Vivek Goyal 2019-09-09 15:35 ` Vivek Goyal 2019-09-09 15:35 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 12:05 ` Stefan Hajnoczi 2019-09-06 12:05 ` Stefan Hajnoczi 2019-09-06 12:05 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 13:51 ` Vivek Goyal 2019-09-06 13:51 ` [Virtio-fs] " Vivek Goyal 2019-09-09 16:13 ` Stefan Hajnoczi 2019-09-09 16:13 ` Stefan Hajnoczi 2019-09-09 16:13 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 13:51 ` Vivek Goyal 2019-09-08 11:19 ` [Virtio-fs] " piaojun 2019-09-08 11:19 ` piaojun 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [PATCH 17/18] virtiofs: Remove TODO to quiesce/end_requests Vivek Goyal 2019-09-05 19:48 ` Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 12:06 ` Stefan Hajnoczi 2019-09-06 12:06 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 12:06 ` Stefan Hajnoczi 2019-09-05 19:48 ` [PATCH 18/18] virtiofs: Remove TODO item from virtio_fs_free_devs() Vivek Goyal 2019-09-05 19:48 ` [Virtio-fs] " Vivek Goyal 2019-09-06 12:06 ` Stefan Hajnoczi 2019-09-06 12:06 ` Stefan Hajnoczi 2019-09-06 12:06 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-05 19:48 ` Vivek Goyal 2019-09-06 8:15 ` [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 Miklos Szeredi 2019-09-06 8:15 ` [Virtio-fs] " Miklos Szeredi 2019-09-06 10:36 ` Stefan Hajnoczi 2019-09-06 10:36 ` [Virtio-fs] " Stefan Hajnoczi 2019-09-06 11:52 ` Miklos Szeredi 2019-09-06 11:52 ` [Virtio-fs] " Miklos Szeredi 2019-09-06 12:08 ` Vivek Goyal 2019-09-06 12:08 ` Vivek Goyal 2019-09-06 12:08 ` [Virtio-fs] " Vivek Goyal 2019-09-06 13:55 ` Miklos Szeredi 2019-09-06 13:55 ` [Virtio-fs] " Miklos Szeredi 2019-09-06 13:57 ` Michael S. Tsirkin 2019-09-06 13:57 ` [Virtio-fs] " Michael S. Tsirkin 2019-09-06 13:57 ` Michael S. Tsirkin 2019-09-06 14:11 ` Miklos Szeredi 2019-09-06 14:11 ` [Virtio-fs] " Miklos Szeredi 2019-09-06 14:17 ` Michael S. Tsirkin 2019-09-06 14:17 ` Michael S. Tsirkin 2019-09-06 14:17 ` [Virtio-fs] " Michael S. Tsirkin 2019-09-08 11:53 ` piaojun 2019-09-08 11:53 ` piaojun 2019-09-09 16:14 ` Stefan Hajnoczi 2019-09-09 16:14 ` Stefan Hajnoczi 2019-09-09 16:14 ` Stefan Hajnoczi 2019-09-09 16:18 ` Michael S. Tsirkin 2019-09-09 16:18 ` Michael S. Tsirkin 2019-09-09 16:18 ` Michael S. Tsirkin 2019-09-09 23:52 ` piaojun 2019-09-09 23:52 ` piaojun 2019-09-06 10:36 ` Stefan Hajnoczi 2019-09-06 13:37 ` Michael S. Tsirkin 2019-09-06 13:37 ` Michael S. Tsirkin 2019-09-06 13:37 ` [Virtio-fs] " Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190905194859.16219-5-vgoyal@redhat.com \ --to=vgoyal@redhat.com \ --cc=dgilbert@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=mst@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtio-fs@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.