From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Elkouby <streetwalkermc@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Brian Norris <computersforpeace@gmail.com>,
Fabian Henneke <fabian.henneke@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message
Date: Fri, 6 Sep 2019 14:11:17 +0300 [thread overview]
Message-ID: <20190906111117.GB14147@kadam> (raw)
In-Reply-To: <20190906110645.27601-1-streetwalkermc@gmail.com>
On Fri, Sep 06, 2019 at 02:06:44PM +0300, Dan Elkouby wrote:
> hidp_send_message was changed to return non-zero values on success,
> which some other bits did not expect. This caused spurious errors to be
> propagated through the stack, breaking some drivers, such as hid-sony
> for the Dualshock 4 in Bluetooth mode.
>
> As pointed out by Dan Carpenter, hid-microsoft directly relied on that
> assumption as well.
>
> Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes")
>
> Signed-off-by: Dan Elkouby <streetwalkermc@gmail.com>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-06 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 9:41 [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Dan Elkouby
2019-09-06 10:13 ` Dan Carpenter
2019-09-06 10:40 ` Dan Elkouby
2019-09-06 10:58 ` Dan Carpenter
2019-09-06 11:06 ` [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message Dan Elkouby
2019-09-06 11:11 ` Dan Carpenter [this message]
2019-09-06 11:31 ` Jiri Kosina
2019-09-06 13:57 ` Marcel Holtmann
2019-09-23 20:33 ` Andrey Smirnov
2019-09-06 13:56 ` [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Marcel Holtmann
2019-09-06 14:05 ` Dan Elkouby
2019-09-06 14:08 ` Dan Carpenter
2019-09-06 14:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906111117.GB14147@kadam \
--to=dan.carpenter@oracle.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=benjamin.tissoires@redhat.com \
--cc=computersforpeace@gmail.com \
--cc=davem@davemloft.net \
--cc=fabian.henneke@gmail.com \
--cc=jikos@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=streetwalkermc@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.