All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Elkouby <streetwalkermc@gmail.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fabian Henneke <fabian.henneke@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrea Parri <andrea.parri@amarulasolutions.com>,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report
Date: Fri, 6 Sep 2019 16:12:41 +0200	[thread overview]
Message-ID: <48E8A989-AE89-4F59-84F4-075911F4FC75@holtmann.org> (raw)
In-Reply-To: <20190906140744.GC14147@kadam>

Hi Dan,

>>> Commit 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return
>>> number of queued bytes") changed hidp_send_message to return non-zero
>>> values on success, which some other bits did not expect. This caused
>>> spurious errors to be propagated through the stack, breaking some (all?)
>>> drivers, such as hid-sony for the Dualshock 4 in Bluetooth mode.
>>> 
>>> Signed-off-by: Dan Elkouby <streetwalkermc@gmail.com>
>>> ---
>>> net/bluetooth/hidp/core.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> patch has been applied to bluetooth-next tree.
>> 
> 
> The v2 added an additional fix and used the Fixes tag.  Could you apply
> that instead?

see my reply to Jiri. I replied to the wrong patch, but actually applied to the updated one.

Regards

Marcel


      reply	other threads:[~2019-09-06 14:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  9:41 [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Dan Elkouby
2019-09-06 10:13 ` Dan Carpenter
2019-09-06 10:40   ` Dan Elkouby
2019-09-06 10:58     ` Dan Carpenter
2019-09-06 11:06   ` [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message Dan Elkouby
2019-09-06 11:11     ` Dan Carpenter
2019-09-06 11:31     ` Jiri Kosina
2019-09-06 13:57       ` Marcel Holtmann
2019-09-23 20:33         ` Andrey Smirnov
2019-09-06 13:56 ` [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report Marcel Holtmann
2019-09-06 14:05   ` Dan Elkouby
2019-09-06 14:08   ` Dan Carpenter
2019-09-06 14:12     ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E8A989-AE89-4F59-84F4-075911F4FC75@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=fabian.henneke@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=streetwalkermc@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.