All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Christoph Hellwig <hch@lst.de>,
	palmer@sifive.com, bp@alien8.de, mchehab@kernel.org,
	linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc
Date: Sat, 7 Sep 2019 06:39:11 +0200	[thread overview]
Message-ID: <20190907043911.GA21510@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1909061525040.6292@viisi.sifive.com>

On Fri, Sep 06, 2019 at 03:27:44PM -0700, Paul Walmsley wrote:
> - Since the patch doesn't fix any bugs, there shouldn't be a Fixes: line.  
> Please let me know whether I can drop the line locally before I apply the 
> patch, or whether you'd like to resend it.

It fixes the bug that we build code into a default RISC-V image that
we absolutely should not.  And it fixes the bug that the patch placed
code in absolutely the wrong place.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: palmer@sifive.com, linux-kernel@vger.kernel.org, bp@alien8.de,
	linux-riscv@lists.infradead.org, mchehab@kernel.org,
	Christoph Hellwig <hch@lst.de>,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc
Date: Sat, 7 Sep 2019 06:39:11 +0200	[thread overview]
Message-ID: <20190907043911.GA21510@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1909061525040.6292@viisi.sifive.com>

On Fri, Sep 06, 2019 at 03:27:44PM -0700, Paul Walmsley wrote:
> - Since the patch doesn't fix any bugs, there shouldn't be a Fixes: line.  
> Please let me know whether I can drop the line locally before I apply the 
> patch, or whether you'd like to resend it.

It fixes the bug that we build code into a default RISC-V image that
we absolutely should not.  And it fixes the bug that the patch placed
code in absolutely the wrong place.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2019-09-07  4:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18  8:29 [PATCH] riscv: move sifive_l2_cache.c to drivers/soc Christoph Hellwig
2019-08-18  8:29 ` Christoph Hellwig
2019-08-19  4:44 ` Anup Patel
2019-08-19  4:44   ` Anup Patel
2019-08-19  6:09 ` Borislav Petkov
2019-08-19  6:09   ` Borislav Petkov
2019-08-19  6:26   ` Christoph Hellwig
2019-08-19  6:26     ` Christoph Hellwig
2019-08-20  6:03     ` Yash Shah
2019-08-20  6:03       ` Yash Shah
2019-08-22  9:26     ` Mauro Carvalho Chehab
2019-08-22  9:26       ` Mauro Carvalho Chehab
2019-08-31  2:53       ` Paul Walmsley
2019-08-31  2:53         ` Paul Walmsley
2019-09-01  8:00         ` Christoph Hellwig
2019-09-01  8:00           ` Christoph Hellwig
2019-09-27 22:53       ` Christoph Hellwig
2019-09-27 22:53         ` Christoph Hellwig
2019-10-17 17:19         ` Christoph Hellwig
2019-10-17 17:19           ` Christoph Hellwig
2019-09-06 22:33     ` Paul Walmsley
2019-09-06 22:33       ` Paul Walmsley
2019-09-07  4:42       ` Christoph Hellwig
2019-09-07  4:42         ` Christoph Hellwig
2019-09-06 22:27 ` Paul Walmsley
2019-09-06 22:27   ` Paul Walmsley
2019-09-06 22:36   ` Paul Walmsley
2019-09-06 22:36     ` Paul Walmsley
2019-09-07  4:40     ` Christoph Hellwig
2019-09-07  4:40       ` Christoph Hellwig
2019-09-07  4:39   ` Christoph Hellwig [this message]
2019-09-07  4:39     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907043911.GA21510@lst.de \
    --to=hch@lst.de \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.